From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 879383655C9 for ; Mon, 13 Jul 2026 10:09:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783937397; cv=none; b=OkEVsz4juP026GITRNdPif78XfPDF3cQ2b7SLSJXRGMfAxbN4rrgFCL52LrCgxys3++6rplahxz917pfBgy/0t41y8Qxf9io24e4VmjZYHGQXJK1baIOdLRJ3eEaH96a+Gr/rl1uGXhsnQ42SWxG+8Fu5syG7E8A2RfQBe5s7wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783937397; c=relaxed/simple; bh=gAekjFGKEHq9ATR/+uFuJYa0LCHO670PqMr8Feqyb08=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CIrEzULbg9ruCib3BwsYhZ+GQKejde18Fd/y21iyPEVbfIpT3zqY3EU5lTrkjPRY211w/ftKdQtdMw0R6AAV1PK3cBkEUgDoXKwxXVU2fidqdgMRam9M0dfHCltV1MwZBPD/K4bHq9Jjs2oR3bQ66IEFLxWHCmUcLeX5sEKl5CQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=G9usnbEc; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="G9usnbEc" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-475881b9a4bso2926236f8f.3 for ; Mon, 13 Jul 2026 03:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783937394; x=1784542194; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RMaPztzkv7mkAfMpEcEj82JplFx/jQM80q6OSMWqA9w=; b=G9usnbEcxv3o9HfQLYYOUR/3sQnDQAz6Qkjmn80r+x/+4u93vIvNa0m3zk4U/Yhc0r V4VTi76XwTEjbw6qJIAUSbk0UfAvtYxCAdP0Z2q8/pdWEt+pmE8Tz6RUmXE4G9kazoRW BUbMRQSNA7EDcBpi6RGGe8ZGBh4KTIs6H9WkXWn4f016e+wjy/sIws1SgsBRWyA/5m0l /C3AKpNmRVSVp2fmgOR4QJBFJm6ylnLsc0x7f1SdyhGN3vny+hI3jgoMdqxAhNzCG1mp Q7TQ1ubMRLUSUm+r7qO3QrPMTSeQJS0mkbsWmPa7B2J1HHmU84F6PE2rq4HjZugbzXbF ah2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783937394; x=1784542194; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RMaPztzkv7mkAfMpEcEj82JplFx/jQM80q6OSMWqA9w=; b=flNr15zmyy0F8bSQSwYPoZz26/iNG/1cJknGMEYaXQqTgf7NbYjoreE9UW5s2H796y JXphB/JYmm8MDNfSoMw/oXsaBjggXbUuDBCIzQBwhHuBTHkQQ5Fydbt3YDb+pj48w0kj JukE7vzwii4aE72lXDfkoiZ2MQFWEkHYIBUoQZyeMb5yjnKrb4320nsscEv96EEfA99q D1hWw7jeZx8rSJeiAQb/C9BmVNzyp0B/XrBvrpXry6lTwzwy30TnUq+7vfkszqVBv1C7 3Mq/HUDkbv7uDY4cfSrhDEItmYnuqQNk3DocDv8DPmv6hK6Oba34Sm4dfqlIUuwaDSd8 d21A== X-Forwarded-Encrypted: i=1; AHgh+RrldbHcf57OxbxVmi9K0sT+EbCyXN+uMoTR9rknah0KcpQto7/E+e7MyRJtx0SVBqtFHUClW876YE2215M=@vger.kernel.org X-Gm-Message-State: AOJu0YxCcEqLc0fGBvsV2c1p1pulVMIFjLP3qQNGMUGjwE9pWmJXPUOy 2XrPRdV8h7I6U0Fr/5IKuv7HBYWGpwvnwmHR86JWlLpqHrA4cOGtmxwFHvXu8mv72mk= X-Gm-Gg: AfdE7ckqTH3uOuz0YbATj9WLWQ72nPPdxCXSj7X7fIwFKpSpKR////OJgVdSjhcS0AR 9905y/Q4A6sNiZRF9w9oXQ9aJ8s3eGzv/FDhCytvlldSDsvX+5bJ67pOfA5VsUNPPMQHTCWLPou Wiuc/47i0JhH68FMxExThojD3pqfraTT32rmSaNByGDH9PjndLSkyFLL65I1RgSk1UmXPEGYaA+ XCaqTYtC3OP7aH98AI1qUgeEufzugIvdO8qQuZZd7OVNXYtD0Dul4EzHpch8Fm5a1B/30xJVZtt 7VPm5kAXGKAA4twGcHQojLbxlwE728zx0DFyAAjXbAEBbyrtAu9swS+kI/2bu6+uKjDYjPdfC0t y77dpmVpbnroYG9iH4fBH1+kyNFwV2nyVVG60LZbopoTAZ+6lSyJgmdJYOI4z0YBqu+i0eHkgzA 33k5xxGxvJ/j2AjRazBOCf94c= X-Received: by 2002:a5d:64eb:0:b0:47d:edb2:a4ab with SMTP id ffacd0b85a97d-47f2dd2c919mr11096800f8f.43.1783937393990; Mon, 13 Jul 2026 03:09:53 -0700 (PDT) Received: from localhost (109-81-90-85.rct.o2.cz. [109.81.90.85]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039b0cesm86605884f8f.22.2026.07.13.03.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 03:09:52 -0700 (PDT) Date: Mon, 13 Jul 2026 12:09:52 +0200 From: Michal Hocko To: Guopeng Zhang Cc: Andrew Morton , Shakeel Butt , Johannes Weiner , Roman Gushchin , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Guopeng Zhang Subject: Re: [PATCH] mm: memcontrol: drop unused cpu argument from flush_nmi_stats Message-ID: References: <20260713090010.2991906-1-guopeng.zhang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260713090010.2991906-1-guopeng.zhang@linux.dev> On Mon 13-07-26 17:00:10, Guopeng Zhang wrote: > From: Guopeng Zhang > > flush_nmi_stats() does not use its cpu argument. Remove it from the > function and its !CONFIG_MEMCG_NMI_SAFETY_REQUIRES_ATOMIC stub. The > caller still uses cpu for the subsequent per-CPU rstat flush. > > No functional change. > > Signed-off-by: Guopeng Zhang Looks like a left over from prior versions of the patch because there was no use in the 940b01fc8dc1a Acked-by: Michal Hocko Thanks! -- Michal Hocko SUSE Labs