From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A97736897C for ; Mon, 13 Jul 2026 08:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929962; cv=none; b=G+Z85dx/rm58Ht370C1RRV8nLpSBpXjkyGbIU7w7aV5r7tyLSIsx8UTCBRbu3KNY4sIpQUhDJ1TNLzGUEafo6HJiYnvuxBdBlXj4XynIwIdaJi2Bu7XLWryFgjPCMkBnfbuQJLHpUz3FtfP/Uiit4HbttSB9tKbCG1sHycutTNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929962; c=relaxed/simple; bh=rfOt4jyberQp4CJcTQa8rA0qEsOHKM63rerhgeYik78=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JVpTh/qhfUdqT512yWCng+YHl1o2nPgAiHSio3EprMIfzlrxnHpPiD81NWee22Y4Jm1YyYr6KnXouV05MhOQOmlC5m+PAIiy06HbpOAaDXdglxQ1oGtoriSHwYU3EMqr/rJje8GZSK/HqfiQn9Pv/eov0LkZxTF/mH/VN5LoKVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=r70OJ1s8; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="r70OJ1s8" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-475cb71a4ebso2784471f8f.0 for ; Mon, 13 Jul 2026 01:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783929960; x=1784534760; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ClffvjIACe8ETchiqiqAYna+AICp1RDo+AuLSafnSLc=; b=r70OJ1s8Oy91iN1KBdubPWD5Akh2RlPvSiF2mWrizOOoJ4zyC8lRE7I7nXJfE/afOF GdLIDwetgVx7NJG2IwJHeAU0y+xqVu0NOrL1sdjg7FQGkHHCTOKkjWv7MDQAggqQOXSO NyrHol6mGA+xm39pMIybAF3M/J+6p3LrEuqJeqNiZZ9sLzsWoiChl11AghVtCgPMKozS y3KN2YbBeg/tRMgkzhrgPA9pgsUYyamel+bqYHVbAKFKlibCR+8JZ8YM3Na1t8oRniO3 MMQN5kl5IVwF1daA7gZTmlgx6KMbUl5G6ILEg3MRw65v67gJNsDwFwcLXU0QfpuOYjNc hWKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783929960; x=1784534760; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ClffvjIACe8ETchiqiqAYna+AICp1RDo+AuLSafnSLc=; b=LIVgFG+6/KZMfVajDHLn2Q6d/mM52qCXcqbSpHBWQUduSIEFBEj0bWjTFWGygRxSAs GvNGy8SjOMn2BLaRoE1YV7xtUkcTpGiaAVJas8r1EzoqsGI4bYvtg2PO/pv9cTrms+jL LF0Oc6vY4Ah4B0J4k3abkV2iXAP09l37qsAJRBfAV6YbLMk7RBzgXwofcpOSvDOJ6CLE cE5CUJcSjPm6HKCfUoDGDDCzwwLnhj4Ou0FJvcxQDm8aaSEWxiSDpuxcKAWgBrDbPztH 0wf8JSxPYrxC8wHmxuR7Fx0H9dS6YTIMRP8QXzDcztpa/LwsDg9Oeo3AG/uOcIVvvsnw W6KA== X-Gm-Message-State: AOJu0YxAl5tigl8iAUjc8R2JUVydS1UO5nsM0MuKJyrETthi1TIpwyQM xYB7Oq+BvmN6dMp/iA1kaiCHnBAZgdhOvOgbD4EeL6HNmruoSLUKb2J1e1A7P1hsIQ== X-Gm-Gg: AfdE7cmyzvFtPcWsqIOCbmqMbPVrGLU2BxVRTJZpZ40YrrxkwliYlAscFEd3Fa6Xb2c +oJIo3geA9mcFhQTN2svB0MUCTBXD/QoQWjXujs5NVOmw3pOE5nfS/Ip+cxf8SXaq/qc+zUh3zI xHuA6tzVCxxfP5nFpYfSN1fn8wm6nrw4rGDyNqtmb/yH8ncIqrMeiabNjhsBJpdVBU/bIuEQo+L 5oITQMH8XT+gho8xYCSJDCJXSEG9W7B1r/p/p7HIP2xkPXBOx3U1apuwsTb4dzIkC8wIt3dqcku epCo4UNxrETGFFR5TbGjvVAc0CDhVKoonHLUxSAC/f9GjkT3I7JpJz2JytmGcxf2rmW4zJzEpSK ccomnKcnuy9VVhQhOrXVFj0LuKzPHQz0w27GMFIx1s+7AWZJKMt+4hR70Z3zZQoRJNcapwYMu6c /kwVjefdkT39HVi8FayQrPh8cGr4FbhPcfnAsxofIXEgZ8MPx1Y4A= X-Received: by 2002:a05:600c:2247:b0:493:e79e:da63 with SMTP id 5b1f17b1804b1-493f8834ea6mr57976005e9.34.1783929959307; Mon, 13 Jul 2026 01:05:59 -0700 (PDT) Received: from google.com (137.69.77.34.bc.googleusercontent.com. [34.77.69.137]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ad69519c2sm87654632f8f.37.2026.07.13.01.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 01:05:58 -0700 (PDT) Date: Mon, 13 Jul 2026 09:05:55 +0100 From: Vincent Donnefort To: Mostafa Saleh Cc: linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, maz@kernel.org, oupton@kernel.org, seiden@linux.ibm.com, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, tabba@google.com Subject: Re: [PATCH] KVM: arm64: Avoid naming collision in tracing Message-ID: References: <20260712153835.2264905-1-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jul 13, 2026 at 09:02:48AM +0100, Vincent Donnefort wrote: > On Sun, Jul 12, 2026 at 03:38:35PM +0000, Mostafa Saleh wrote: > > When the hypervisor tracing (CONFIG_NVHE_EL2_TRACING) is disabled, it > > defines a static inline stub for trace_clock(). > > > > However, trace_clock() is already declared as an extern function in > > linux/trace_clock.h which is pulled in EL2 compilation. > > I am completely unable to reproduce that. CONFIG_NVHE_EL2_TRACING, isn't a > selectable option, it depends on NVHE_EL2_DEBUG. > > How does your .config look like? > > > > > If the file is included when CONFIG_NVHE_EL2_TRACING > > is disabled (by including it manually in setup.c) it will cause: > > In file included from arch/arm64/kvm/hyp/nvhe/setup.c:22: > > nvhe/clock.h seems already included in setup.c Ha no appologies, I was looking at the wrong branch. However I am still enable to reproduce this issue. So I am still interested in knowing your .defconfig > > > > > ./arch/arm64/kvm/hyp/include/nvhe/clock.h:14:19: error: static declaration of ‘trace_clock’ follows non-static declaration > > > > 14 | static inline u64 trace_clock(void) { return 0; } > > > > | ^~~~~~~~~~~ > > > > on GCC and a linker error on LLVM (it seems to change the linkage to > > global) > > > > Although that is not a problem at the moment, as no other files > > include . That does not seem to be the intent of > > this code and that will cause issues with more users as the SMMUv3 > > driver. > > > > Signed-off-by: Mostafa Saleh > > > > -- [...]