From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF11839DBFA for ; Mon, 13 Jul 2026 08:19:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783930749; cv=none; b=pbFPLla2iR2lMKMfTIk32AN40rpT/56n3N7UD419opX5MnqqX5McDHtjElGhkyATPNeVkKsYxFd6OO30l6Whm32c9deDXRKffnUgzhJ7uutPiKvVmIxc3mi2sCFqLZXzrkA2hHw57pJXR4nrBWqFrS9Bjc28/JRd9J+QK6OoOyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783930749; c=relaxed/simple; bh=rP/RkM2dxwEf7MZOOKY+BHF3arlyhEjPq6JFCLv1B6Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gP2+sZNPM0MJ6W1aWBPzC1pTtRtaLTywzjKz0naE37IcEyhb6JB9A8CE39f1oa6zwP0EEP4aDRnSDnbxlC3aWifqaHQAbEHp/lEv8Xm+xGDzGbX3gGnuhgxMEmFuPE228b/JL7ur5sP+04HhiOxUEdHsZ3Lky167PdeTwV0jmwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ta6opYG0; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ta6opYG0" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-493be0fbcc5so81615e9.0 for ; Mon, 13 Jul 2026 01:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783930746; x=1784535546; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nMhxQOXCpwevLLjNsS6PfLbFdbbTa/KxMnyYoWQBg4g=; b=ta6opYG0DaLwNkjj7rlE62E2vRB41HcBCUxfAdaJVCNgr+l7wbP7+8nhpAoA1XY4wA EtapsMrguBYHdD6Q05UuWw4mwI2RkNK+6/j5Dl9U24wJNW9RQxZ/D7YAcQCcCFsN3U46 diC645NZqF0vGucmO6udX8RE+rAPcGYj4Sqxmu7yIEExmklXJb9Dc+t7ElSYHQ9pryVQ 8E2zUwFLtgVIQkFhf94fmCQaUs6naFJDW2Xg9Oew+Xs84JQnZ0M3vsN7w2gAS6gVshIi eNocrdfGBya0jzLfXm/Y7xipCOg03wZTBI0pfRCrm2OgBQFZIvH0Qq1ZYS7hKYnUzlhw 1hsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783930746; x=1784535546; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nMhxQOXCpwevLLjNsS6PfLbFdbbTa/KxMnyYoWQBg4g=; b=hpVCt+qK4HxOGJ5H2qR2/dUyD/B6AeOugEZoOduvynpzg0EwxVpO9lpV6++QUurXUs a8Tu54V+79D4+SowVX0chBDaLlnHMBU3E7QKDP7h6vdnPLzW1qFRnHAMuohGAvONNuJ5 nr53UwN1WR8aauuNN871SZNAwErL98PU8nnndXZ8MLloWucoarB3zBe8NJV170pzP0S5 xIBc/NKSi2AUhIoKemB5u3f87tAmJNgeF5cpBBIYFMLc2DukgVH/MhkxTLKuRMmp7mI8 WnX5wH1OELmTRyaROD3Gror0PuFboGFVhCIY46iwtCW3v+KHKW2iOiAaPBrq5FMh77wn 0uMw== X-Gm-Message-State: AOJu0YyfBA0DqBRtSCl5adpJoAHJiw6OoXyXmOpVegkWdcKnggxNs3cY ZueoGh2/5EMcYBTNCpXWUSOuHw7b4jgLUKOkk+vKLBiJ2GUMwpImqy+dAH5hJyW5tw== X-Gm-Gg: AfdE7cl83u2HAzkg5oV6RlPuVn3S0f/YcC/vvGvTiT2jCCs/1Q1uVgYRhJpStx8b9PW aEW2rapHwk71sGWSkSTS/XtJHWWBM1j3Nxgv7sKf9TuwDRxrVqBv24TRG72aGMjBrPkMAfxradX 6V/52wXA8HXlDFi48zHYaAaeK4G4B5vI7xQcr0k92PS4mJNML3N3EjxJUFL2BkyAU6G7/54Myrf 8QppqnLzmdiVLl1hRVvCV0lslWXKAcdAzrNYZxjTiYL6VYgdsnQIyZreO7Y2EF27Hx95z7qySkC m/tagAXIyYTFARXWdHTzfHRM01LxnV6uhj1WvpYtiXLUfEEDcQjq+KZuDoewk6jYlxnN9Za3W8+ jDWoRt/aUFYt5YCV5tD6Vin4BbJnoxuhf9PCItOZO7uOIZ397WAmNU9OQnlgzWTvIc0aGNZL3Kk lFKWeq+N/rJgK2eudP0/9ETu18kzFSfewV1ke3SD/7/ZPLZhos X-Received: by 2002:a05:600c:8b6f:b0:492:668f:410c with SMTP id 5b1f17b1804b1-494688928b1mr23245e9.10.1783930745452; Mon, 13 Jul 2026 01:19:05 -0700 (PDT) Received: from google.com (220.60.76.34.bc.googleusercontent.com. [34.76.60.220]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0a558easm85288536f8f.27.2026.07.13.01.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 01:19:04 -0700 (PDT) Date: Mon, 13 Jul 2026 08:19:00 +0000 From: Mostafa Saleh To: Vincent Donnefort Cc: linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, maz@kernel.org, oupton@kernel.org, seiden@linux.ibm.com, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, tabba@google.com Subject: Re: [PATCH] KVM: arm64: Avoid naming collision in tracing Message-ID: References: <20260712153835.2264905-1-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 13, 2026 at 09:05:55AM +0100, Vincent Donnefort wrote: > On Mon, Jul 13, 2026 at 09:02:48AM +0100, Vincent Donnefort wrote: > > On Sun, Jul 12, 2026 at 03:38:35PM +0000, Mostafa Saleh wrote: > > > When the hypervisor tracing (CONFIG_NVHE_EL2_TRACING) is disabled, it > > > defines a static inline stub for trace_clock(). > > > > > > However, trace_clock() is already declared as an extern function in > > > linux/trace_clock.h which is pulled in EL2 compilation. > > > > I am completely unable to reproduce that. CONFIG_NVHE_EL2_TRACING, isn't a > > selectable option, it depends on NVHE_EL2_DEBUG. > > > > How does your .config look like? > > > > > > > > If the file is included when CONFIG_NVHE_EL2_TRACING > > > is disabled (by including it manually in setup.c) it will cause: > > > In file included from arch/arm64/kvm/hyp/nvhe/setup.c:22: > > > > nvhe/clock.h seems already included in setup.c > > Ha no appologies, I was looking at the wrong branch. > > However I am still enable to reproduce this issue. So I am still interested in > knowing your .defconfig It is just defconfig (CONFIG_NVHE_EL2_TRACING is already disabled). If you attempt to include in another file: diff --git a/arch/arm64/kvm/hyp/nvhe/hyp-main.c b/arch/arm64/kvm/hyp/nvhe/hyp-main.c index d3c69de698f4..ca91e453fb10 100644 --- a/arch/arm64/kvm/hyp/nvhe/hyp-main.c +++ b/arch/arm64/kvm/hyp/nvhe/hyp-main.c @@ -15,6 +15,7 @@ #include #include +#include #include #include #include With GCC: make ARCH=arm64 CROSS_COMPILE="aarch64-linux-gnu-" -j`nproc` It will show the above error. With LLVM, you have to include it in more than one file, which results in: >>> defined at clock.h:14 (./arch/arm64/kvm/hyp/include/nvhe/clock.h:14) >>> arch/arm64/kvm/hyp/nvhe/hyp-main.nvhe.o:(trace_clock) >>> defined at clock.h:14 (./arch/arm64/kvm/hyp/include/nvhe/clock.h:14) >>> arch/arm64/kvm/hyp/nvhe/mem_protect.nvhe.o:(.text+0x0) >>> As the compiler would convert the function global. Thanks, Mostafa