The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Chaoyi Chen <kernel@airkyi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Julian Braha <julianbraha@gmail.com>,
	Xu Yang <xu.yang_2@oss.nxp.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chaoyi Chen <chaoyi.chen@rock-chips.com>
Subject: Re: [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE
Date: Mon, 13 Jul 2026 12:35:27 +0300	[thread overview]
Message-ID: <alSxX055MoxkdahQ@kuha> (raw)
In-Reply-To: <20260709062147.240-1-kernel@airkyi.com>

On Thu, Jul 09, 2026 at 02:21:47PM +0800, Chaoyi Chen wrote:
> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> 
> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely
> also needed for embedded platforms. Select it when available.
> 
> Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com>
> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> ---
> Changes in v3:
> - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/
> - Use the same "select" as v1 to make things simple. 
> 
> Changes in v2:
> - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/
> - Change "select" to "imply".
> ---
> 
>  drivers/usb/typec/altmodes/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig
> index 7867fa7c405d..b054c0b6a8d4 100644
> --- a/drivers/usb/typec/altmodes/Kconfig
> +++ b/drivers/usb/typec/altmodes/Kconfig
> @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers"
>  config TYPEC_DP_ALTMODE
>  	tristate "DisplayPort Alternate Mode driver"
>  	depends on DRM
> +	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF

Is there really no way of making this into a dependency?
Doesn't this, or something like it not work:

        depends on (DRM_AUX_HPD_BRIDGE && DRM_BRIDGE && OF) || !DRM_AUX_HPD_BRIDGE

Thanks,

>  	help
>  	  DisplayPort USB Type-C Alternate Mode allows DisplayPort
>  	  displays and adapters to be attached to the USB Type-C
> -- 
> 2.54.0

-- 
heikki

      reply	other threads:[~2026-07-13  9:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  6:21 [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE Chaoyi Chen
2026-07-13  9:35 ` Heikki Krogerus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alSxX055MoxkdahQ@kuha \
    --to=heikki.krogerus@linux.intel.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=julianbraha@gmail.com \
    --cc=kernel@airkyi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=xu.yang_2@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox