From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A938B43B4A7 for ; Mon, 13 Jul 2026 15:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783955353; cv=none; b=J9UvjuwhyEVhoHSwUOU4KEq93+Xlj+TJ9kfjGfz7G5ON7hKGhexSM/te2Jsyf+ZqBONW1q3PEgTfqA0h4hsz6/kBlrWYbduZqk2aHDVCO9cE3Jc7FsXaXBlb4ydP6fZfvT11j8IWae+vzjn15A7Sqnx+xnNDZA834YyWLk+As2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783955353; c=relaxed/simple; bh=iBCTBITROoFtlNKDjrunQPxWWHqiU3SOrFt93K5iEuk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iQoHOHr1W8fOUIt153FM5rTGSt5fycOYu62SRLY/UdjPGAF3EGxal4ZpjTgADFwfym6R6bjpUipk+b04PQ9jprnv15CBhKBsvvxH4OWWTHKYv9NN4DNmL+dK2Mh/HyOSyO3d1obQ9UJBVjU/TCKOOteyzD0jtgDQvrSOTKWt9Zk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=a9xF0d/2; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="a9xF0d/2" Date: Mon, 13 Jul 2026 17:08:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783955338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+M1zr9rTUgQMNlUXBESdweoGf9U7X+OYDnRmO6YXH1M=; b=a9xF0d/2L71ONYPVPsefz3XZSfE3ZamyNJyyyZjrgNziQQUb/Ozdcat8yaN8Sx4s0lz75g QLt3rFlj1NCfC7V+n2SdodAEZULM4owumuDrhIRpdxnMki8Kp/jw5NRdoH0OUJNWOD/Nc6 hZYkn0mKy11XwwDe/1Bb79Xwt/TZwbI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Ritesh Harjani Cc: Geoff Levand , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Geert Uytterhoeven , Paul Mackerras , MOKUNO Masakazu , stable@vger.kernel.org, Geoff Levand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/ps3: Fix map failure path in dma_ioc0_map_pages() Message-ID: References: <20260711130931.740719-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Mon, Jul 13, 2026 at 06:08:56PM +0530, Ritesh Harjani wrote: > Thorsten Blum writes: > > > If lv1_put_iopte() fails in dma_ioc0_map_pages(), the error path > > decrements iopage but keeps using the failed mapping's offset. As a > > result, it repeatedly tries to invalidate the failed IOPTE slot and > > leaves the already installed IOPTEs valid. > > > > Recompute offset and invalidate the installed IOPTEs instead. > > > > Nice catch! I wonder how did you catch this? > Do you have ps3 console where you somehow ran into this ;) > Or was it a manual inspection? I do have a PS3 somewhere, but I stumbled upon this while reading and trying to understand the code. > I wonder whether PS3 consoles are still being used? Not sure. > > Fixes: 6bb5cf102541 ("[POWERPC] PS3: System-bus rework") > > Looks like this was from 2007. > > However, the change looks good to me. So: > Reviewed-by: Ritesh Harjani (IBM) Thanks, Thorsten