From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B0B13090E2 for ; Mon, 13 Jul 2026 12:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783947067; cv=none; b=ebQpvVy7/3weUCPL109x8fEoMzIxxd4XnbEuBvQeTmboflvPBvtP8/5424jPeEiWhIbCmKDsZnxYbVgndkwfyDza2VnwdDZx+ZyMoEET0qIqZRI5kl9HgWfKZpt8PvRyj6bgFR/bD0EQ+fvmjj1+lejjzpV6daZl40+GpsxwK4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783947067; c=relaxed/simple; bh=k528E+foGnZjc/WUKuAV9InREsPYjEI4yQwtIXkIh/A=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lzcT/v+O6hHg0y4cMaVyQSs8Ampm3i82/M3sudYRgmQ1Sw7/AhM1lHweiCf96MBBRnDr4OfTuxYOT7B6Mt5FLPvs3lDLJmc0vtpcxnlhHOZpCI5H8wbFG2+/RilosbpH/BTy9YViZu/Su/43TFG0C++wmaGEm10igIUKS943tu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D2oQIntD; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D2oQIntD" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-475417f010dso1437856f8f.2 for ; Mon, 13 Jul 2026 05:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783947064; x=1784551864; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=l0I/X/UkBYjhgh10fSSEuuuQfKfdwOyWW+HpoEOzWog=; b=D2oQIntDgAq9/lwZ0gSaSGkJ8sx7tpG1PMqft4kWzOkehAyZIkf9t81x/osdTxmz3I 2ykGbEMAOQAJNzbOJwZYIz9wA8NpVnIN1suv5aexQIlBHeP02zLO+EvEGy2W1QikvjIN yVpR1hLDHkWtn+ej5CKUK/vqLbq0cz3+xOAvN5epLji3rVPgpPQeclbXe81mKpZGWtPv sGMx1X9YL7qlspUBhTXFHD2ONq+ZHIJEbPTLcuAn21Y3wcQLCXUIOr0FDAQOy5N5jc2b xC6JeD7yctfWF6FECuAzT0Zbxlxl8Yo1y5ZqxpRDXoPvyUZE6qoewLkeQQOJsoGFUrzc 7YiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783947064; x=1784551864; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l0I/X/UkBYjhgh10fSSEuuuQfKfdwOyWW+HpoEOzWog=; b=E7hGEtG4vC9waXYxbXkb7DKnVdoF4HZ5hf6kSI9HHn5A/uQ+F2fristWJnk3QkMTMd 0DdgrZzMY6aMJfNWbDo31UVQao0iNDnLCgrjxCsHARB322QeBgpRy2o+Fog5Uft6/E30 XDGU6MyB/B9Cyqef12puWfYnbb7YB24gkBZ2RCchbaqaSil8+Z4W+iGCL+PvrAabFq7l nK/PfflYN6rimRA+9iGR8ER2J7EW9dCfGDcX+PD94skJwRuGqmKCd3GO6AdnjgZ7err3 SS4RDOb481JvZHCEO1W7ZHvo6N++/o2zF+XqEFk0yblPA2QLVs8Ddtc2jqws6cKmoyOO 8gOQ== X-Forwarded-Encrypted: i=1; AHgh+RoDjEag6Lyrcz2bVHsKFibCmzWDhjTLUN1XiKWBGIKN7h/tcaB5jv3B5N+iPrUp5vntIG13txNsnelW23A=@vger.kernel.org X-Gm-Message-State: AOJu0Ywv0GHGZW3Cgg3KYVSmq9Z5EuuDrCbHUXmokUHrDmuC59S7E4im awtqYKm28nGrDYPyA7T6rcC3sj+hygRprTfgst1xBJWb+mhTbLROtpDw X-Gm-Gg: AfdE7clT7dzJ8d7LAko7v28kMJjyKmfKHHP5fq+6KW4O3jG5O29Z3HXgIP18+XxH4Nh MisWm4pd0wxN6ZqllfdFZqcvS2FSz/jUJcMw3J+ATGyCtzziZ2/Qf0swQYU7UyG/XmP9rhs5GYY suP07M9I5g1t0n4TwzKEOcUGmlystX5FU6R6ShVVbzbu/16ei+nk+7do+11n0Z/PT7aWJMSwkv3 HvvZ+MUXPL0RfEwuI35TEFGvsZdweWWzfokwUTahvWGZjTc8sg8puTLXP+jtvy5sROrWyGaRND+ aIm+3BSgLCcmruZ+B9qoljtB2ES3MkhRlFGBzNAJV02GAsC+K+cJq8DHU/GtS7FywW0j/cEHngE 7CIoFoloYTGuJHr+ex3YV03DM0htdMSdmVddI/yi7B4VnyeOR4+iV8Yg9SkK8+bMMMd3RRp/n X-Received: by 2002:a5d:5f92:0:b0:470:80f7:9ef with SMTP id ffacd0b85a97d-47f2dcb7580mr9906116f8f.19.1783947064142; Mon, 13 Jul 2026 05:51:04 -0700 (PDT) Received: from krava ([2a02:8308:a00c:e200::86b6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d6da9sm85874543f8f.12.2026.07.13.05.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 05:51:03 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Mon, 13 Jul 2026 14:51:01 +0200 To: Ihor Solodrai Cc: Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Eduard Zingerman , Kumar Kartikeya Dwivedi , Tejun Heo , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH bpf v2 1/2] bpf: Fix tracing of kfuncs with implicit args Message-ID: References: <20260710192940.3020280-1-ihor.solodrai@linux.dev> <20260710192940.3020280-2-ihor.solodrai@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710192940.3020280-2-ihor.solodrai@linux.dev> On Fri, Jul 10, 2026 at 12:29:39PM -0700, Ihor Solodrai wrote: SNIP > + > int bpf_check_attach_target(struct bpf_verifier_log *log, > const struct bpf_prog *prog, > const struct bpf_prog *tgt_prog, > @@ -19121,8 +19159,8 @@ int bpf_check_attach_target(struct bpf_verifier_log *log, > if (prog_extension && > btf_check_type_match(log, prog, btf, t)) > return -EINVAL; > - t = btf_type_by_id(btf, t->type); > - if (!btf_type_is_func_proto(t)) > + t = btf_attach_func_proto(log, btf, btf_id); > + if (!t || !btf_type_is_func_proto(t)) > return -EINVAL; > > if ((prog->aux->saved_dst_prog_type || prog->aux->saved_dst_attach_type) && > @@ -19407,8 +19445,8 @@ int bpf_check_attach_btf_id_multi(struct btf *btf, struct bpf_prog *prog, u32 bt > return -EINVAL; > if (!btf_type_is_func(t)) > return -EINVAL; the btf_type_is_func check is now part of btf_attach_func_proto, so I think we can remove this one jirka > - t = btf_type_by_id(btf, t->type); > - if (!btf_type_is_func_proto(t)) > + t = btf_attach_func_proto(NULL, btf, btf_id); > + if (!t || !btf_type_is_func_proto(t)) > return -EINVAL; > err = btf_distill_func_proto(NULL, btf, t, tname, &tgt_info->fmodel); > if (err < 0) > -- > 2.55.0 > >