From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF4D8346AC0 for ; Tue, 14 Jul 2026 03:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783999962; cv=none; b=Gj+hn3amEEM0wpcVNNEZIwYqaWugzHQpuOCwX3iJxohoyR63qus4Fy7OXNo2inSxIEAzhJhg5i6dUlVag2xDxRMVXvhR1tVudiUD4YX/wr0TDw1LjfHbtcou4rwZgKFmngyhjQI7AMXKIn1SxpB9xK0JEl45y4n68l7+FcvlLyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783999962; c=relaxed/simple; bh=5l6nLVdO88+2acJsOr1UCToSieAPDX3Bwyvphb8xIls=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mn6IEvNl0qC84/EqVwVmUzU1gaA6J7jFgro+Kl0yj9HN8vFLsG0hOEwCg3Ee/20MDLpzPt2oWMcBATLIRaFs/jMntMkMsAIyvtZa+f+xH+m5CKUeHVFRUOA8pszFD9mpY+ad5bQfdu2D5N4WJcZiX/Ne3FNxork0ryWqinXj/+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ArqdH1rX; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ArqdH1rX" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-c15f6d667bcso470006766b.2 for ; Mon, 13 Jul 2026 20:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783999959; x=1784604759; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bdiM3wGZvU9W32ITVwJWXfEY5ZH1jUwmribSUCxIuno=; b=ArqdH1rXOesSkDeZcyrn/gwmYeGCPfhD9ycpZxDFlq1zBr3byohbWaORK5xuqH9P+i Kp7BWm7ILY2LeTUxrHADGfcElxoWDlnPpBhtJ9OwCTU5hkGqqiTWQm0Ywi8VvSYSQhx4 +Cg5J5j7gww51+d9kU01an3h1a3e4Rabush3KBhThPMvWOTRQiNcoknZwBpdgg/mzsTi QmsDm3aZlF/Affo/XDS+kP0YFn2VN/nccOxyxycivjBO/FYoSzCL+K9til6FtgxEq2Qd WLyI7qrwMz4UBX9JArXVYtfRCWB0a9sca3WoLrGIZ9Q8L8TRKbN899ZQjDFxMkn3yxz7 Tg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783999959; x=1784604759; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bdiM3wGZvU9W32ITVwJWXfEY5ZH1jUwmribSUCxIuno=; b=Thyty09RdgEbkRrbJgu/CnjERnMpG+fQyfLDTFk5mNb59hoIlJtMRlGzCa5qGJSpqA 0qMejFv32RDJQELyml0gtmJYkiUXKDhKhlnEWY34WFC26dWF/al68NJ0AauiRIEwUkdF r5OMw68RlK5ZwUgplOfjCg0SnrvBuAsfW7PM3QkyFwTYkmrkMDLzeoxTMSwmbizr5Ckw zuP88WS0de3sa5JwdFi004l3wceEeaiTkGqkaXk8xYWM5Ryr1Hqo/A8Ba4QQ18lFPOVx kW1si9DHj/FWjs9Hi3iKRWCPk4Ateua0p2tEIRV/HNlel+9DF3umzuZm+qcT78bl6uu0 aBzw== X-Forwarded-Encrypted: i=1; AHgh+RrXPNo4jvVh0xTh+/QGHDwTzuHKWqyJg8FApWZt0L8dwttI7/hqttKt6h8MZzWCw20YSdPSd2YXYxSxqPc=@vger.kernel.org X-Gm-Message-State: AOJu0YwHQkXu1/HqS6qrUBM9ImlnV94nxlMNR+ElASP0EmzYbDeyyJfO XZ68A4JOMFQNmsgvi2a45lfLz2KHTJhsnSDPnEXg15sREIt6OscZeJAPcnj/RvZca78= X-Gm-Gg: AfdE7cnXWxl4ywpeDg4oWrRjrLqFZ6nHv6TyOCx4heXuhW9xyf20vDNY3CgiFy30ws8 U8Uf8Hc3kgf8g8TWu5CmRlyKxO7GSlRbXAJ8vaaVLaI7wNghf3sGu9R+fEWlZDbs4UHzTIjFMOU M9+akpKBymguC2xKkamaB8VTp6kqN+N6ZXbde9k3jl9ByJg5zg3A0+xL3FmDvoZODqyqAZTh1cU yM0ppouojQJ57P6heezN+tGxL9krHO1TuwSncApo8ljXH/VOpA06Zd7aawevQUqyNYNq8FGzT5P t2611rU4ASgj1a/siScfCFv81gZs1nOUIvDgmDbUpqecy6a33NPFQM2/9R/1uW+EZmUQ10YsgjZ g4H5Q9XejmWMw23ukzZtJ/2hXghX+oDaEA78Mwr+yJoKF5djpRvcdPYiZUj0TipXQbRQZzyv6tF 8xv6+jP3Ow/XV/W/mYWkQa78AkoHFRuADgTg64eU2t3l4= X-Received: by 2002:a17:906:f587:b0:c15:e8c8:34f with SMTP id a640c23a62f3a-c161e84b4a7mr493269566b.13.1783999959174; Mon, 13 Jul 2026 20:32:39 -0700 (PDT) Received: from u94a (27-51-48-151.adsl.fetnet.net. [27.51.48.151]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ebcb2b79c9sm14334466a34.22.2026.07.13.20.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 20:32:38 -0700 (PDT) Date: Tue, 14 Jul 2026 11:32:29 +0800 From: Shung-Hsi Yu To: Eduard Zingerman , sun jian Cc: bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Mullins , stable@vger.kernel.org Subject: Re: [PATCH bpf 1/1] selftests/bpf: Enable BLK_DEV_NBD for raw_tp_writable_reject_nbd_invalid Message-ID: References: <20260713063513.215781-1-shung-hsi.yu@suse.com> <08508d2133284d49e1da297895c85cf854a97bf3.camel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08508d2133284d49e1da297895c85cf854a97bf3.camel@gmail.com> On Mon, Jul 13, 2026 at 01:47:18PM -0700, Eduard Zingerman wrote: > On Mon, 2026-07-13 at 14:35 +0800, Shung-Hsi Yu wrote: > > The raw_tp_writable_reject_nbd_invalid test relies on availability of the > > nbd_send_request tracepoint, which is only present if the selftest kernel is > > built with CONFIG_BLK_DEV_NBD=y and the kernel built from current BPF selftests > > config lacks. > > > > Without it, the bpf_raw_tracepoint_open() call always returns with -2, leaving > > raw_tp_writable_reject_nbd_invalid test always passing without exercising the > > checks bpf_probe_register(). > > > > Cc: # 5.2.0 > > Link: https://lore.kernel.org/bpf/alRtilWhKw4zzMkI@u94a > > Signed-off-by: Shung-Hsi Yu > > --- > > Not sure if fixes tag is the right thing to use here, so use the cc > > stable tag instead to get this config change propogated to other stable > > branches to make stable BPF CI's job easier. > > Shung-Hsi, > > Thank you for figuring this out. > I'd suggest we switch to bpf_testmod_test_writable_bare_tp() [1] > from the test module to avoid the config dependency and let > Sun pack all of this as a single patch-set to simplify backports > (if such are necessary). Wdyt? Make sense, that's probably for the better. pw-bot: changes-requested @Sun can you make sure to include the follow tag for [1] when you send it? Should give a better guarantee that is will be picked up by AUTOSEL. Thanks! Cc: # 5.2.0