From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 556FB2F9C37 for ; Tue, 14 Jul 2026 07:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784012705; cv=none; b=jkxdU0crGAXYLPWCp2PJUDcqfO9P+NJ3iNxUsXwsWmIhW8CgfZuIl3geqGEQ2GsCTkflZYe6FwyuyWL0KGmNvuMlzcEI4W9c2bicUqpGDlYHaEfLujqGq7b2hBW+ehHdiwpGY8JJP/nNVVWC+RvuYpGj5lF3VFXKDsLRnsLnDXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784012705; c=relaxed/simple; bh=HO/sIgNPdw7t4nLYxmowkr+/DfStiW/sFeXA7ShWpaE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cXSJF1avsK4hRtPwNrktJH1bmHYzM43GgK6gHRIGQKwtQH5K8fMyF6Yd4BGU2I0NUj+hmOenOqUNw6l8/cP917RfmFAzbLnRa7rvBQrjKJMPzaAtf4G6UTO7GXLOBlNESRUZN1ecZcDzv/zskdiS2w+MbdDXEfiqNeiAhdTOsrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NULitTc5; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NULitTc5" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7e9f1f24cbcso530797a34.0 for ; Tue, 14 Jul 2026 00:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784012703; x=1784617503; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=iHa72c4+nay2FoW1wgA2FzfDfV81XjSTaeTSFxhPGw4=; b=NULitTc5nB9ELMOiR2m4vpuAM1KgyfOq0m8uOYdoL+rWJjTlTwmOuzYKzutzfZ6LQK yaD99J40u2zUxbSuGgroOpRs3VjVWIg5zRAsGizhdqski09TmYFbVry+EomXU6SlJkFU UtiAJEGzfnO5MB81Dr84UJXK30hsSItVHyxmxc65Apx8gJjyRNAHHGB+4ba/cI9nNurk kQoX77O8KnxcX3BKy4l8FnA39dsNxnX+tA9Dk4BEcaWNjhCbonSVPHZCNxmGQdUjHbGJ 2BSEcjgOk8yj/KvgIqJbt5Qi+k58QJElgE/Gjr1FoXk9SwI7UvmFvPK17LG+ic6NLgNm FBqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784012703; x=1784617503; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iHa72c4+nay2FoW1wgA2FzfDfV81XjSTaeTSFxhPGw4=; b=L9M2g8tqk5RkC+rcKGmTGHM9vgpKO8z8ZthHcl/4jATymz8B082O+SXecqChv4aY3v an2bCSkHsiFx9KTY6dV/hepdn42tgi0avWfOHWIygjfv4F8PYgfyvvkbgrN7FhbnsW7F Dg8OSO6PEa0b8UYRHqXFaH/pbobG5AsEkRmWmEWXCriBEkZwJE+1HcHVuFXx1JzeOyeX 6iI1zhB+KTyVdp+sf/FXmWYuut/LXTZeOziFpCzQF2deEo1rpkxjPBKnk+MpCAs5TnfP JgOn99CZRHKyjaZprnTpB/lZCUp37cQLnruXrH2cwjIrx2q3d/mTpHzpoJck9yublYTH nNxQ== X-Forwarded-Encrypted: i=1; AFNElJ88OGtU7m1+/Q970ROznT2ofiDKKDJdVK8aOyj4XiesVTcNUxl4T6/BL6LlbuASUmLDs47K6buArR7S6U8=@vger.kernel.org X-Gm-Message-State: AOJu0YxnteWJ6tZOQlLNDQWHvFayWd2xKdXQ3+s/BqXQ3UfCVdPt71Z1 Y/3m0FUOf+G1DlmxzWVHJkdEcDKDmv9gyF3KYo4kRb6H/V6nkmmrKG/N X-Gm-Gg: AfdE7clh4GcdsRo+fIeXCArxff9tp45aiFB875AZ3gaEzZP0LEtb1tuNecODViqjYlQ kAwVK8CR7llctYNxc4LqlmT5RovcWfUjbpyfhSFlJH1tEg1lQmcVQuZL7bBbQLR7D+q39LOWrMg hZKiAm3Kocln8T24vEnQGtwsJW/NnMkqh7E7YIXksRjvnJT0s7zXe+3Ki5lhWamxsi31XioihZf 1mss6qgdrzuGKSBvA5tUqdED+ef8R4WuGhWFCYula0TfQH5xnxMyRWP3Upt4MlSzCsqU91YpSuT CQX43lzUakmldATpPA8j23hsJ4o88qAbeqxZZ80Th3V4NoMkYXOUDkuIsntw/Ag1NYIWSzAjbR2 mK4ffeEA8JepvY8Z+/m7xyC95+eeDeC1vAN2foG6WxhCUsXj5VjYPoPONMTLjj0gDax0+kBOaDd TAVEV4 X-Received: by 2002:a05:6830:8218:b0:7e9:dfc7:5523 with SMTP id 46e09a7af769-7ebf279d733mr6723853a34.10.1784012703208; Tue, 14 Jul 2026 00:05:03 -0700 (PDT) Received: from localhost ([74.80.182.78]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ebcb3f6826sm14711533a34.27.2026.07.14.00.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 00:05:01 -0700 (PDT) Date: Tue, 14 Jul 2026 10:04:55 +0300 From: Dan Carpenter To: Alfie Varghese Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: uart: return tty_alloc_driver() errors Message-ID: References: <20260713170845.1518-1-alfievarghese22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260713170845.1518-1-alfievarghese22@gmail.com> On Mon, Jul 13, 2026 at 10:38:45PM +0530, Alfie Varghese wrote: > gb_tty_init() maps any tty_alloc_driver() failure to -ENOMEM. This > loses the real errno returned by the driver core and makes failures > harder to diagnose correctly. > > Return PTR_ERR(gb_tty_driver) instead so callers receive the actual > failure reason while preserving the existing cleanup path. > > Signed-off-by: Alfie Varghese > --- I don't have a problem with this change but the commit message should say that tty_alloc_driver() in this case always returns -ENOMEM so this is just a style fix and not anything which matters. regards, dan carpenter