From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 427C83EC2F6 for ; Tue, 14 Jul 2026 07:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784013634; cv=none; b=G7TpskhcK2RjR7+j6w9QsfUVnDEx+Agmusk38HGljxSoJS6z9KFoLj3j/i4i8SnfORXBLNMXCMwk3+T55qUIhqono18Y726bLkY+BAh/GAW97ZMN7jOYq45TmXbH8Mpg0HCfbZ68CbIzBYlw0F1PCEZhmgQ6PY6GDSORkt4pXkI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784013634; c=relaxed/simple; bh=0fAdOWv/wZxG/+FHQr4Br7W7JkKnKTmywTnQ8Ia2Eoo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z93PIIWxrmoBbZjsgDjeYWil+YvJtua2yejikYoWJAkBWbBkZNYL27DVKYrBvvKBVsI/cCQDUztahNkIPF+PQiofXjbxyRmP4o9Nvj8oWlalvv6+hcQMGoOLq1AYmnUljUTvQ+oqygiQObeWlylTkRpIbUTND3uKnaOGkL7CKgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eH5hMEtb; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eH5hMEtb" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7e9eaf04bfaso1431520a34.1 for ; Tue, 14 Jul 2026 00:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784013632; x=1784618432; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Byci8e0G2bo3uIP1pnZZvRGU8unL40JtAxaPq207uTQ=; b=eH5hMEtbsxZXIg2LbFDaUJd2MK03imaNJJrRr+HdxaB6AmKG0e9fpcdVmryFMmCKQ4 uc9uMpkjY+O91rOBVsHjQfxhz7zXfy/hDYRSw934FX1VVfyth/Ku4qMYUVi9HNPGr36h 4qOiVbaBTQA14H46dfsCC/9pCMTfy4EfzD0juBWcz09Xi8ZXOqZUGgVvpjq5s8898sGw yrh+87g3PbfpbZl2tH9g0+HHX548c5cEgn3LHYUF2HnNjJSzS8v6o3+yh1L6XehHzCER PRWVJT3M9591A0+RuReyoZ18wl1cnN5AgF5La3YCnDe3JStrXEHSxtF9Kb6rLiHwe54F qWaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784013632; x=1784618432; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Byci8e0G2bo3uIP1pnZZvRGU8unL40JtAxaPq207uTQ=; b=QtKcZmLJFfL41MeME6B9GrziXE4GBnuya4rtpKYMEm3L23+VTBoi4kG9iFwGYHiMy9 OfRgbPcwl+QkrsHVN9gqCZneelC8uQ7dnPg6A6ZE9INrFObTz41LV0p5Ld4+PbpnYNzY ec/xsKPTna1OKmovO1l6C+UUMpBYaJ4Oqq6IJYfvBFrNfBsennEVvJ02tJtahh9UiU25 0xHMK5EHNcO6oY1Bi3smygRhVANNjg4IgkKqJKK0iCIpCL5S/kXqEILQI8Rn+NKGXQOJ nHU3wYB3Mjelfa+0MF6L3ztYhVYUNB/+JtUCY7l2ZC8CG0mbzVg6Svex419ZNPpU8ayw 4JgQ== X-Forwarded-Encrypted: i=1; AFNElJ/iqIixo4Ye0KFDckHYjVLe2h/YvuIkKXnkNUmzL4hy5ggCcJqOY5BK5zAJtb+yU9OkkVMdyIeNEai9lUk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/y8wTiXKQMlqvHXf6Y5+ni4VLIprD38BzfUIfRiUBjfi8uYhF K2fGyI002HqpxKsZYZwerzgsl6KRYBdljOCuW5BmAJFjrzmGyNcqBR+d X-Gm-Gg: AfdE7cnq306GmJFGKCxZRFvWWEtM3ERnJfDddrZFt8aB08fetWdxYKPMTAyzyCF+gWK NMRhUnIDUbtsX+IA3t9FcYjOLlgJt8clj/j3QL/BgpOV6QbG5UvyHQNVWI1mxiu7ydKDHym8XKR vLns1WFmMlwHgIq/JdlrMl85J/ndz94ogghBRxu+LVygKp6X8hdYdDBYLtFg0N53DmkNa2GruCU tx1uTg4F25R2RCyueP/4QcPPRGee6/GNm2G/jW0ar3HbVZP1uXzb5X6vuIuDqPssTEWaMg5tcqY MvdurKy+LLOytRImpi+DtDvQaWJMtaaU+LWumfIS66IJnh2HjcxaXUIvi7XdUo3pXaf2hu/69FI KSnODOgaNUKbqXZDjfzlYHHumNb4IG3AKkgPZ1habb79+PQh3BlZ+VgLWFctwB64GuBewPQoYjk 61W+1B X-Received: by 2002:a05:6830:310b:b0:7e9:e1ec:c818 with SMTP id 46e09a7af769-7ec09802247mr6902810a34.25.1784013632157; Tue, 14 Jul 2026 00:20:32 -0700 (PDT) Received: from localhost ([74.80.182.78]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ebcae1dce3sm14604988a34.3.2026.07.14.00.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 00:20:31 -0700 (PDT) Date: Tue, 14 Jul 2026 10:20:25 +0300 From: Dan Carpenter To: Ivy Lopez Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: use kfree_sensitive() for key material Message-ID: References: <20260713233401.48262-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260713233401.48262-1-skunkolee@gmail.com> On Mon, Jul 13, 2026 at 05:34:01PM -0600, Ivy Lopez wrote: > The set_stakey_parm struct contains a 16-byte encryption key. > Use kfree_sensitive() instead of kfree() to ensure the key > material is zeroed before the memory is freed, preventing > potential information leaks. > > Signed-off-by: Ivy Lopez > --- > drivers/net/ethernet/faraday/ftmac100.c | 47 +++++------------------- > drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 ++-- > 2 files changed, 13 insertions(+), 42 deletions(-) > > diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c > index 5803a382f0ba..adb318925f44 100644 > --- a/drivers/net/ethernet/faraday/ftmac100.c > +++ b/drivers/net/ethernet/faraday/ftmac100.c > @@ -49,7 +49,6 @@ struct ftmac100_descs { > }; > > struct ftmac100 { > - struct resource *res; > void __iomem *base; > int irq; > > @@ -1137,11 +1136,9 @@ static int ftmac100_probe(struct platform_device *pdev) > return irq; > > /* setup net_device */ > - netdev = alloc_etherdev(sizeof(*priv)); > - if (!netdev) { > - err = -ENOMEM; > - goto err_alloc_etherdev; > - } > + netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv)); > + if (!netdev) > + return -ENOMEM; This is unrelated... regards, dan carpenter