From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 863223FBB67 for ; Tue, 14 Jul 2026 08:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784017792; cv=none; b=QOFtaGIPQbgaFWtCPyj50dhyo5v9PmaJO2kZm5icMPpqeOYy/xQz4Zl9P/dLkhM2Kz7wSUHlTkhIxCbOWxFs1EFsdOr+9BuSZk9CwLGpWBB+/uw6WdJ88RsInXqU7+B7tThU32hHc6sIxLOZ1NJQRaHuZUZ38rfWiL+Y+BvYy8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784017792; c=relaxed/simple; bh=ocFVzAC3/f6XF2JEGGnEYrZo88e1CemFP3AD9C04FJY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GDBC60+yhmzHsYTfOkI2y1SdoqoM9Bto/JCyuiTE5wvoO+gtBwTEzYZYh/f7JjNk2aCrbJxhhdCa+1O9VUf67NZ58QxwB8Iqlks48hh5MObWxwnX9Xkmbi9Y0jB4/gxQ6r4JXbpVG+1Uim42Rgzm+jPGV30WydPYI7I2J0HvDHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=iPc7umib; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iPc7umib" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-493b8d92a4eso42085e9.1 for ; Tue, 14 Jul 2026 01:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784017783; x=1784622583; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=h1XR0xXH676IkskJiy7lkXwYtMlnQ7GpPOPMnybj7LE=; b=iPc7umibWtq39Iuce7SjHreP9DkO3AMv1VEW9KHURJl8TuVmpw8BmDZrpJ5K3zV/DF i4NUejYprA3eeU4MA3F/Qrz+lwBgqHpJgvmz4bSCHHhG9URLiDCkP0j2fyKntFGHDjmY wq4iV7HmY5W8ErHmw5NkJ3ehHl3EdSe6YINXoEJdV8wTOGE5nusfr3Ob4n162K3oB/k9 9trA9CDD9rrFR3/R+B3FQpZKEqHoupO6+9MPBUJekrKIIVFn27MeXVy9tE/S/gpYgpCf ipS8rEMYb7klNyFJkGbITuZpjeAoe5jlS3CyyWeABX1osPORDOmsf+NtpGJQRcGE09PN VNEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784017783; x=1784622583; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=h1XR0xXH676IkskJiy7lkXwYtMlnQ7GpPOPMnybj7LE=; b=ZO+aopm0px4ARpgDX2T5HAMRx6WXTTCOkSkQhL5At09nXvqTdv5otRnSH+mf+Emjpj H3q/HmoYEJT2ZRzEqx3pF5E/nSdS5GLsUlwndAPlUNbI4uqAD3Y9D4xn8/07dQECAGKK kuM/jMbxd1Z1whYOp9C427CCrCKSfHYcrJqjIZeNOx6w23npb7icebIOEeIAAc8+Z2S/ TQ1J2Zo6RgSQ0Ow+D4sqYpC0qDmLmuAm6XN9a0CH6hl4Vk1Ielg7kRgF09I/BhR63bo/ 2GRa6Hc6RXPo3mm3byDP8lvDorjiRfhtWMHpEfDUvj2TGIzY3tWdrDKdQkgHR6XJtF5I rAfQ== X-Forwarded-Encrypted: i=1; AHgh+RqSjWhfsEu0SWRphoeEit1NFXmBk+KBMbq/Nvv3KsjaeJ9Owl8Uk7s3yf2pXuWRgVpvAJ3ig4GPBt5mmtU=@vger.kernel.org X-Gm-Message-State: AOJu0YzuDA4GXGJqjmle1ttdftIGDcq0cNTTXhbYo5RI5ihgo2JwEVd7 PyuraaVpUev5+JShsrjAYUzTW1MwzhNJJLH2QBjNQXBp4f9u33HZBeXt940YqDVepA== X-Gm-Gg: AfdE7cmtc+o8gAsBT0/76v7AWxz3LNTeY4uYZP1JeN6gCQxvSZ/4Yr/WpuIU+VDXlnm GvbzMRC8NqYn9gXMwtMH8QpeFKYOiSIBGbf9OWjBKmjq/0xTYNh1wyFeRgGrU2RV652paX/bC0B LD0G2ibKJu/NIoIY/duR3EpJedlQJ9aueE0ZHIOzD6FDlTQ7WLhpDomoWG3owqNbweLLxEM3x69 2dSN6dcrCMPlKc58YHbnK5XuwTrGFgdY9+APLeEr55VF0+xNFqX2uoH2mvSquFGoGIMjtyVdAIg fsG6JU1TYIrbpNUn4PrgAB3w82rQkjLc8cvTepG4vwYkFa54C9fAVnZkKrWxN14X7fp9/czOdmJ r1rE/tBvlxPPDZjPgJ/vQIpixIk2Ci0zaZdGgH8C3N9xp6p0YjH+mX1QVYZB1tbvLd+82o2wO/r ItIeeR9VF9StnVFYfyzjVrC94keKwSVGIchuZa9RgPH2qS03d6 X-Received: by 2002:a05:600c:621b:b0:493:b169:784d with SMTP id 5b1f17b1804b1-49462165300mr1774335e9.8.1784017783083; Tue, 14 Jul 2026 01:29:43 -0700 (PDT) Received: from google.com (220.60.76.34.bc.googleusercontent.com. [34.76.60.220]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464c9cc3sm6301185f8f.35.2026.07.14.01.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 01:29:42 -0700 (PDT) Date: Tue, 14 Jul 2026 08:29:38 +0000 From: Mostafa Saleh To: Vincent Donnefort Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, jgg@ziepe.ca, mark.rutland@arm.com, qperret@google.com, tabba@google.com, sebastianene@google.com, keirf@google.com Subject: Re: [PATCH v6 08/25] KVM: arm64: iommu: Shadow host stage-2 page table Message-ID: References: <20260501111928.259252-1-smostafa@google.com> <20260501111928.259252-9-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 14, 2026 at 09:16:29AM +0100, Vincent Donnefort wrote: > On Mon, Jul 13, 2026 at 06:19:24PM +0000, Mostafa Saleh wrote: > > > > That would walk the table twice, first time with a massive map, then > > to unmap the pages that was just mapped, issuing TLB invalidations > > for all of those, also as the IOMMU page table code never frees tables > > that means we would immediately exahust the IOMMU pool. > > Well the massive map is pretty quick we would mostly just allocate the PGD? And > then it would be just for the subsequent unmaps to split the blocks. So nothing > to be freed really and no risk to exhaust the pool. But if you put the calls to > the host_stage2_* functions that's pretty transparent. Not for the IOMMU, everything is mapped with a leaf mapping, because the pgtable code does not support splitting blocks, this is something I plan to add support for in a follow up series after this one is merged along side other optimizations. > > Just to make sure I am clear. Here's what it could look like: > > in iommu.c: > > int kvm_iommu_stage2_idmap_init(struct kvm_s2_mmu *host_mmu) > { > u64 addr = 0; > > for (i = 0; i < hyp_memblock_nr; i++) { > kvm_iommu_stage2_idmap(addr, reg->start, IOMMU_MMIO); > > addr = reg->start + reg->size; > kvm_iommu_stage2_idmap(reg->start, addr, IOMMU_READ | IOMMU_WRITE); > } > > kvm_iommu_stage2_idmap(addr, kvm_phys_size(host_mmu), IOMMU_MMIO); > } > > in mem_protect.c: > > int kvm_host_prepare_stage2(void *pgt_pool_base) > { > ... > > return kvm_iommu_stage2_idmap_init(mmu); > > /* > * From here, all the changes to the host stage-2 will be reported to > * the iommu driver > */ > } > > On the pro side: no custom walker and we really couple the iommu idmap to the > host stage-2 map. > > On the con side: As you've pointed out, we'd need indeed the iommu to be ready > early enough. > > If you want to stick to the snapshot function, could we have the walker to > first walk the hyp_memblock? the .arg could just pass if we are walking a MMIO > region? That would avoid that find_mem_range_from() and I believe would > massively simplify the snapshot walker. > I see, let me try that. Unrelated to this, but while looking into option#2 I see that __pkvm_guest_share_host() does not call either of the host_stage2_set_owner* so that requires another explicit pkvm_iommu_host_stage2_idmap() call. I still plan to use option#2 in v7. Thanks, Mostafa