From: Thorsten Blum <thorsten.blum@linux.dev>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
x86@kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 0/3] x86/vdso: Improve vdso=/vdso32= boot parameter validation
Date: Tue, 14 Jul 2026 13:19:34 +0200 [thread overview]
Message-ID: <alYbRk7kaPGEveWS@linux.dev> (raw)
In-Reply-To: <b03d7122-52a5-4539-817c-15735a774ef7@intel.com>
On Mon, Jul 13, 2026 at 04:40:55PM -0700, Dave Hansen wrote:
> On 7/13/26 16:34, Thorsten Blum wrote:
> > Replace the deprecated simple_strtoul() [1] with kstrtouint() when
> > parsing the vDSO boot parameters. This provides strict input validation,
> > rejects partial input, and warns when disabling vDSO for invalid values.
>
> Hey Thorsten,
>
> I'm curious what motivated this change. Were you trying to manipulate
> the VDSO and ran into some difficulties? Or is it a larger effort to
> audit and simple_strtoul() users?
I just stumbled upon it while studying the code, and simple_strto*()
calls are often an opportunity to improve input validation.
prev parent reply other threads:[~2026-07-14 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 23:34 [PATCH RESEND 0/3] x86/vdso: Improve vdso=/vdso32= boot parameter validation Thorsten Blum
2026-07-13 23:34 ` [PATCH RESEND 1/3] x86/vdso: Use kstrtouint() to validate vdso= boot parameter Thorsten Blum
2026-07-13 23:34 ` [PATCH RESEND 2/3] x86/vdso: Use kstrtouint() to validate vdso32= " Thorsten Blum
2026-07-13 23:34 ` [PATCH RESEND 3/3] Documentation/arch/x86: Remove obsolete vdso32=2 compatibility note Thorsten Blum
2026-07-13 23:40 ` [PATCH RESEND 0/3] x86/vdso: Improve vdso=/vdso32= boot parameter validation Dave Hansen
2026-07-14 11:19 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alYbRk7kaPGEveWS@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox