From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67A24481244 for ; Tue, 14 Jul 2026 14:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784040427; cv=none; b=mh+3fdpBTwWSWpYN0bL8SbtLi2q7nIIjCMI3aF5YI+eOz4yyxAFKIVhAG1ZwYW/MNuxD+ZUd8BkFqz3kkedeM4UAdUG5rjFY+dhGuKNuRzs7cBgxAPdtby9CCJJG7ckxPZpls2iCRs9K7gN5ImWmuF6w3I1AJLH92txKEL60SU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784040427; c=relaxed/simple; bh=amzjsuVuOYLtmAs85CfONwycFsfOOuggu8e/W/O3Qg4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UadHcgkRUhLC0+AjAtqw7/illeH23AYNJxzU1f+1dPblP7+6x/uPQC9pAoWSYUUzpOzv1l2aQpV+aPhP1fp/uFC+Dh0yhQ7lPStBlZXT6yzVWqKslu3PBgnwt14wDuukrH3MquG3wOt0NvqvUz7nOtX2DiPpxocBEnzo/HjaYxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qgRjjc1B; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qgRjjc1B" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7eb42a2f5feso1792268a34.1 for ; Tue, 14 Jul 2026 07:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784040423; x=1784645223; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UBozPV9Nwke2ViZ7Pjz16VXhYTkzVAfqm4bdfsxTzUE=; b=qgRjjc1Bf3YSHbBWNy4jaC/sGyDsbyD+S8MZYjZomHkd+US/glfsPvDhAlk46gaQ3F i8a6kOzQbS+52WE3U/9gdjTt8GgAA0fKAyaO5aQWKMCduQNEMU6xXNhWnCwEteUjsu7y GCs4Kn1r+wMJ8obauo7z7lLRsCjPA9rjCyU2XtNeTK35aprpno7+F7C/mDv5qa3WuBGF ZTEE7HAtKLYdoiM+9ucnI/RV/RyAHghKQ43cwNRGy9s//3jzDmX9VdaQsYv0VXJrw23m EtY3/vgGSizJr9MF0vvPpq82R6s+eFgCJ+VWL5NCpdHMgCZcv18LRUJWPzWEcYuXlvGg 919w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784040423; x=1784645223; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UBozPV9Nwke2ViZ7Pjz16VXhYTkzVAfqm4bdfsxTzUE=; b=h4CepvJZAm2XPpkpVbXhj2UyxaOvTfz069CrGk5ptaZF8rd9i+gzxnffWrtBpiolED xtQvCSpqBL15kOyLzWgHZ8oQuALUEq8JDVgA/KG1avrtoS6DMC8VRbA1DFioKTTpXToM m/VOn+eVXXT8GphmUWCd7IRzWZUSHUBokbQ3V7EXyJAv06ectmQcWr9JWDiqeZvFn2sm izlLYSBw3KQKCnz7HlKF/NuMzm8t/chM9qRjksxUij002z3+BK0juvnl4f/GI/8j/W/L IRK7QN2/L2x1eyBv9iR56sU3V+ypvaRP2CwMeGrvu4TWA1nqZdgPCdbFUALi9rfV8Jfl wtMQ== X-Forwarded-Encrypted: i=1; AFNElJ/hwNuwOAIJErI6JFttAta4ET6aPkm+FqvSbW88Lq+DzVEc8Y9v7jb4ASBvfpX5+1szKZjQEWAvLtPjESg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzyfdchg2wMNTTMVxtE7WyTiLeP1fGNyVT8b97UIVgojHmatGQj axlf7pS/m2IFaIJZSkS7yLE/XMmhmgpX5f6u4zMq3V/0aUdAX5VlnSRh X-Gm-Gg: AfdE7clqG8j7ByjpXrK+bHixhMy09zOL+V2UOGE5Eu/odrMUWYVVvObUNB442AameQP bYmbRkIinVIhShHlDkQDMtMK8jNhjpWA9N5Vri31fROZbzrEFcFvgB00lL/PND5XvG4+09WAFQz gnAXWz63OOvVyZptf7vKjidoOgEe+dJF00uEWippLBqAtMOUrhljWBjvA3OzOaRkes5Qo0swWgP 2/2pFDsm2splWg5j4MSnpePAQBGDN/m/iazOx9tr/kwtRPRNytmEX4SGLs18SGOCZGIxe304uMC aRxl5V+1+3XLPnNGfcpN0QMoiQmx12FWSGrwlRQssQWF5NFQQTSh1jFJpzr/XLSDXqMIRaeh7/c daSW0skmShvGl6n8Dz1N6UC2sdFVU4CfnIpermKl94j6GBw1sxGHuH19Aa3YmawuBYDsytL2/x5 o/I4ER X-Received: by 2002:a05:6830:2115:b0:7e6:d8ea:7dd9 with SMTP id 46e09a7af769-7ec4a8da937mr1343967a34.22.1784040423323; Tue, 14 Jul 2026 07:47:03 -0700 (PDT) Received: from localhost ([74.80.182.78]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ec2229b4bdsm6082730a34.1.2026.07.14.07.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 07:47:02 -0700 (PDT) Date: Tue, 14 Jul 2026 17:46:57 +0300 From: Dan Carpenter To: Alfie Varghese Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org Subject: Re: [PATCH v3] staging: greybus: uart: return tty_alloc_driver() errors Message-ID: References: <20260714134921.817-1-alfievarghese22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260714134921.817-1-alfievarghese22@gmail.com> On Tue, Jul 14, 2026 at 07:19:21PM +0530, Alfie Varghese wrote: > gb_tty_init() maps any tty_alloc_driver() failure to -ENOMEM. > tty_alloc_driver() currently always returns -ENOMEM on failure, > so this does not change behavior in practice. However, returning > PTR_ERR(gb_tty_driver) is more correct and consistent with kernel > conventions, preserving any future error codes the function might > return. > > Signed-off-by: Alfie Varghese > --- Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter