From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "Duje Mihanović" <duje@dujemihanovic.xyz>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] iio: adc: make read-only const array config static
Date: Tue, 14 Jul 2026 20:08:10 +0300 [thread overview]
Message-ID: <alZs-uLJug_rnRnq@ashevche-desk.local> (raw)
In-Reply-To: <20260714165012.184651-1-colin.i.king@gmail.com>
On Tue, Jul 14, 2026 at 05:50:12PM +0100, Colin Ian King wrote:
> Don't populate the read-only const array config on the stack at run
> time, instead make it static.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
In all patches like this it's always a bikeshedding possible of moving static
data outside of a function. I have no strong opinion in these cases (when the
data solely used by a single function), but in general it might give different
readability experience (it's harder to notice static data in the local function
definition block). So I leave this exercise to the maintainers of the respective
pieces of the code.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-14 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 16:50 [PATCH][next] iio: adc: make read-only const array config static Colin Ian King
2026-07-14 17:08 ` Andy Shevchenko [this message]
2026-07-15 10:07 ` David Laight
2026-07-15 10:22 ` Dan Carpenter
2026-07-15 13:32 ` Andy Shevchenko
2026-07-15 13:34 ` Colin King (gmail)
2026-07-15 13:54 ` Andy Shevchenko
2026-07-20 1:44 ` Jonathan Cameron
2026-07-14 17:40 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alZs-uLJug_rnRnq@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=dlechner@baylibre.com \
--cc=duje@dujemihanovic.xyz \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox