From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 828B338910F for ; Tue, 21 Jul 2026 18:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660136; cv=none; b=Z9lRYukY61j0cZz4/9MsDXpGgMlUaGGMbpoNR1eBzbgIkcE4BD2So9vCyPY4S3VTiv6HxBzD+vgjbVbFqxMdzgUM+WhmCeM+8rs4tMp3Yapk0CeLDh+pyCnmfpjQhJtZQXJ1ums/OJZ7TypFxCPtlFv1Wx94TTRli1QFzG3N4X0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660136; c=relaxed/simple; bh=tUhC96BFnwLQmo/0DBZEar2awuINLoGSmfdQ70wpFEg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=UGnX/1VRXoo6SfnZ8GRBhi900oRF8PWXND2XUWpKmnqdCdmLpSYPWycwly1J4G3bpm+BC/OztL50fDcLWMRjh1Q6+GKt1Wnn7ukNpbgWCs1DC+V9BmXHJdDNQ7nOdrlgM0W8vE6wfNE/3CI+/M3Mar55ZHq5NmHOt9Fc2JSJogM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Zb7YAPxQ; arc=none smtp.client-ip=209.85.210.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Zb7YAPxQ" Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-848860def2cso12399578b3a.2 for ; Tue, 21 Jul 2026 11:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784660135; x=1785264935; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sh6amH3RhL1WJsitDE/xgJZ/YM0Of6GEW8psxmjx5y8=; b=Zb7YAPxQaPEaxG4TM5g63Ei7j7EIBQHbhAMX1T+9Y9r+pbriG92Rw4JBA36aFlkZM+ V3BB7Fyv4sTzx8kLb6TFP6CXhOstzy9ifoLX6XcxcxGt3LJElftQV8IhGx+6N97ukcUL tapL35AQtUcTkt7ZYAhbn6iCCYrek8fQtg5EH+D6luUQhEhtqYcjWLHvQgaxUDMNTzpv WOGucbd6NxIdQKyhoigHGB4E2AOBBdhew8lk/6jyqARtPCozMyv1owQ0TfAq/hJON126 Mi4IkZZhLpd2KaEIfVGg3T5iKmSR5uroUQNO8YMDrbhYfVpvO6ZfMAUjuGTZv0e2yFg4 /jMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784660135; x=1785264935; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sh6amH3RhL1WJsitDE/xgJZ/YM0Of6GEW8psxmjx5y8=; b=aBE/WKRWnmBXm7g9aCjp7Krl1jHc/qpBoo9eGdddSHuMITND14CoiJXOwpkfwaVWB1 JKpk2HOMp5/9uuhLM9L7/lH5yb9fCJF7Rk1lyDI8sgJsFLjw0vASWF6JRnuaJTaTUEQl Vkx8Nmep9buWD0qgIEQGLUtazzyOiQm0l1nA510QPCwKxLtvBJYjOXvcBv3KoU51ooOn 8vbrqZJKnTG9XE6sgoiRF6lnZN/TKUU+D1PizZSl/Qv7pIqP+jicAMUxCAnrwDqruePe u9UvkrEtq6AlfrG6+WPdmEo3Rktyub8IqilAjrHnAiXQs/ikALrpSF64K488R1usua7F g5XQ== X-Forwarded-Encrypted: i=1; AHgh+RprzqdzBTbNaiyTQ/fztaFMojiOq2qaWzmcKs7aVAsNx2pSHfKPPXmFu7kuP7ayM2/rIR1yVO8kQN2AlOc=@vger.kernel.org X-Gm-Message-State: AOJu0YwUqp6bMGgCXaLQTfvpZENriL8nHcMQCBUFukqFx03iG/t/RK7G aAxnTI2AnpRyXK1tgp895FkXqPqqu/UIWhP4dORFKvdUjIrBExTmjHLw5+0YSMzgTGg7BhwgBjL +pWmgQQ== X-Received: from pfgv11.prod.google.com ([2002:a05:6a00:c4cb:b0:84b:62d1:9fe3]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:430a:b0:848:7ea6:4b03 with SMTP id d2e1a72fcca58-84c295839dcmr19212884b3a.75.1784660134557; Tue, 21 Jul 2026 11:55:34 -0700 (PDT) Date: Tue, 21 Jul 2026 11:55:33 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260714231015.3337831-1-seanjc@google.com> <20260714231015.3337831-7-seanjc@google.com> Message-ID: Subject: Re: [PATCH v5 6/7] KVM: x86: Combine .gmem_prepare()+.gmem_invalidate() into .gmem_convert() From: Sean Christopherson To: Ackerley Tng Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fuad Tabba Content-Type: text/plain; charset="us-ascii" On Tue, Jul 21, 2026, Ackerley Tng wrote: > Sean Christopherson writes: > I like Option B below better, which should also resolve my issue. Roger that. The more I stare at this, the more I like Option B, too. I'll go with that. > > I'd be a-ok with providing > > separate kvm_arch_gmem_make_{private,shared}() under GMEM_CONVERT. > > > > I guess at that point I don't have a strong preference betwee having a single > > kvm_x86_ops hook versus also having kvm_x86_ops.gmem_make_{private,shared}(). > > > > I.e. Option A: > > > > #ifdef CONFIG_HAVE_KVM_ARCH_GMEM_CONVERT > > int kvm_arch_gmem_make_private(struct kvm *kvm, gfn_t gfn, kvm_pfn_t pfn, > > kvm_pfn_t nr_pages, int max_order) > > { > > return kvm_x86_call(gmem_convert)(kvm, gfn, pfn, nr_pages, max_order, true); > > } > > int kvm_arch_gmem_make_shared(kvm_pfn_t pfn, kvm_pfn_t nr_pages, int max_order, > > bool to_private) > > { > > return kvm_x86_call(gmem_convert)(NULL, -1ull, pfn, nr_pages, max_order, false); > > } > > #endif > > > > #ifdef CONFIG_HAVE_KVM_ARCH_GMEM_RECLAIM > > void kvm_arch_gmem_reclaim(kvm_pfn_t pfn, kvm_pfn_t nr_pages, int max_order) > > { > > WARN_ON_ONCE(kvm_x86_call(gmem_convert)(NULL, -1ull, pfn, nr_pages, max_order, false)); > > } > > #endif > > > > > > Or Option B: > > > > #ifdef CONFIG_HAVE_KVM_ARCH_GMEM_CONVERT > > int kvm_arch_gmem_make_private(struct kvm *kvm, gfn_t gfn, kvm_pfn_t pfn, > > kvm_pfn_t nr_pages, int max_order) > > { > > return kvm_x86_call(gmem_make_private)(kvm, gfn, pfn, nr_pages, max_order); > > } > > int kvm_arch_gmem_make_shared(kvm_pfn_t pfn, kvm_pfn_t nr_pages, int max_order, > > bool to_private) > > { > > kvm_x86_call(gmem_make_shared)(pfn, nr_pages, max_order); > > return 0; > > } > > #endif > > > > #ifdef CONFIG_HAVE_KVM_ARCH_GMEM_RECLAIM > > void kvm_arch_gmem_reclaim(kvm_pfn_t pfn, kvm_pfn_t nr_pages, int max_order) > > { > > kvm_x86_call(gmem_make_shared)(pfn, nr_pages, max_order); > > } > > #endif