From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D23E2EBB8D for ; Tue, 21 Jul 2026 20:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666388; cv=none; b=IyHwGUZGSMyoD12YvKW3LGwa/qu+dvSsdZSwE7SoBmwItXKnOrecVgVHB2KdhiDK9M56TnnA7abXTRBmsUggoTHcPQM3D0pe8gbXLqRnByZVN3Wrkd/jwJc5UV593glFNz18gEaOgCs0BmE+s3KhBggh8EDLB0At5NOBqN0Y+bU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666388; c=relaxed/simple; bh=txj5hbHurosKtmGTf2te1xwNeR2In+vgXfC5PA2C7Vw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TE/CWGdzW+JCP8wITZHSUvaeNtkzAzpgPl4YabBwpAjLs6oqouM9LnF8XvbIcuAlYPBGN7mOnIjxB7qeShjwtGD4NIHko/5k1QCxQFkkKjU2kwsaPUR1Eu7xo3q49zZJ3Gsy3zOyGpm0A17bi33sFx22HP3BeYt88LYCLNy3XLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iFJlGMTU; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iFJlGMTU" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso42438155e9.0 for ; Tue, 21 Jul 2026 13:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784666386; x=1785271186; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1eC0x+8qZxdiA6PkBx6wdsYN4w8frL4bj2W3YRL/T0g=; b=iFJlGMTUN+pS+uB3no0gSSjZCQPLUOgQiIFbBY/VHTp379heK6FChNVXv4vnVTOiDX 3DJ/UCqlV5bLj7u8E28kgD+sMXTUiiSGygF3qgdqPfUAGlSBiXQZbw4uLdMw/TNzFv6z aUaPBUqtzvwFgKrJrVbd9e6OGqWAPGEkshOebwlkh3TEKAehRcrViZ0SO/Z3riebmCsP 1mbfOcW9UZgA0CbflcI1Gca/keZYajNSlLxNHj1V2RnZDKKJntl/mo2JpiZL0BVCEm4Q HirFVLqjAfLfRmWjjM5ICtPaBK6u9I6T3xOUc/ruKD+bQ+oHBUeHe2fuzuiqSkkatZle gqPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784666386; x=1785271186; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1eC0x+8qZxdiA6PkBx6wdsYN4w8frL4bj2W3YRL/T0g=; b=l1R9fACPQh/pQDiJtYxzn81cKUlX9z7e2gk4w22SJU3Zbf52nX5osF1gD2wi39iLkH pzmEdY1yD1xD/sDZnRpnFfQXV+SWR2WK2lJ7j4SCRlPjx/v588MK2w229u0uuncaBaeD NUjArZCkY6Ooffu/2JaJBPvremH3czfftbha75/SN9EMzEFbtaVCHbQybRlaGkJnPoxK fZjK9DTygwrvZKC8VEuzVJhDAGsex8Vq7CsBjbLiHmO9zWFaLsbPXqjskNAfv/t4CsGa ZtltuHpX4+fYwSm923IcFZLFRDIdAHSulOOOXdDFV3sG6OYxt/oXX7ysGFhVytntb1oB aWbQ== X-Forwarded-Encrypted: i=1; AHgh+RpSeh9r3fDYXVzCQXKgTczwaUPWpXZUzUooPMJFeAodgAFwjf9ERIHdGXY5ke6PzQJFCp9EEp7f3REni/c=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4lmrPjei5F1wmmYGIxMPJXyeDpB01WegnPgC7PrvohHVtP0Y8 cKa85UgQga+HVpfSMPUVPfSudE7Kbs9vRNXaz6+R7D/e/9ubR2nw8OjwwhDrHQ== X-Gm-Gg: AfdE7cmf70RMIK+mOPdZVdqww12R1MEwYvH5eJkN/DBMELpIotIj+O5tj5Bbtz4+F6A fkvxSB3nRyrS2lp0n0r2q9JYP9X7gDgvhNkfAdTqKgohEBthvCZVZXetidKAMnHmEsU6SxNnb1C xn8TsPBIKF9mLlVARZmb7gMQ1bv739hNNJrYHt3e/qdD449CoZvnZyKYabxHss93tP990ZFtf9y yKKrWIC4u0wZJar97J6END/actlmR/wsFMahE+/iRZGJ65JajdIUUsZX8Kz+Zc+a5auNUH7qoRk fgaMNtK4MY42n8h6UDsVRYgZNQtO6iK2e89134hWNo92sF0Rg4os/bUH6yK5HMMIkGIiFbLrrhp OUtCpKBgVNYD739eFoX8SAb2cQBYoBg7aByf11UT5Zl4J5jeE8/RJqzS09ocE/uZMGktjabdHYT lBKrsWUZcP06lBnwFU/Qm4ycPnyIqrA7VOzxJ2dw== X-Received: by 2002:a05:600c:524a:b0:495:5a0e:6d8c with SMTP id 5b1f17b1804b1-4955a0e6fa1mr148432705e9.27.1784666385617; Tue, 21 Jul 2026 13:39:45 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956b030a64sm5090805e9.3.2026.07.21.13.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 13:39:45 -0700 (PDT) Date: Tue, 21 Jul 2026 23:39:44 +0300 From: Michail Tatas To: Doug Anderson Cc: michael@amarulasolutions.com, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] drm/panel: ilitek-ili9805: Use dsi_multi in init Message-ID: References: <20260721172715.602196-1-michail.tatas@gmail.com> <20260721172715.602196-3-michail.tatas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello Doug, > > + mipi_dsi_dcs_write_seq_multi(ctx, 0xbb, 0x14, 0x55); > > + mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_ADDRESS_MODE, 0x08); > > + mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_PIXEL_FORMAT, 0x77); > > You've already got my Reviewed-by tag, and I'm planning to merge this > patch as-is. ...but my AI happened to notice that the above line could > be: > > mipi_dsi_dcs_set_pixel_format_multi(ctx, 0x77) > > ...so I figured I'd at least mention it. ;-) > > My AI also noticed (yet another) pre-existing issue that the "name" > field of "struct ili9805_desc" isn't used in this driver... Hahaha AI's like finding stuff like that, good catch. I will include these changes in this patch and send a v4. Regards, Michail