From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEA24418A58 for ; Tue, 21 Jul 2026 21:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784670314; cv=none; b=kcoEg1i9sD8MN0tm5+g4veYGcUUYhEx94km2wCeV6zaTyFbDw8k5sH9uw9ZbWPlRx/bWNu3SgTAfBvvYh0gVQGX8WaSJx+i36eeuUbIIaS2Jg4ffZRA0M2iw1tL48g1AqIVVOUaXoh7caZIyIzGw53uXh18tpCeBgCmghq9Y0V0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784670314; c=relaxed/simple; bh=P4vEW4E97s/Whcgqzj22YJd6YtHWK8jwLYQ5yOODq4Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OVRWbToVgO+Mq7RBROSC2vEDSWMgTWzB5/3P4yol3zRpncybZ3cCkl7biyZfvI4OCo1R1/5hSXA2S+lI5Uxy473FFVo1/ynRm0QTcLiAtMw04E1iJaEq1HOYeuWZZqfwv1AC10xGZ2FWFbtoCUU3m4NKeb9okXH6nRoCv/kNHT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ysx/c8WK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=I9Bnz9bp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ysx/c8WK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="I9Bnz9bp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784670310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CzmiG2Js6lBhSRfjmB0Juw8EH5EE62nACbevKWRU0bs=; b=Ysx/c8WKUBomb6FHvx6BSVjU816oOk39pvikopbS/bS9Uq7IQswCxNRV2gznXEegCw6rJP C9HM/ucYJbRiAm9PY0/FTQb7Dy4ja/e90H89upwt8/T2O7yBwNOpszWlZdM5wR4I6ds1J3 n96JUjmdxxblVpfFDH7FmWzFPEzEDc8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-O5aXfREpM86RiokSWTTlhQ-1; Tue, 21 Jul 2026 17:45:09 -0400 X-MC-Unique: O5aXfREpM86RiokSWTTlhQ-1 X-Mimecast-MFC-AGG-ID: O5aXfREpM86RiokSWTTlhQ_1784670309 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e7ee64b25so1429774985a.0 for ; Tue, 21 Jul 2026 14:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784670309; x=1785275109; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=CzmiG2Js6lBhSRfjmB0Juw8EH5EE62nACbevKWRU0bs=; b=I9Bnz9bpOO/NU+Hl305x6+bg7nGZyhweEkH4XEsz7qqNpINXQ7ONU3wo2sP1cqdpLJ wKgIIz/a6n4EIin+cHdD8h72Ad62rwL5P4h6bZFEaHuqvk3r/dllgD3VUtSCdhsZCc5l nCKwgKE1o15Il8IKrf7oDEY/RhU+lAscD0GkfaUNXPjob449BSKXHIFDD2iIysOL/gXs l7PScho2yXkXCNQ2SqaqdBCN7YoztxohSFqwU6PMPA1DItQPHPHzvtRAmt+plW/ODXwd nW6qaDR3IF52PZB3Lf6V35q0Zk4PvBAiEbla/1wDrOLqhUIOhn+jvfPO1A8BprO202V0 DedA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784670309; x=1785275109; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CzmiG2Js6lBhSRfjmB0Juw8EH5EE62nACbevKWRU0bs=; b=M3/mEOn9anz4ReQBRXuXZ/UrlExCStKvvsfMsrmNo6ZjJmpcKIP7w7LUzTEl2O9u+a xYdevgDobCqii1or1GZv5o1Zyy+CTozozYIJ5dLRvw+SqiKc2dnPrhDcDBpoI9R3jeqv S1qUvbFp+7B+KiYVptV0KKr2BeSiY42RPaboWUas0+mjlAya3GWkaFFon1rEJn3jQOwv pkL+R5F8a6bBtx0q/jvCSCQ+Zc4jbsUTyJgcUk1mwqDasq44OqvQSela0xdFuegvViV5 KTetgMdzTTMG28GGJ7qONJo+lU2byzZi0++/Zl359f9JW2II4mV36psqk7ZD1hXkA9Xv uiRA== X-Forwarded-Encrypted: i=1; AHgh+Rp0OyoMgQE/xrKc1j3lvUfmpcNzUNZ5yUgMtFty0Y3IF8SQ5ZFOHuUJKROBCy1VpMRyo5OUA9UnjyXwxoc=@vger.kernel.org X-Gm-Message-State: AOJu0YztNd3BIM0SzgEgR3FboDkMZYvrFbu55RD8bCWR7mCVMDG4Nvl+ k+v6tVw16iMzGfpPxYhZ0iS2Ue4j9LTUhQT8eSxVS63PiLfojCL6dOTz+gGmwk7mjfLwVA4TVeB BxkGPFTtE1fUzjj1x77Qjd8pcCTAHJQIGSD7gObzqnx4S9PaNRpccYkBCeH78NpViBMn38YOBCQ == X-Gm-Gg: AfdE7ckGFm665nj99KvQXE1tLi3OnZ4XqBy5SBnMhqkdDgQQx1kvzEpn306VUABA90B GjvFK0frddo2rNNR9sdkQnTZKLLTPcnECj9Uv9a06QO8vs+JWpmjcGUYn891RH5YZdVC2XrFap6 AVUPo2oqhq0Wkw02aiZNABQG4SES/Ab53rnT3JDAnBZuqP/MUzqQGwt3pIUPQC4ucHlw/ZqsCqW ASK+3GIR76T7D53tday8S2KET/wv9Y3FGRXWuHQXDi/Qow09FHeBoZ134j2vfLfiK+ntQs9d4mr ieNYwaQSzPF5guaC2j8YRlgZ7vh8o3IUKplZvV58zuYWNrSDhm/4pTHIhUwsqA8JeY69yEU+GF6 DSVsQFZDCqX0H+Rc0trzRIPSETIgjdjhi3lA= X-Received: by 2002:a05:620a:6287:b0:92e:44be:bbd2 with SMTP id af79cd13be357-930b3e6fa07mr2011535885a.9.1784670308945; Tue, 21 Jul 2026 14:45:08 -0700 (PDT) X-Received: by 2002:a05:620a:6287:b0:92e:44be:bbd2 with SMTP id af79cd13be357-930b3e6fa07mr2011529885a.9.1784670308359; Tue, 21 Jul 2026 14:45:08 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930b52df3f9sm1222910785a.8.2026.07.21.14.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 14:45:07 -0700 (PDT) Date: Tue, 21 Jul 2026 17:45:05 -0400 From: Brian Masney To: wangjia@ultrarisc.com Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v4 0/3] clk: ultrarisc: add DP1000 clock support Message-ID: References: <20260720-ultrarisc-clock-v4-0-fe639d63bbac@ultrarisc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260720-ultrarisc-clock-v4-0-fe639d63bbac@ultrarisc.com> User-Agent: Mutt/2.4.0 (2026-06-19) Hi Jia, On Mon, Jul 20, 2026 at 08:38:03AM +0800, Jia Wang via B4 Relay wrote: > This series exports a small common clock helper and adds the devicetree > binding and clock driver for the UltraRISC DP1000 SoC. > > The clock tree is driven by a SYSPLL and provides fixed-factor clocks for > the subsystem and PCIe, divider-based root clocks for GMAC and the UART, > I2C, and SPI blocks, and per-instance gate clocks for UART0-3, I2C0-3, > and SPI0-1. > > Testing: > - dt_binding_check and dtbs_check on ultrarisc,dp1000-clk > - Kernel build for RISC-V and boot-tested on DP1000 > - Modules build test for CLK_ULTRARISC_DP1000 > > Signed-off-by: Jia Wang > --- > Changes in v4: > - Drop the initial clk_hw_get_rate() max-rate warning after setting the > divider rate range. I also see this in the diff between v3 and v4. Is this expected? +++ b/drivers/clk/ultrarisc/clk-dp1000.c @@ -0,0 +1,154 @@ @@ -309,8 +309,8 @@ + .frac_mask = GENMASK(23, 0), + .m_mask = GENMASK(23, 16), + .n_mask = GENMASK(11, 6), -+ .oddiv1_mask = GENMASK(4, 3), -+ .oddiv2_mask = GENMASK(1, 0), ++ .oddiv1_mask = GENMASK(1, 0), ++ .oddiv2_mask = GENMASK(4, 3), Brian