From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6FEC42BC48 for ; Wed, 15 Jul 2026 00:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784074260; cv=none; b=et8Y8QH/KvlpqHJN5/XGIvDLPBeiz4icuaiIdrU9LROSO/LEc6wa+zPUpL/i6icn5t76O2yojt/FSMsVU6btd3d3WXawcCGFJFN5qLYo/M0kNG52PKEVgkxSzdJxMnS175vESMqFYPAY2KPMUMKDKmcn2nxWjh+WOtoQNxVc/Oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784074260; c=relaxed/simple; bh=FMSJZadlcgd+A7MpAhd72+rcWZ4vSJmY9sFHRGA+t3A=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=qZDHpkRuxrGBErZy2I+eWlkuxNtWAnK8qJFzzfUacMSsWpj++Fqucwv7NtpVJPJCim//4uZegKVOechvjAD2Qxejed/Kvi2qkTGBV0c6zTXAEi90RieNUIAYjJnSrlsMHf6TDohE+v9Q4QC+DiiU3Y1lc5YSSuyjQWtrN3QAdks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=U4dIqrRs; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="U4dIqrRs" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2cccfa32670so68699795ad.2 for ; Tue, 14 Jul 2026 17:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784074259; x=1784679059; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=H1rv/O3i63Qn52gM6nXIO1foOK5d+gOMzfG7jT/SI1U=; b=U4dIqrRs/tFht83P9eK2yhjZb2q2NewlSJXpQ1pPeo2GTKc4M1v2NlQG6f8oFyscBg CDibz0fylQUSm0Zb/HNwC9+C9GUwqFefQnVTMG7MntRfG2kE2YlVXYciJuhp0vcndIV/ WbgBnpqYeQZnTIrtzHSWoCSgK3Xflgr+Ge0lJxh9IsBTJjvlp85G5IaDfeY7uV09M5xe /ac7kI3lCn2dIpFIvguNl8rrIg3BI5JDiZ9DzNHxNdFJz04MKW8kH9KxtX+MHCMUZGyM pffGxITmzWSxp0DZS1V7N/6LEBhUN2+K14UxzLWVomjgnFyJKtrJ1qWOpwS/qfcVX6Jd mgUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784074259; x=1784679059; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H1rv/O3i63Qn52gM6nXIO1foOK5d+gOMzfG7jT/SI1U=; b=Yy5daawGN5XeqyMHu+vIipZqQF9n3sUGsIGcc9CQdp78mV3WSPQWHF9LpMupYdlzrD nFeMvHMjOQn/+6kEj/79ykQ6UhIxYj7mBYpK88SZHchx52kIIyj3zSqQMkw26x5waq6d sLnq4G7meY+7fni7A/JnoDJo8fOm3xIdlmsS9h8CDZzqMwlMsFoZtBKBjA5K11pwm0Co 2X7QaMpB/wv0Equh4uP2uabgsEYWd+c1P06bX/6eGDfTOFW4WHRcPLGhcWsMMhTTu4Sy QEFh4sXI1h7yd2jVeHy+k2ncdtGyco15blqDp390ok3QOKgejJdi2sZmM+54pvJR0tvE n88A== X-Forwarded-Encrypted: i=1; AHgh+RoyNWmGzpirgYvdiBDzzqFmesDZtWaHTY0UzNMDZrgk3VzVA5zw1e/1ko+W73JwUxKgqE30x8b1uH3wvGk=@vger.kernel.org X-Gm-Message-State: AOJu0YzjuaodX9o7uA0NkJMWHJE56YJf7Y1yWHm02oSS8RJHLeghGetV ezZFG+pUNsf+TSdpYFPVq46DMMKejgXyLTxauo/QCUbjJ4qv/JihFKgsi57S5okwJIjJpO4Swry uKMqrQQ== X-Received: from plqt9.prod.google.com ([2002:a17:902:a5c9:b0:2cc:b904:3254]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f54f:b0:2cc:670d:9b2f with SMTP id d9443c01a7336-2cf03d9c767mr4896855ad.33.1784074258756; Tue, 14 Jul 2026 17:10:58 -0700 (PDT) Date: Tue, 14 Jul 2026 17:10:58 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260714231015.3337831-1-seanjc@google.com> <20260714231015.3337831-7-seanjc@google.com> Message-ID: Subject: Re: [PATCH v5 6/7] KVM: x86: Combine .gmem_prepare()+.gmem_invalidate() into .gmem_convert() From: Sean Christopherson To: Ackerley Tng Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fuad Tabba Content-Type: text/plain; charset="us-ascii" On Tue, Jul 14, 2026, Ackerley Tng wrote: > Sean Christopherson writes: > > #ifdef CONFIG_HAVE_KVM_ARCH_GMEM_RECLAIM > > void kvm_arch_gmem_reclaim(kvm_pfn_t pfn, kvm_pfn_t nr_pages, int max_order) > > { > > - kvm_x86_call(gmem_invalidate)(pfn, pfn + nr_pages); > > + WARN_ON_ONCE(kvm_x86_call(gmem_convert)(NULL, -1ull, pfn, nr_pages, max_order, false)); > > This setup means later pKVM would have to define a .gmem_convert but > actually only use it for reclaim, which seems kind of an odd > definition. (We can fix this later.) No, pKVM (on arm64) would just implement kvm_arch_gmem_reclaim(), and then do whatever it wants under the hood.