From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112442989B0 for ; Wed, 15 Jul 2026 13:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784122618; cv=none; b=NE1Hzlvma8qdVhBgm4iwfA3SkZQdjqRXt7KFHZiqKAbjs5d65NJ/lt2kj2O37Fx50rv7g+kW3AcX94SzBgXZdToIvS9sNZp/M/v+IAMKHAuuBEHQq5BrGt5R51HcT443slnR8pXOCyi1LLLl+623Nt/RGqcT9NBdy0LJ1PAI7Qs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784122618; c=relaxed/simple; bh=T6CfKOXvUyUPtvwkyHoYtl7z3ckfaZRkGXR9BMC3Yfs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fabjp38zTC0z5bhMTjCR2qFWHrko47ItmjI7zGsCz8ULSrZ21HRbFYKYrYsrvJ+Y+6gqf0uc6D5X9frFTpIZd1Cf77wHbe9UOuzLWmUuMFV7yro3aTRnb7hf2so4obKfP0w9BHiubr3EwSw2ktxJaUFEn6Vba44+cPBlKL4SWD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PgapvMKZ; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PgapvMKZ" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so1936516f8f.1 for ; Wed, 15 Jul 2026 06:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784122615; x=1784727415; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=dzANICZPcrQ4mfbgZVA3ED3GO6T9Lf7g8EslsvNWAkc=; b=PgapvMKZSDxWzhfv95zfL1TuP2FTzFyWXxZyPZ2woCL95lwXoNtfWGvSaQV7gWG7q3 QLgMDNlPlLKl5LG9LP3CIa+XOZQYPEnFbC6BRfGwKPNK5dhRR6oa1y+6qPTl0r+Umh9s 0VrV8vtFf5+91IVW3Ytke6RKLG5Rj83DoS9hkzz7Fm0uwehKn+S3vpO9v4bjmMq048go EyO8gxP5WYD5X0TwFJdcxrIAXO++1h2c/jO3+khiGjRYee8+hKX6cL29xgZbb8fYNbyB Ctk4XriFloJX55QycjSmWq2JZMhrk5RmA8fgdprLk3RYE7Ro6cPPu7h9/Rb6QiZrUrVf 2Jkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784122615; x=1784727415; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dzANICZPcrQ4mfbgZVA3ED3GO6T9Lf7g8EslsvNWAkc=; b=Kzlq9n8qMozOJiooNIKIafOHY4auWXYpVeM+BpNugQbApJcf5/a5Ou2CrSIse+eAS8 +4eKoqNKwv+IrXL5ZcN2Kb6Q8jc2tDLo3mSQIjiPYgAvSP1VLmL9XcGhy2Kf7Rtqwl85 DI1YNdKikh2YS/Lmt70DMCgOJ+dYQ54sgjb87p8WtU7YQftjrT+3Zq5g2DSSwm/wVqBF SPQVHOgylRaCiWgqqhaW5x810s48YxpWTIKXTp11Y4s5pL6VvGgI8vz4k6+cfTEHORD5 23xDdIYVmEGQl+OWAmlg4i+WV2j35vpSoOW+e3OUZ+h9ugGxfq0mW5rO67J45/M5hTeh YUlg== X-Forwarded-Encrypted: i=1; AHgh+Rq51BoVUopxfQdKKmpWOxZmWxMPxEflstpNQahnn4QooHvzA8CvP8fWqo2iRUFbSeAigf+H3RnuNut0YGA=@vger.kernel.org X-Gm-Message-State: AOJu0YyAN8/BK4Tx3ohKJkHybjePv9RfgT/Kpw2AAMbWHAjNxNDyaXEl ETvHqHjKtJXkOmmj0NS0clGbqN0xHxqj7JOyiIxSt4Qyl8MuLF2E4huz X-Gm-Gg: AfdE7cnq9uQgrdIpbj9hkoEao1l6qGU0DhMXgPCzGOleCZPVnb7adQIUwgfjbLGTGzj slmkGUQrikAgVPFChjifrZjDzKW4jEpnH0pPVOmNvCg5tUJIwzsObDCcQAu+x09Eg3W+GuFALYv 9Wk4XBWErAa6EzMt8AzTLe5bBZGR+FC4S6EJw/2MqfDHDfjsSgM70p3urQAGKXm+SnMFpM+sFSK oKGgEHyii89gC2KSo2tuLgCd2mHYo4Xarkc3pn/kQCL5EJuGn5ix9sK/9wxRtmnGUP1U5ymIT1r 3KUdJ4ca1xM3YkXkS0C69JLqCRJsZyBlqmlnqDP10lJQTo7gGy04Xz5EVjLWDpa03dXcB3D7Owo OETLO+l5ppCirIZ1DWFo+ON3x6OIW6B1IG7lrKVh/ZsnfLNjjOWZ/cokmRx27sXm6EwnPIQKdCB xp2rrNbC3X X-Received: by 2002:a5d:5846:0:b0:475:94e1:29d5 with SMTP id ffacd0b85a97d-47f2dce942amr20020545f8f.20.1784122615112; Wed, 15 Jul 2026 06:36:55 -0700 (PDT) Received: from owl5 ([2001:861:3201:3d10:e682:163f:4878:db7e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f462e0cb2sm16802692f8f.0.2026.07.15.06.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 06:36:54 -0700 (PDT) Date: Wed, 15 Jul 2026 15:36:53 +0200 From: Gary Bisson To: AngeloGioacchino Del Regno Cc: Esben Haabendal , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Adam Thiede , Thorsten Leemhuis Subject: Re: [PATCH] drm/mediatek: mtk_dsi: enable hs clock during pre-enable Message-ID: References: <20260120-mtkdsi-v1-1-b0f4094f3ac3@gmail.com> <8733xko1ms.fsf@geanix.com> <0f719c00-3cf5-4403-afbf-713b07255981@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f719c00-3cf5-4403-afbf-713b07255981@collabora.com> Hi, On Wed, Jul 15, 2026 at 03:25:11PM +0200, AngeloGioacchino Del Regno wrote: > On 7/15/26 14:53, Esben Haabendal wrote: > > Gary Bisson writes: > > > > > Some bridges, such as the TI SN65DSI83, require the HS clock to be > > > running in order to lock its PLL during its own pre-enable function. > > > > > > Without this change, the bridge gives the following error: > > > sn65dsi83 14-002c: failed to lock PLL, ret=-110 > > > sn65dsi83 14-002c: Unexpected link status 0x01 > > > sn65dsi83 14-002c: reset the pipe > > > > > > Move the necessary functions from enable to pre-enable. > > > > > > Signed-off-by: Gary Bisson > > > > Hi > > > > I have run into the same problem, but in combination with another > > pipeline. I am seeing same problem with an i.MX8 using the nwl-dsi > > bridge and the dcss driver. > > > > I have submitted a fix that adresses the problem in the ti-sn65dsi83 > > driver instead. With a bit of luck, it can replace the fix proposed in > > this thread. > > > > See https://lore.kernel.org/all/20260711-ti-sn65dsi83-fixes-v1-2-d85eb5342b98@geanix.com/ Thanks, just tried it on 7.2-rc3 with my patch reverted and confirm that it works too. My assumption was that the SN65DSI83 was locking the PLL earlier for some specific reason and therefore was reluctant to change it. > > /Esben > > That clarifies a lot of things. > > The patch on mtk_dsi shall be reverted then. Angelo, do you want me to offer the revert patch? Should I wait to see how the other thread goes? Regards, Gary