From: Gary Bisson <bisson.gary@gmail.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Esben Haabendal <esben@geanix.com>,
frieder.schrempf@kontron.de
Subject: Re: [PATCH 2/2] drm/bridge: ti-sn65dsi83: Fix problem with premature PLL locking
Date: Wed, 15 Jul 2026 15:52:22 +0200 [thread overview]
Message-ID: <aleQlpx73a5R8QgR@owl5> (raw)
In-Reply-To: <178410553814.253594.6153852459811911516.b4-review@b4>
Hi Esben and Luca,
On Wed, Jul 15, 2026 at 10:52:18AM +0200, Luca Ceresoli wrote:
> On Sat, 11 Jul 2026 13:51:15 +0200, Esben Haabendal <esben@geanix.com> wrote:
>
> Hi Esben,
>
> +Cc Gary
>
> > [...]
> >
> > This is the same issue as addressed in the patch by Gary Bisson [1],
> > but changing the ti-sn65dsi83 driver instead, so we don't have to change
> > all other drivers that could potentially be used with this chip.
> >
> > [1] https://lore.kernel.org/all/20260120-mtkdsi-v1-1-b0f4094f3ac3@gmail.com/
>
> AFAICU your patch would replace Gary's one. Also Gary's patch has been
> reported to introduce regressions but it hasn't been reverted yet. Can you
> reply to that thread mentioning your patch, so everybody in the discussion
> is aware of your alternative proposal?
Thanks for including me. I just tested this change and reverted my other
one (mtk_dsi) and confirm that it works on my Tungsten510 + SN65DSI83 +
tm070jdhg30 panel.
Tested-by: Gary Bisson <bisson.gary@gmail.com>
Note that the sn65dsi83 driver wasn't changed as I thought the PLL lock
in pre-enable was on purpose. It was introduced by Frieder with this
commit. Adding him to the thread to weigh in.
dd9e329af723 drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec
Regards,
Gary
next prev parent reply other threads:[~2026-07-15 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 11:51 [PATCH 0/2] drm/bridge: ti-sn65dsi83: Various fixes Esben Haabendal
2026-07-11 11:51 ` [PATCH 1/2] drm/bridge: ti-sn65dsi83: Support LVDS Channel B on SN65DSI84 Esben Haabendal
2026-07-15 8:52 ` Luca Ceresoli
2026-07-11 11:51 ` [PATCH 2/2] drm/bridge: ti-sn65dsi83: Fix problem with premature PLL locking Esben Haabendal
2026-07-15 8:52 ` Luca Ceresoli
2026-07-15 13:52 ` Gary Bisson [this message]
2026-07-15 14:14 ` Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aleQlpx73a5R8QgR@owl5 \
--to=bisson.gary@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=esben@geanix.com \
--cc=frieder.schrempf@kontron.de \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox