From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3F463C8C5E for ; Wed, 15 Jul 2026 20:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784149107; cv=none; b=sKJiN935HQNsot9sbTVdP6Hi3nT2UxXQ3rM/iXlZW+sGZ59vgjN0IGjATUUNvT1sbs1v3RYKj58kVd1zdZ44nwCHoyCb/bMMezkB2McxKgAq41SoDILyKbtL4LNVwKN524GySGh/avHiimBZ1xWZz8UrXxYPnhrfbDeKA86IBv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784149107; c=relaxed/simple; bh=aKwNcVwe8k6l1xte5Jc29BllQmYsaGkbBJF3XYL1a00=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qQ1DUoxNwjayltbzu2c8R44S/K0SXtCSBrW1lg35gx8BjzyW8Dwo8EBueHnohGfIfhy6iykOuhFCklKo3WXRBzfle6tOPplB5u6ZPEkB7CC/utTAK2EEp7J4BHaHWy5R8IGbg4TFA+Qjz0IoTI3qDtFddMn26K8kfQDzt+2lbRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DU+7i/6y; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DU+7i/6y" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cc891373e0so71045405ad.2 for ; Wed, 15 Jul 2026 13:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784149105; x=1784753905; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=xuPUQonPFmI0rFkgA1ueaWLbPCDRn98daoQtVv6yMEY=; b=DU+7i/6yZ4spxBLeIW9UM0D3HfnIhN9+g8EnxAM0SA+14aBImAxNB+CnS+Lg4biJj9 9w3/dgOka/V32yWj9Q6M5H2/fVWr/F234wmzgGRZo2Yxi3rguWEfZK0CV20FqOExrW9E LTf3A9o8bJrPhEzAkAfQVibdI0EvPATTqPme8gaD151yE/PbZk3SoCDRUBP0FJ78vSbi oI1PbQOMkaVq+3q9HTn9GxiYDihYpRlbDdOCarBzBSsssh9x3/To0TmLf+79+8/HS5MI 7yfea2BQ3psh1FyzpV/t66dGlis7R1c706+1BOocLpKxo0lwuR/oetXXTsPV3Kbc3Xyp 6AxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784149105; x=1784753905; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xuPUQonPFmI0rFkgA1ueaWLbPCDRn98daoQtVv6yMEY=; b=qtzDOt9Z5I1UscrVbKivA8KyxbEJLxfM3XVrIHU0IHDQkzdXJHSmHwL3fW03LlzqGT SE7qM9HDEay4W97UjOpTPjy3h3MiZ48LpgTw2w12e2He+yA7KtxaJVAtcHecfdy/PY9O pehgE5fuF/IGfIRMW9/O6pFoXc20pMXnWQfuKlNdXzXNoO3JX5IXbZ7pG/GzO/2hQCoX Ob7oAikVHLuSOpdD6v2sviVuecaGnhqy7ARVozaJslSq/AIUR4KN1HBta98vc158ckRa xYa1Bu7CNoFlrEgWopyr0BAg7q+vRJPPj4rPCp2G/kQDoON1ZxyqLhwg8rFX07HR5qUs YHxA== X-Forwarded-Encrypted: i=1; AHgh+RpqdNXm0opZRf+oe9pX3N2t3uO4HqJ4ZtjTl9u45Be7tgSU5+O6auf4bihUXiSONDFsDLrXAiUCXXiuCyI=@vger.kernel.org X-Gm-Message-State: AOJu0YwIKU4HviM/oV7jdNR0cbj8PrHY9AiDDRSVc3jinjB+/XiajdXE Rllje0+R+9AeFTbvdH6/jlfUVWtMLkoAlTn2F3IwU0Fcz6gOunyLI0mJ X-Gm-Gg: AfdE7clDLNNC9U+ZvnxiDwqV4SWk21UdVKVpYH9ZiYPkqkHpVKEflBeYWCj+P2RIseZ i3cGCSq0ZftS9QaKH7aeIY6xNOTPSXJSpam/K1FTmni/ehM0Pc+Ap/zU5OaBgkM8vruKomUKtpb LzRV3WhVB4vQf7DqrD18PPdB1B57RRLxDv1CjLw3pryzu+jdMbqcsO7h17/FNqzbuAp3aQOBx0R +uj0lJh0uOLAMUA4SdgVyitr6sLnrowM/GpsnX2b81y9iUutVDk5GpgNnO2w8+Z2sbSccb3Rg9K Yj5Aofw8Sjgbu21enR0qfqmdBk7lflFrLxcNMAaCQomgoEAfvQBLEy8D8tRonGb82TQkI19QpGv qyo9xWBLa/X0fkuDvMy2omryHrS78dSc6UqZOLFtPtVzJB1/N6c00UifUIRyaDdEE4KrF2P7ZBt g/ZIqUmAs0ZxHWgAXY1/lXe66gXC3vBjIIs0PF7zBrydeZxGYC55VA5fqDCkvqqcs= X-Received: by 2002:a05:6a21:a98:b0:3c0:9c19:65a1 with SMTP id adf61e73a8af0-3c36c4571fdmr4362931637.73.1784149105146; Wed, 15 Jul 2026 13:58:25 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:575a:5ca:2b13:aa89]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3140e538368sm7007333eec.12.2026.07.15.13.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 13:58:23 -0700 (PDT) Date: Wed, 15 Jul 2026 13:58:20 -0700 From: Dmitry Torokhov To: Zhian Liang Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Input: tca8418_keypad - enable overflow mode per datasheet (SCPS215G) Message-ID: References: <20260529013900.43854-1-liangzhan5dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260529013900.43854-1-liangzhan5dev@gmail.com> On Fri, May 29, 2026 at 09:39:00AM +0800, Zhian Liang wrote: > The driver currently sets only the overflow interrupt enable bit > (OVR_FLOW_IEN) in the configuration register, leaving the overflow > mode bit (OVR_FLOW_M) at its default value of 0. > > According to the TCA8418 datasheet (SCPS215G, Section 8.6.4.1 > "Overflow Errata - Description"), both OVR_FLOW_M (Bit_5) and > OVR_FLOW_IEN (Bit_3) must be set high for the overflow interrupt > to be generated. If only OVR_FLOW_IEN is set, FIFO overflow events > are silently lost without notifying the host. > > Fix this by setting OVR_FLOW_M alongside OVR_FLOW_IEN in the > configuration register. > > Note: I do not have access to hardware to test this change. > Testing by generating 11+ key events without reading the FIFO > would be appreciated. Full handling of overflow events in the > interrupt handler is left for future improvement. > > Signed-off-by: Zhian Liang Applied, thank you. -- Dmitry