From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3219D3B47FC for ; Wed, 15 Jul 2026 22:22:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784154150; cv=none; b=RxH1Vgq/xNiizTLDoUfeqv6NWoPevaC7Y/Rax7EkSJnJcNOtb2T+YKxFUCGGXBXyyEYfMKXh2lUu7R+HszpLaHxkVjE7c2+xNVoHaMTbfPSH6ycENt+lXpvtyrz3Z+jX6Fvh5Oa7PoeqBZvmiGTNV9R/Vcg8QXVlaZb5LFNiwO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784154150; c=relaxed/simple; bh=eGItwZhXhjcCNzydKc7M4IOfg6/7bc3EJbzam0oesV0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AKaoeA/cMZ/QcaBRK+0Fhe/IDZdmcN02EnqcEb52y+idEj1X7BmBDFKH9dizhGmBpl9niADbAWIJPF3sDJCTYe4L339wEo+QaLJ1oovs/OMwgDKmJ7GPJXwrTWZ/PiJgNR9KnUm2w93pGI7l6B87i5vfQ1R6OH3DLkY9u6XNCjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=eqTEQ29N; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="eqTEQ29N" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493f75f7172so42473595e9.1 for ; Wed, 15 Jul 2026 15:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784154147; x=1784758947; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=eGItwZhXhjcCNzydKc7M4IOfg6/7bc3EJbzam0oesV0=; b=eqTEQ29N1NF52BAPZ+DLQLG5hsZXPjuOb0wfMKF+jdxQ6VNb3Unu/Q6mTNoxui9M06 M2urGLHhoJbVZ5fbkUMJtHEeYZqhBYcbNpigtyq7S6IcgmK1XICl9JnQVOOENvsasVaQ jrmoaYtASVJsaw25WKzG96LmzoFedYYTovj+4A+QWW7hqT7ZgU/sgKrdDxk1JrvvcJxa zCIAXuUIt9IYgCguLXXJJYV9/uqNdTTfCjdKdaXf1kFjINftyiMaTsTb/hxyHMf8OSsw UBA3EKnpr5Y0rCFuLL38xBN2C8odMWzxs54kpMEzXAi0rgoeOYI0j5cGvu3nrjbY/fu9 vD+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784154147; x=1784758947; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eGItwZhXhjcCNzydKc7M4IOfg6/7bc3EJbzam0oesV0=; b=FOS7kr4TdtImF62uIOYapDhVkEc1Y/y5osyx7t1a3/Qv4+UmJJi8K8ncOvj6Ufc3Fg 9FXLOmW8cVtAyGYMrp6LUeoe8x7N3zPBlEC+5oTX5KY2zERjJIZ6loRjbrqAwf9gVtB+ HK/uKlom32bNSUy8Lsfgkpastl8MtFboDWPfjEdkB2XIWmCdTkikEZ8pWcMkA6VpDZNs rXjhsRxwUKmmzWmw+mBNlXMihgrsuerjX1ARc88kiWjScpl+0309VGgJhofCNg61cbg7 agwCA47Uvq5SoOgbkJeHKH/D9MdZKddGvhHrQ+FrGPQosTPzQK4TVbSzdXo63DdyoaKm EKCw== X-Forwarded-Encrypted: i=1; AHgh+RoMVbd+uQNc4qGKXtVe1/tI6Gswu2uNcvPC9s8PFxv7RfZ9Y3WZLRgRTT0cSuXQAKhFqFt1B3U9qhaPD8s=@vger.kernel.org X-Gm-Message-State: AOJu0YwKlHpRtFgyc9CRyVw7XQrV4vpW+DrFt5AqibSuoGum5GFUPhur ZZg3w6A33NbAeac8dYvDBRdomW4VpCRHLc+PVr+YY2fQurUHQ3wFnXfCQeU9IBJ8iKo= X-Gm-Gg: AfdE7cm0UNxL6Uvoom61Ok6s5xwpOEwtIf9834wMu0d8aqN4uME8dP+jxikYcqFRqjt ULuH8wIuZl7X6ewj2qzg3W5gHUq2omS46HHu5ISdXrm2GlDU7ooaPW/+QKZAE/NJu2L7433oe0U rjBwHAJUVgG8HIgFUcs/R9iOyRlQgxREPzHE1k2lPoRXztA+aLh2Zhi5vnVtL0xV+7fmvcx6nAJ FSGbPpP3BxW91Cda7YnDO+WZz3BfVwmWvRdDq04fGm6hFhTwPlPW17pe/2Nv3zSFUFBbp3+rzPi ij3J4uVKWzyLGew/8lncT/Qf0riXsrxUfNYAnf2cKxqzgMMIfqs9vbcDiuTFltR8tCc2DmsoLBd uwig/hp5mTaRg45AYREigxRc/HJ14ylE8oYseI1kpv5qbUszhTy/qR4/Xwwumvnrp5T+Zmy4XVd Yy+z8m2G0= X-Received: by 2002:a05:600c:58d6:b0:493:f262:b8 with SMTP id 5b1f17b1804b1-4953c147474mr41635105e9.1.1784154146840; Wed, 15 Jul 2026 15:22:26 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4953c59b810sm88924315e9.0.2026.07.15.15.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 15:22:26 -0700 (PDT) Date: Thu, 16 Jul 2026 00:22:24 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , Mark Brown , Marius Cristea , Marcus Folkesson , Kent Gustavsson , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Janani Sunil , linux-spi@vger.kernel.org, Kent Gustavsson Subject: Re: [PATCH v6 5/5] iio: dac: Add AD5529R DAC driver support Message-ID: References: <20260715-ad5529r-driver-v6-0-cfdf8b9f5ee3@analog.com> <20260715-ad5529r-driver-v6-5-cfdf8b9f5ee3@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z552sxv3apml2j3g" Content-Disposition: inline In-Reply-To: <20260715-ad5529r-driver-v6-5-cfdf8b9f5ee3@analog.com> --z552sxv3apml2j3g Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v6 5/5] iio: dac: Add AD5529R DAC driver support MIME-Version: 1.0 Hello, On Wed, Jul 15, 2026 at 01:41:08PM +0200, Janani Sunil wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Please don't add new usages of , both of_device_id and spi_device_id are provided by , so the #include for can just be dropped. Best regards Uwe --z552sxv3apml2j3g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpYCB4ACgkQj4D7WH0S /k61Bwf/XWRg8XAN3lHoIJhsnA8+g3296Hm+E93+U777lyf9jyFKLx7iYqDKHWA9 kU2LMnREIemDelxgrlmVQ04lxzLBNI4KzBLvD3fyJHVaq/vL+TMQSTyfV1kb+g4t w0HZrHT+ETT7mkD8rUtLLXsOyg2cBqauEU+s4Zte8QWbZliDqQ+dVrn+/yugVccG F8Cv0+sAEkOhY+7Rp6BJTfsMJWgw8FnCDBWL7tB7OPsiUc0WIrKMq4x6Hpo/x1Jt FH3wCIlAxKaE3x1GqiGec5q3WKFej3wvlwRiBZf+yKkobCQkFE8Wc79+SWFm6kDg R06LdtSuCgAuTVHAXqMvde5Pysc4zw== =f3f3 -----END PGP SIGNATURE----- --z552sxv3apml2j3g--