From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75F932EC0A4 for ; Thu, 16 Jul 2026 06:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784183257; cv=none; b=m4bPc85X5AmaSqrjKCRwDGTA3WiPdwi/c2ips1DviffhtoiC4+NlJwwmpMvQ1zfe0F8vLa5lxL7wNmMQLn9SIIjkwUcriJZ1Z2o6YLbalRncyw6T0AbNyf2itYxdyyTttmkwAerlVjDt3CSHUkOMFem1XFIF051Ewqk8alpm54U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784183257; c=relaxed/simple; bh=NRmZN6kBrUZzlGpzarB9t5FQkrrI+SYFTT7heTbf5dc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jLIUhEui9sAD5c27ncOQP++UNb3nDnjRXJReBUkI6hTn9S3/U3VtInBAi/LC9S/o8ckA2roDfhDTmCj6PTAUXpe38PFJbEiMcTrPG0ChcnYZO5VwJuAXe6rcA0QJ8wPTDzlpV1E33/gfCapyfdzjCprn2iYsXZILSqunPo7tDNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D2mVZ8J3; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D2mVZ8J3" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7eb61bbeb25so1665634a34.1 for ; Wed, 15 Jul 2026 23:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784183252; x=1784788052; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=efE77uhj9nQCyKWP12csM1pAoAvN9Mzss6mQMwg8AtY=; b=D2mVZ8J3KnuQwVnUNjKlV5DkACX7enxbYP7iwPS4hfgSQA7MR9n3cEeiUdX3xvvSmP AqayJm3uAwWwg1s36IfaVaZrm6JiIa7OLZulc7GrVSZHy4A6G5jnebfiRY4usSTvyWnx KOYIvsHO9jjo4acWOF9EOV6CKdW7qZ+x/eYcirv2cCe6CRqH64cubWCjD613+BiTUx8u t6EJv7Dv935sp9mbXd6+TqKwtlBrZVcyfP5MxlAecep2KpOH3HxffGArDCVQFtDsI7+2 R85MHk8Fn/obMCcDncG+A7+qTFYj3r9npb4b+FFdAlPAoasHz4OFiJ41og6pCXCXlTab e/mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784183252; x=1784788052; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=efE77uhj9nQCyKWP12csM1pAoAvN9Mzss6mQMwg8AtY=; b=svjWZmu0DL8Hns5FZ/lpiIypTvbP7x/eo2QajZkdt+6v+9VdjkqONscs3D88N/0iZW kq08QVcdGW3DPXWBZM54bAkpv6sJ6KJVmUwvsV3svsQuflMRn3I6qY7P2nvXViUKxEGK njCv1QZyJ5FTwQMhqIAYMY5mU80LQh2USS7OaXz6pTPv6RdK37ii1MLxmPLuJHq2NMwR BY0Y/+kILRrDDBL1bf9NmQQXqgIikC7gqzOXSTQLmt3k8Pe3uzQAXkaki2nitvlbe5BI vIDijRoC+09jgdZePcdr94iQnopg1HvQj12hfRBS4pwsAy1Bj0TXRHDOvoKGCHv6vbzg G7ng== X-Forwarded-Encrypted: i=1; AHgh+Rp9o2BAw/pyqGKl0k9wTPeqqm4kmVlkzAwcZzayvCCkYPtbZGX3T0cEemXFHB77SEabAeopJ2F+72mESYE=@vger.kernel.org X-Gm-Message-State: AOJu0YwxAECNVGRRAKi4J5iO0mSesKBRvXgQMsDVVuYy78g40xvXGrzl lCIQ4F4nXNz9loA1UGD/5QC7dhTb2PBDcqZ7/IWhLghWPBOadCVaW2Am X-Gm-Gg: AfdE7cmKcgetAlSQxhb46HHcjYEOzM+JiwTubW0jU9ZuAVVT0N6wbzcfkq9IThELNnw 8vZKbI7fN5RkMjVptQpYLJp3n8C2cCyhTTm5wwdcfJ7QOV4dv4A/JCiNxrRaxeuV8mnH+dCC17K HxkYN7O318qrN1T+F1Z7ol37Bwyct3QUwFuD9ytZB9ChjIntSmZtT+y4Nbm7ruNAmEun/yl3GEs GBVSe6x++ELYv0ZVNENvalMsHpKRupEMOahjUb8v4fGayOHmEIN59W1n8sNEMXUSqtja4K3V3qA 2Sxo8i/thwW/9L/F5Ni7pHkeD4EFwr6Jlq4LFVk14IsLPxT4tjFZsE/Q/0XqeBHB8clfHw1YZPK YPaGSjG3uWGk78NCH9OL2rCv1i3903IMdECiD8RjwCfacLD9wYE7taRNbfstXUGSN8CgJCw== X-Received: by 2002:a05:6830:83af:b0:7dc:e37b:b5d3 with SMTP id 46e09a7af769-7ec096001bemr14090360a34.7.1784183252499; Wed, 15 Jul 2026 23:27:32 -0700 (PDT) Received: from localhost ([74.80.182.90]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ec31ee6e1fsm7525573a34.4.2026.07.15.23.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 23:27:30 -0700 (PDT) Date: Thu, 16 Jul 2026 09:27:23 +0300 From: Dan Carpenter To: Francesco Dolcini Cc: Georgi Valkov , briannorris@chromium.org, kees@kernel.org, johannes.berg@intel.com, bhelgaas@google.com, s.kerkmann@pengutronix.de, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] wifi: mwifiex: replace one-element arrays with flexible array members Message-ID: References: <202607150932.F2A0836@keescook> <20260716001728.57799-1-gvalkov@gmail.com> <20260716061638.GB9973@francesco-nb> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260716061638.GB9973@francesco-nb> On Thu, Jul 16, 2026 at 08:16:38AM +0200, Francesco Dolcini wrote: > On Thu, Jul 16, 2026 at 03:17:28AM +0300, Georgi Valkov wrote: > > Replace deprecated one-element arrays with flexible array members. > > CONFIG_FORTIFY_SOURCE reports the following warning when > > one-element arrays are used as variable-length buffers: > > > > sta_cmd.c:1033 mwifiex_sta_prepare_cmd > > memcpy: detected field-spanning write (size 84) of single field > > "domain->triplet" at .../marvell/mwifiex/sta_cmd.c:1033 (size 3) > > > > Convert affected structs to use flexible array members. > > - Preserve existing wire layouts. > > - Use DECLARE_FLEX_ARRAY() for structs inside affected unions. > > > > Tested-on: WRT3200ACM, OpenWrt > > Signed-off-by: Georgi Valkov > > Cc: stable@vger.kernel.org # 6.12+ > Reviewed-by: Francesco Dolcini Are we CCing stable for this sort of thing? How many FORTIFY_SOURCE warnings are still remaining? regards, dan carpenter