From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D646332601 for ; Thu, 16 Jul 2026 06:50:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784184651; cv=none; b=UfQ3CaANX3qfZYx3/AC3XtXOrAKCMe/nDAJrUG51eBjcZoVVSk3x/4bnmER3aU32vImMqwmgO7dkbYh2pwBuuPoOVz3VWqbVJDh53bE8obFyJ0jPTGUlDyhwvqmln9oQKMsPaqohSdDpX55x+Yj8AcH+U10ofUAtf9wYwQ9bI+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784184651; c=relaxed/simple; bh=S2+UmLd7+56Nwrcn/l9s7QdHIUB8AVPzkvjJSkeBQL0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FUZvpOZhzsSYU1KXvWab434GP7JbJ5f1z8xxPdaxYRRLN/HdK+mYbYfBWCYu8R8ibl3C+QSbA/vPD93D8YeghGwob8RC92V9IMsDPsfy3avW1erNYR4x7f7osNQVDpfgOtbxWgqi940dU6pKm22oFQsavEQ1LLOzRjqVO8lLzGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HlrSHuUd; arc=none smtp.client-ip=209.85.160.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HlrSHuUd" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-44cd237446cso1917060fac.1 for ; Wed, 15 Jul 2026 23:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784184649; x=1784789449; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Bb6iTH6F8sM/oel0QgeTYdzLN8Vx0owcy51AZQ0/ieE=; b=HlrSHuUdW299oQVquiQhklpEixp7bQrBVzPJ+n4kxV/jZDa7VmRPDQTbEedqHUwdd5 vJ+RRY5eAgUWFqyXvPNzrSzXEbfZDxFazJQLQbTKKwPYdi+tccSA2Xorel/uUUfPciFR xjTLTUx042yoIamyPcZmwx0tp0fcTVMhPp5wjEscOpewMO9lCYvTnAC3OGJrVLchCIY0 S3DC6Qc7PDeyRWjIqxTCBqtfTGvzO+7vSws/E3SGi4E6esmPsK7N2JGw9eEbsSvChEe2 N/pABvi8Iq9SttYI5wpxKwhxrkAhMRRzVVveAooky+wthbGsI7qvKlynsRKfokJmQBeA o8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784184649; x=1784789449; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Bb6iTH6F8sM/oel0QgeTYdzLN8Vx0owcy51AZQ0/ieE=; b=DPtbPhqf1Ohng6PMOpHLzp0MNl5kaz3Kho20XFwO2TolBR2BH8ieVR6LP8LoNCcgxT nU5pQC24NSp52DiG5TLku7Dgtcpm+7Vl8Lh6PxJFpO0AdU/XDeA1OYfIGQkBBQ1JAF2D Jp32WGXY58JLuNB0w/qpTBQkNIi1SPTJ59rcsdEFYLzh9wkpKQqouJQfviVer8lSMsWl xJ1+26ftUfo4E0Ht4wNLcG5upeeDanPz3ponzrmBV/HRRX7kp7XDDZqhSXpsGIsIt9/A 0XXLMW5j0K50CZ8rrOwTw/t2qnBisooQgiLimqxY4hSAURKHQPiHka1UFa2UL9j/WJ/R rCiw== X-Forwarded-Encrypted: i=1; AHgh+RqMZgdu/oCAX6Q2yoeLR/wRXho0DUIGD1DbgUjK/LPXENN3468vDYXoaGry1E7KhbGm+ImEWc5PEpBLqRQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzLhmeqjzXYBZHFqMtK6qW3Ym8IfTUmkWqXVXVRDIr718y5Elei q0emupldZFa2YJOCWjGKFguM4feQYVYtooTTaMxKra9keEzwpGgbaSDCjDVyWmT3AuY= X-Gm-Gg: AfdE7cl2aK/e92Skv6vdy96w8iBeaajMxIr9fLOxVX404ghFpSm7WttVWIgkjNpazyW uSMj8quWqnjufb1AIYI3XeVTmPkmhJzy3idH1bgzPcRaQahIQSmJUH78d3LMo0IcxLVKZJmLS/w Oo6S4vDcgxJwC39kWJ0Tga2r1gSvMEjtDVp6wKoW7hWgzD7MeJ8/pTFAwH4a0rByu1EO7u3FISR p44TeztBC3tCuxeVGKJ+OwS5bXdwgPSQtzoXnqmB5oBCulxm6KFsQDHuHEtGhpOqb1mVB/ObcUV liD/bkUlGvWfAQBSZIgkGRPXwnCMeRdSyrhoXl6aOnAbDkXDc6ryuPW0tG+UhZPlXFPvnrO0PuM s7fD3PQg5tnUDXWNt4fsKwmuTcp+sV0hn9zmuCPoGgDyfHOIuDn3Mgxw2WcnzueCoqPUoaQ== X-Received: by 2002:a05:6870:b1d0:b0:455:ae1a:c443 with SMTP id 586e51a60fabf-455ae1b9322mr6276848fac.42.1784184649252; Wed, 15 Jul 2026 23:50:49 -0700 (PDT) Received: from localhost ([74.80.182.90]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-45200b7b4c5sm15321701fac.10.2026.07.15.23.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 23:50:47 -0700 (PDT) Date: Thu, 16 Jul 2026 09:50:41 +0300 From: Dan Carpenter To: Ivy Lopez Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: use kfree_sensitive() for key material Message-ID: References: <20260713233401.48262-1-skunkolee@gmail.com> <20260715235511.7357-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260715235511.7357-1-skunkolee@gmail.com> On Wed, Jul 15, 2026 at 05:55:11PM -0600, Ivy Lopez wrote: > The set_stakey_parm struct contains a 16-byte encryption key. > Use kfree_sensitive() instead of kfree() to ensure the key > material is zeroed before the memory is freed, preventing > potential information leaks. > > Signed-off-by: Ivy Lopez > --- > Changes in v2/v3: > - Remove unrelated ftmac100 changes accidentally included in v1 Needs a Fixes tag. regards, dan carpenter