From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D02B3FA5FD for ; Thu, 16 Jul 2026 10:37:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784198266; cv=none; b=gL70A7HqrwzyFn4Tmucmf6Pou1P9uKescdSdewgyqGJf9w79nPoxCW5C3p8tR524aklAvwrvs/k1EJCkg+qShQm3jqPYqi8O7E2aYKN89Ryaql4/J4kG1/tVMN+Oqc6yiq9LEx4dlU+NuviSBygdMRWx248VYbwx1fPQOXKoK50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784198266; c=relaxed/simple; bh=THZ6Dm90Uo5++KFw2Oyy1EP/2IUaW1myPl82jpCEWKw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gx1QK1P3CwHrWz+nJgef7yuG4zAxJhICyJ01DwKzwnZ9tSQCntWG5yAv9qkqSu2XQAusYH9WCE3twBCZnqIvP56ZN9Z7r1Xeft5A8xNjYAOlXQuo/tvErn2fBeRrqknlnIKsLIoxZZkOlr9whkhf5Qda5cCIB5m7bSryXnFquuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ds1VxlCW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N1MJCY1y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ds1VxlCW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N1MJCY1y" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66G9rZXQ2361632 for ; Thu, 16 Jul 2026 10:37:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Lk6h7nzCt6VjsgsfBseF8awD CLuqhyostmxHjxtpO/8=; b=Ds1VxlCWnV1p72FNQO5Okm5GxczgITU5w7eRiOwh zL6/1HoGDSPHMk11olZFZG0HIyP5UlySaCnFBhv/X/m71f6q5dDzMZaWD64uDir1 gYRMluOeCxF6ULpMxJZli0A0DFOR+JqDPM393xsKarvcCN7aZOUE9nkMaOcvVcP8 OlaskskdFnHg0nDzZxH9xpTML9iQh0MVIf0IYAfw5y3iVd/5abtTyKqGe/C1Ql/U hkUa27SOYYFM2EKVuisuLK9+CJH69NKEHQU5F3PWq9wUHfpZaL0b2KYmaJvF7fI4 b0QdiXDUZl1h/80YP3ifFV4rBzGGfMqYxzNUnnz7Yz6HmQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4feefqkc37-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 10:37:43 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c88cfe287e1so3083877a12.1 for ; Thu, 16 Jul 2026 03:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784198263; x=1784803063; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Lk6h7nzCt6VjsgsfBseF8awDCLuqhyostmxHjxtpO/8=; b=N1MJCY1yTVBNsDzJeq46jp3ASG6B1yQizm0olVb0PsKG3Wqa0XQRAvXkVv4poIXMmZ SL84XjPxDeEiSM63byp+CWA2l407OLHcUncNPlKNK8hJJ8okVV498exXyHLdbvLo+rrG nKgiRWXtOcpsPNcmhDZMzbuR121HTr7SG/zqHRramLlDGSPopwtZC90xFJc+SYCVdybz ViMHZnigN/hSTOuULcSIvHFw4TmfV6xv5Tz282LESP1yNfXNepvc3qa7/nQ1us6WFfn4 NoUFZ0oBTjl43haX0/9RNqJC3oPo9Vc0NcIjw9/TumVvYaLTZa3+aLeULNPhfUEy91/U slOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784198263; x=1784803063; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Lk6h7nzCt6VjsgsfBseF8awDCLuqhyostmxHjxtpO/8=; b=f+x2QHPVF7EFdY5jJ1BdYimdE0JSv/zyW9D1++C7tRgBsz2tMnDgcXs78Q2KvhwrgW l4qi9T/9qH8PwnyJzQIKo5/5nHpI5ncL0WImusIFEWxSOqX30B2ElreDtxKIHJYWn1Ek 5H8hFmV5ApjlF5iBs9twp+gBb1+HYRc5HripKCbF8L+mJxTMqAL9Q3OXXuVUvvQe6EuG hzkPnS5aZdOen9W+JQZ2dAlaiaXkneyxAZBZZtikLvjZ6hYc9tvIEZ2gHREZeB4in3Ch CMviWY0tgmpkJRhpJOa00sxuHtDx8DKonVZKWai/Lvt8LJlt6/ZVhPO2hPIu32Zx5OeR eSow== X-Forwarded-Encrypted: i=1; AHgh+RpFdkPihAg6o0cYK26qKsVPO7VjhMWkveFATRGJjqopfLlkYLwquhd8fPnbWNsknxci1OPMxMJ92XtA2Wc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4P8b4vTKs+oTCpCEsH0u/p7F9jsjU4Jq/l+8mnbZx07p0PtZN ci3If1hr6DxMrHe8u8YZKwWSaunyCISi7VEmNF1xkPTD/fytdb5PI2E8Va5Ej/L9YgV8pU9ilAp zsSYn26DjMwRoDubbnedqIKLuUqjQhPN5ACvPybjqstDL6a8UIqbNGAv6OE0kCqxMkrc= X-Gm-Gg: AfdE7cnybHxCW6rtq2JC9CEdb1AV0fooC2YPS1cIuBFiFoMUbmUiC8YW6QPT8qlFvKb knTn5NFRzZZq8U+9f/nL1rKt6EhM9UuPqHUxrhee5bWOizz/1cb0Q3b2wWiV75M9MHDdB3TaDZB MDIShOb2yvyBs8coWH2mm8wwAKwvl9s2fSKq9R2zytkSNrYwLeIAKTYK9XkwKYqf5/8VOnAVZ4U P/yMnMk5VCiF4vbJyf1wHlhgkVtXcGd81vBzzn4uyF9VCRnhabfMq1hkmLrtBODi7oMJptWIWEX VSM+0O7KBIt2jmVEOoQpEHEjSj22W9zKIW54Kgae/W7conxkkU3JB8PmQC8kLi/2jo8iSIR9viJ sCJVgdX9fv69ofYrHlOTT6b+XUcbFwVi6Net2LHqYKDSti6yU5A== X-Received: by 2002:a05:6a21:4c13:b0:3c3:928a:b0c1 with SMTP id adf61e73a8af0-3c3928ab1d2mr1591969637.74.1784198262865; Thu, 16 Jul 2026 03:37:42 -0700 (PDT) X-Received: by 2002:a05:6a21:4c13:b0:3c3:928a:b0c1 with SMTP id adf61e73a8af0-3c3928ab1d2mr1591945637.74.1784198262413; Thu, 16 Jul 2026 03:37:42 -0700 (PDT) Received: from hu-petche-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13cdc4accf4sm1387292c88.10.2026.07.16.03.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 03:37:42 -0700 (PDT) Date: Thu, 16 Jul 2026 03:37:40 -0700 From: Peter Chen To: Krishna Kurapati Cc: Thinh Nguyen , Krzysztof Kozlowski , Dmitry Baryshkov , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy Message-ID: References: <7a099224-ea95-40ec-b279-f8834f261e23@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=APNfGQ4N c=1 sm=1 tr=0 ts=6a58b477 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=pkNXjn1FWkeuvB4ljW0A:9 a=CjuIK1q_8ugA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDEwOCBTYWx0ZWRfX+dqbDz3qiE8O gcuszg9+kF1OFAhHVbuGse/PmqPoQGPU6+Hyqd6XCVw5sL4uI1qRMZRx5DoKwIhTp49fhQYksh6 +Nzn6srBkYehfY1IUJAhMero60Sec28= X-Proofpoint-ORIG-GUID: z_i-Bbo_1ZrBTZbWHFl0y-JGixtd5Y7s X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDEwOCBTYWx0ZWRfX2xButb22WgNo F7ebme15xsxv57xHET4p2cUIgthpNbnQO7B8nWjJPE6exWtyUvq1OZR07kmymoiD/+RNMZP/sHJ cSabMOHOO1MP1R/TuZ1a9dVwwIbuhRzeIhOQFsGKAwT+8xp/08282a/fgqy8WsQJzjKw6h34061 i8QCLkELFmsMmZVjUQxlTb/Y9nVvfIzGy4TVJON2QxVF8GofaKTRgSmkF0yxJlt8QF8G9dDrU3m LOVvxb0akB7LKUkt5xOJoL9PumX0fuvGfk8kYMEPgkBGyR1lVyQkiTYgFOqt3dPQ4+6r8mDa7if A+Z9+bYUqudYou+DgcxcKLFkuIswiwh9cNr9lPDPHcMlKx5Hz4BWOEk0YBg1j5wAwfOUWiF6Ugi vMSaecHN9h3voCJ7NfFWACS9jhLGhbjQcXigbsyv8tLdeVahxnGCMuVpYoY9AeW3ruRJYO481Qj 3PcwWrGSU9pCH9Z4U2g== X-Proofpoint-GUID: z_i-Bbo_1ZrBTZbWHFl0y-JGixtd5Y7s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_04,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160108 On 26-07-16 09:42:35, Krishna Kurapati wrote: > > > > > > At minimum, dwc3 needs to be reviewed and updated for dwc->hsphy_mode > > check when configuring GUSB2PHYCFG. Regardless, phy type should not be a > > usbphy_modes enum as I noted above. > > > We can just add the enum for eusb2 in of.c as pointed by Peter in [1], read > that in dwc3-qcom.c and use it during suspend resume for interrupt handling > and to modify the DWC3_GUSB2PHYCFG_EUSB2OPMODE bit once we are modifying it > in core. > I have seen fewer platforms use "phy_type" at dts for arm64, dwc3 core uses it only for special cases and the code was added for ten years ago. For the default situation, we may not need to change DWC3_GUSB2PHYCFG_EUSB2OPMODE value for UTMI+, Thinh, is it correct? -- Thanks, Peter Chen