The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Qiang Ma <maqianga@uniontech.com>
Cc: cem@kernel.org, djwong@kernel.org, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: clear zapped attr fork state when bmap repair finds no attr fork
Date: Thu, 16 Jul 2026 01:26:21 -0700	[thread overview]
Message-ID: <aliVrdJB5tAw2lpG@infradead.org> (raw)
In-Reply-To: <20260715103026.1701559-1-maqianga@uniontech.com>

On Wed, Jul 15, 2026 at 06:30:26PM +0800, Qiang Ma wrote:
> +	if (error == -ENOENT && (sc->flags & XREP_ALREADY_FIXED)) {
> +		/* A repaired, empty attr fork no longer has mappings to check. */

Overly long, either move it above the if or turn it into a multiline
comment.

Otherwise this looks good.

      parent reply	other threads:[~2026-07-16  8:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 10:30 [PATCH] xfs: clear zapped attr fork state when bmap repair finds no attr fork Qiang Ma
2026-07-15 17:32 ` Darrick J. Wong
2026-07-16  8:26 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aliVrdJB5tAw2lpG@infradead.org \
    --to=hch@infradead.org \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=maqianga@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox