From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773A742BEB0 for ; Thu, 16 Jul 2026 14:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784212276; cv=none; b=ODA7IcUYTzAR8dnSvZbaXMm58Pz2DCUXd2eouhY7MLNhLSYXk4gkCihG7McNKTAHwrgym+CSeR4wURtzaL4cxTsqNGCnXnz1WMsnYif35wcrfXHmttFdlnAzJ68u86UyOO7sPnt/iFktKR4n7XmqxX9D+ncL06Jka0Ffjscxx9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784212276; c=relaxed/simple; bh=Nxx/2EV2lPJc1PCs/jGP+MILodlt0ez1rkHAhA6QGYE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dxw6r0cQNFkNDYdJ0OqSRTLpfec2iPVL+M0CI2tFKR+SxetmGTvn1iAEsSwEl+SZEmLUYy01hFyOtN1X928mMrtlT6z3B6+smXm1MqS01xB5nl1WWoqXajtz/Ukgf3rHU55w2y0XRKYzulSVZdRh2aN0PxJgKX0598eBsJ6389s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LUYfKCR7; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jbLtwjSE; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LUYfKCR7"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jbLtwjSE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784212274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nNxG1D+ZjGW+3RdHUwFcLL782nqg2H+vzuXmmfdFhLs=; b=LUYfKCR7Cbk5zbBuEENood+kx2T0oq6LAGCTv7sVrQBNIs2ENnd8HN+tu74OoJ91urayLN KMtK8MaYfBuGB+22/twoxNMn4IYnLjM6r2aYhPWZuSkR1gB+HqJ7TZUyfoSo36x+DB2LN2 3ueoU0nr2k4mdocCgvyoZjlgZNwszQQ= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-QqSLtk-pOuyTfx3EjDnMgA-1; Thu, 16 Jul 2026 10:31:13 -0400 X-MC-Unique: QqSLtk-pOuyTfx3EjDnMgA-1 X-Mimecast-MFC-AGG-ID: QqSLtk-pOuyTfx3EjDnMgA_1784212273 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92d1cae5939so926715685a.0 for ; Thu, 16 Jul 2026 07:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784212273; x=1784817073; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=nNxG1D+ZjGW+3RdHUwFcLL782nqg2H+vzuXmmfdFhLs=; b=jbLtwjSExAH1MRqQ0SzxGCn8sHzu6gb/r6GtVO4j2qX7kt7mrnTEf7L3M/2C2hw/qO aiqzyqRyHwA+mfJ9Xd46yE0PuIPYUwe1ZU8czrmRPVKIvnOVzFTzjqXpWCDDNCR2yFXh zUm9ckyRA39i1vuq0vCoGVxNo+aMXskRgMVcyzV3dul0oUplRt1SqF+iGTaCVAg/R9TW eI84K2u2GDK4vyTFR29BAGgO2FpwSbagoU9KrB2lY0j6Vf82Hps4aQDe6FvN/oYLFxe6 fTKoFflewODc1aB8HJeE8HgkJW02XyQNn/om7q4U9qLKc0k5yciE5AAYPDDNW+d7Dctm cYlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784212273; x=1784817073; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nNxG1D+ZjGW+3RdHUwFcLL782nqg2H+vzuXmmfdFhLs=; b=NtAf7v9aZRYYCZUTDqnzni/sWUfNWn/a1zaMbJdRgsziz2QaU7l8L7DHUh0JcoPKvC x8xQNSqYhwAQrvmuG4f4WPOsi943gMcjL1lNy5BC7y0dQGMoO8YGkPSk9astxo/lVnI/ qqgG6doHxCtjGQNMi4nQgDe4HLfHMC5PepHGaGSzcfYO/sbz7xNw7AjPQo9y0+2yH52b KOVV4J99MwCnx4zYTaA16XhCBH/hg62JK/kyAJEsEVY1Mkht8/8ZgdtyB4wYO0qUKC1B M/x9AkyXmBwxywm21XYVPDc/JC7pkf7DjEBD9pLW0meAJ4xa3wPGD/XgTzklEJLZ3boS duoQ== X-Forwarded-Encrypted: i=1; AHgh+Rr3E/ERgmKa/K/taejiUeZgNqwDIcjxA5RigrErWaZfgXCP6i0j45NlkMzj2g7rIqz/HpkGK5s5sAjx7x0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5BBybMEnlsJfHE7CNqNRxQX1l4YQcyaO7TxZGHviM8JxeWzIL gvBqIvAvs/cw2AWVyfCPq+7BlBZcmahy7zih5Rl0DkTOODVSyI9PPNoAijmJQFbTGJoeuVwzJJC Ou1uCKUqx8t8yg55JTjJzYBKyFHrCYaOHmjIppzRDmjmCASQ5DObkc1NRqtsxm5f4ONXWpTxMcA == X-Gm-Gg: AfdE7cnzIucop+6PFSSofwZjztKEpvX6Ks9BcgNh1gABeVuNxl545Wa0zOkk6fva/yi lzVeXZ5t2HhOWgmkGGv0NEHMa4w+UudxGHnPYi3uR4R5VSy4l4pBZFA6xTlWUhDKQg7kg4/i6e6 cZPWs7ZVnzbDfERnOGq5YRP6XrN1gld21usKAnhMMTUrH2tmyM4hxPXQmQtS3KGkuhnGVphWHDL RtDAaP8xxo8KBI2xi6rNTDC4U6w1FJgGIPI95wOsVqOEVstBOgHzlu3DLhiAYgrie+blYMHza6q MuV2u0nVSnhdvo9U4mynqK0/sCMdUvDA7rTjEQiFpF+PG5LDzCW2VY0pW7ysJvtvPDB4xpQ= X-Received: by 2002:a05:620a:3729:b0:92e:da7b:561b with SMTP id af79cd13be357-930868324d9mr1218166585a.19.1784212272427; Thu, 16 Jul 2026 07:31:12 -0700 (PDT) X-Received: by 2002:a05:620a:3729:b0:92e:da7b:561b with SMTP id af79cd13be357-930868324d9mr1218160085a.19.1784212271847; Thu, 16 Jul 2026 07:31:11 -0700 (PDT) Received: from redhat.com ([69.43.42.202]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5d2d68bsm2007014285a.33.2026.07.16.07.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 07:31:10 -0700 (PDT) Date: Thu, 16 Jul 2026 10:31:08 -0400 From: Brian Masney To: longlong yan Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk/x86: pmc_atom: add kasprintf return value check Message-ID: References: <20260714065133.487-1-yanlonglong@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260714065133.487-1-yanlonglong@kylinos.cn> User-Agent: Mutt/2.4.0 (2026-06-19) On Tue, Jul 14, 2026 at 02:51:32PM +0800, longlong yan wrote: > The kasprintf() function returns NULL on memory allocation failure, but > the code in plt_clk_register() was not checking this return value. If > kasprintf fails, init.name would be NULL and could cause NULL pointer > dereference when clkdev_hw_create() uses it. > > Add proper error checking for the kasprintf() return value and return > ERR_PTR(-ENOMEM) on failure. > > Fixes: 1141d9d08184 ("clk: x86: Add Atom PMC platform clocks") > Signed-off-by: longlong yan Reviewed-by: Brian Masney