From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BCA0429CCA for ; Thu, 16 Jul 2026 15:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784214412; cv=none; b=bIg/M1L234/UoC20NYBN90l+y0V1po4rjW71tZv1OonAZrpEYN1oOsUH8OBQ3fBF57hd5ZEZ8xGYdu9MJk3UYOx0ZUfBBg4iVLZKtUTcqH1Klhivxyvq/MCdyGI1jT8H1NxgKWEaiYhQJXRakLkbi9W1o9evl3B/vHwdzgOEP8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784214412; c=relaxed/simple; bh=7+u5nQqfv/qWandfNnFPC5wehZ7dDTCwtkF0Yx7+DaQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ge5ftxkGdGFshqjDUMgS/zmXyrrD+WSmjQDQzQaShbik6SCWvKkgHPlFM6uMfxMuJseAtwAWtUfsN9k124UT2/ZdOtJL+3oThxtMZNH4l2N3sMG7Cv+WhhVqeIfYaZdnWL/UjL+7LfrfWslMf8x2Lyj+PzVOjIZHp9XVtlI1BXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YCJA6Tqh; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YCJA6Tqh" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ceed7018c8so22608995ad.1 for ; Thu, 16 Jul 2026 08:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784214405; x=1784819205; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Ij9NGDEmc5LrAtoqRZinGQEY5N7/Qr+UqAm4jAuK+rM=; b=YCJA6TqhSPvDVVkt3mNah+YK8ZBiHIWyodh7qR7QtqAGUgFWM3s1r5Tn7K33GgmZ1r 7n5V2ARiUe7+18WZz1l3xXhMiJkM0WmKma9YuYWhTrOJCPrhr5sz9vuE+yMXd2Xt/ruc GbOsrV4wQZ9Kt8W9VIUN98xZF4SFqOd+5D8KiAiLwyj6OmozKyynbAEzARqSeEXrLouT wjgl4v2Sy7aDh3GzdQhSEbsOe57zRAnFVvRhoDlaM0A/3MdZzmZPoRlC6QuC+DsK8tnp JhS1dNC6DkLdUcqENPUh8cBTQpdyVQ2EMtgU6fBBoO2quddbw5ZOIrZ94porf5Zg7Aiu PcnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784214405; x=1784819205; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ij9NGDEmc5LrAtoqRZinGQEY5N7/Qr+UqAm4jAuK+rM=; b=BobGRJDRH2xQStsXursgDHyMiuFkol4uM5kflgDSM4mdF0HCym9ts8ncbbDFpqUpsB Ekhz4FH2Q9izyLXZwb7vM99nb98bu2JCRgtPW44S6zYcxl0T1Lk4J33OnzBE7yIsfhSr a9rx7abrrOWcdYihTpgSBOV2u7rwce0T3oOuT5jUkPIamoUT+GdCIBrnWlCa4o6CUcX0 ls742B8DmBICv3/P4fqW5lsl+ZCZW+3ihfPfr7Vy007krKdk+0kgoTdsDBaokhZV4KvG 3Ho7/OHNjhMEEGM8SAsNC1k36oXSDZ47l+tb94FBnFzi7IwOrR5M4ncMjekLkGQIjo74 BzUw== X-Forwarded-Encrypted: i=1; AHgh+Rq54X8FPK8HZe11D/dOBp3FJ8HYmw/FP+ccs+KEnXv4CnQhZS1Lkv0xWe4yRc6A9q6fGvz7DGkfgOXTywk=@vger.kernel.org X-Gm-Message-State: AOJu0YwfYyHW5FatekEWAlbzlBuDPYd48lxW1N3ApcRVEhE2/I6IfeoC dgBDeozmgcwDAHN5XJyJCdPVRd96loyyCViG61GipU+lOK+Pk97noAYS X-Gm-Gg: AfdE7ckXeQtdn35TN5Z19w0e00aTeGXcaMCzdZMN34nr48yG/4Em/6Oc6NvLrfXwpse IatiZqJ96ZDI9pr9v/m02kAoa94o/Ce6bckVrXa6JFagRw8MYS67hSdU9M8pWXDjSfUzqaQJM1c nfC9glY8yLIjFfoIsfPjMwlrj5UffG7l5ZTfP54s6kO9mezMrF2GPG89gQ5JAfehE2N5JYYJPHN gMIPYUkh0OFTJl/0RVNyFc6qsSK1ojpLPvkbW3a1+5H5n6eZD+L0yft1S//qdWQ32dw+9YUsC3m siFlDGZrC+ELvVer8mtKUx76jm7Fss1FU1naXy9ZqWfDfVS15ek8mNre0ieWJWAzkA/zyWy+8kv fuJCgywFTbXWOotZA7027Cqotr6tywcKcRyxlAIUPeo21+iTWff4VoRcaVwK52vHGZH950bqBQL BBOFjuc4Tfrex+AQ6tlqEZLaAMshgtfM1IabLEuk7opHs= X-Received: by 2002:a17:90b:3b89:b0:381:5a08:6291 with SMTP id 98e67ed59e1d1-38dc7779d6cmr17537203a91.20.1784214404991; Thu, 16 Jul 2026 08:06:44 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:38ea:b937:53f6:928c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e2a20a7c3sm1475506a91.1.2026.07.16.08.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 08:06:44 -0700 (PDT) Date: Thu, 16 Jul 2026 08:06:41 -0700 From: Dmitry Torokhov To: Lee Jones Cc: Arnd Bergmann , Bartosz Golaszewski , mfd@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mfd: ucb1x00: Register software node for GPIO controller Message-ID: References: <20260706-ucb1x00-assabet-swnode-v2-0-e6271ea3d3dc@gmail.com> <20260706-ucb1x00-assabet-swnode-v2-1-e6271ea3d3dc@gmail.com> <48adc770-9d55-47a7-a779-cad73b587b83@app.fastmail.com> <20260716124052.GH1260374@google.com> <6dbf2f49-c1b9-448a-909c-7675ffdc928f@app.fastmail.com> <20260716140027.GK1260374@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260716140027.GK1260374@google.com> On Thu, Jul 16, 2026 at 03:00:27PM +0100, Lee Jones wrote: > On Thu, 16 Jul 2026, Arnd Bergmann wrote: > > > On Thu, Jul 16, 2026, at 14:40, Lee Jones wrote: > > > On Tue, 07 Jul 2026, Arnd Bergmann wrote: > > > > > >> On Tue, Jul 7, 2026, at 07:01, Dmitry Torokhov wrote: > > >> > Define a static software node for the UCB1x00 GPIO controller and attach > > >> > it to the core MFD device in ucb1x00_probe(). This node will also be > > >> > used by the created GPIO chip. > > >> > > > >> > This allows machine subdrivers (such as Assabet evaluation board > > >> > support) to reference the UCB1x00 GPIO controller in property entries > > >> > when converting legacy platform data to software nodes, resolving pin > > >> > bindings directly via the attached firmware node without relying on > > >> > name matching. > > >> > > > >> > Assisted-by: Antigravity:gemini-3.5-flash > > >> > Signed-off-by: Dmitry Torokhov > > >> > > >> Acked-by: Arnd Bergmann > > >> > > >> Assabet should be going away soon, so it really doesn't > > >> matter much. > > > > >> > +EXPORT_SYMBOL_GPL(ucb1x00_gpiochip_node); > > >> > > >> It does feel a bit counterproductive if you have to add more > > >> exported symbols. Just FTR: I completely agree. However Bartosz is dead set on not supporting weaker references based on name matching and wants only identity matching. So we export bunch of stuff and pay for this with tighter coupling and potential changes in load order. > > > > >> No need for the seperate declaration of the struct tag, > > >> you only need this if the first user is in the argument > > >> list of a function, but not for a global variable. > > > > > > Are you planning on fixing these review comments, Dmitry? > > > > Just to clarify, I was not asking for anything to be changed > > in this patch, just observing. I'm fine with this version > > getting applied as-is. As I said, the file is probably > > going away soon, so let's just make sure it's not getting > > in the way until then. > > The 2 comments above sure look like review comments. > Well, if this all truly goes away in 7.4 there is no much point in polishing this. Thanks. -- Dmitry