From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 707D543E06D for ; Thu, 16 Jul 2026 17:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784223019; cv=none; b=oqbughcVUG7HDf7a/1py/csuz7IzRJhtU49nifiG71GMo/bUyMXSLb1BBKiWXwTrLINxkAdhjAwrDEINm6RvSB68E+JKd5QtZV3lJ7C+hGPa/1cHH7diIHsLvri4brh3DblkamFtbYsuP/VJ/BneO18eQDA8ICkPEycb7YoNxF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784223019; c=relaxed/simple; bh=znIpRc+TOl5hK8xOuLW8u8SiTaWPKpiddGKsVC+Oye8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NXc2xDrI71DGkqPpLx0f0djGWnJWK/0zMqtd+zvEInCRikGKZFAXf4ANKSFVCQae6Rk/P1U6bknEasHC6PsGnnZQwBWCig+f84l9YfBvYIpcg/UH6mu01wAVKZ0TUP7dd9Tp3h105Q8Di9EtEFHHPVCTuyHH36/YeA1qQtKlRmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iqL2Pxrz; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OktTjF09; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iqL2Pxrz"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OktTjF09" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784223017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uCPldkKY5WQbG3wYqrfYXCPADMIMyTj8M/u2E2FHGl4=; b=iqL2PxrzobhQEc6ijQV9uC0yOju9SxD3sa0fXsoAnrz2cstDzJf983f/bi6A4VGKrRUQ6m OOZ1zZD0+VYsAnxquDjKjF6aEFY3mJIKD1fj5kL0Yj8Nqy9ng0guEnaXGm5gdxzSFuDIOm f2RnCqqZUb6V/D1Olol8tHu+x8eyQqY= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-8cnI69OKMPyFofmM1FfR8g-1; Thu, 16 Jul 2026 13:30:16 -0400 X-MC-Unique: 8cnI69OKMPyFofmM1FfR8g-1 X-Mimecast-MFC-AGG-ID: 8cnI69OKMPyFofmM1FfR8g_1784223015 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1c7f135bso66455331cf.0 for ; Thu, 16 Jul 2026 10:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784223015; x=1784827815; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=uCPldkKY5WQbG3wYqrfYXCPADMIMyTj8M/u2E2FHGl4=; b=OktTjF09VBRL6u/P2QYSNe4zaRK+egUk4M3DkFcgXgkZ+DJeLkOh8a0l35i1dgKE8e zyZEk6tiDy4uj5YnRnZpQmo9vCOxSUpJUjjanid7QiBM1VLIAgWrotNL3exuoe/SeOLt ha1r6USFf1Yg+mutHetFnHSDuEZhxz4EnvuQvIUNpAI6LBKT3B5IIzzmDKEqIe1WeZbr W9Zp7kdfa53jk9C+fwFHZxVL6HyAsWdk5Y0tUpTJH82vEsfs8WwacPE0Sfo9zxEnxkZY YHrF/sMj8og2+P3wWFnenocwXKgRZ9QMDIeacFUkfUCFklZe6kydpeJcQKTy8YoXxf58 LjPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784223015; x=1784827815; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uCPldkKY5WQbG3wYqrfYXCPADMIMyTj8M/u2E2FHGl4=; b=gf1QzS3yfFO8BBB85AavFsrpeRaQA/6ZgCoi3Y9KNwDK9IcCSaByAKjgdcx2An4faB wDbf5ESJtrdFm6uTznGfhsjAlBRC8Ui8jADkGIWCWDISeV8VzlNHpFnokS//jBU1ZhJ2 2jK8hednzzH6DBnaojsUKX79eAq1SVcRX7dO3leIbvtoaNLbhviwqb9wfpOPKEN4POq9 10r4MTifAC0RNXgGCksj/MCoAvN/HbTAHf5ISlvEjxzUuKbqVq7DHCc6dv82S0DHSyAG IzhNZhaJ3jwj8lG04ulk8gvYTfgxPwbcKrm/HGEweL3TOKOfuw74zkMer12P1mHZRduP IlAQ== X-Forwarded-Encrypted: i=1; AHgh+RqVEXE2nw9GSTkSZMkL/WPQ2BrvnR0CwTU5AYqqy82ZGCj9gQAMK/jju1TuTRaUd+aKRxRBYukE6MA9heo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1IG0iBjPHGzWsdVQwGXLEaFS9mHnrq6eMky8iMwMFtI/5DSNm S1AhoPjEHbqHdeS+YQZfBF6DwbECNpLA6QaaBkK/Hds0qau0Ujfdav/IE016B8KxQkuckTjnjHV Q89ghRqD8PY5Ik7/uYcR+ngLj7CAToUM43BZw9bonoZQzbET5+uDz+EhKjBLQ4u6bViw9V1ymrQ == X-Gm-Gg: AfdE7cnsrmskr6UMhNK4J9yGI7r9olsgSGKmbaXVuopXI7bB+R8QjRwHw7K71mOc4R2 eeEQedMUsXC5qfZdPGy5gntTJhdZkLu5RpqE2EEbS/8b0XMYrNTymaFfHCJhiTpUyecEQs6NwUC vHILKZoFrIDU+G9tM/4PHxsnjYX8AyfNIKSimwriU/HaRkYEMckD27AelSI7Di31TwxW9Qx968d daJ3hksXbtCaSBVBChQS08YdzXQUnp8eS3lq0TMr6c5I9lC6z2k7VuJXoj6DETr4zJsy0E7p4en 4HQkOi6e44MD9N//y5gAGFi7egA6V3IdEWNmyaJITmmMYfSYTn6X31kGTeYly1AqFOG1a5JYfLa hKg47pyMRrT77Sh243EuLYkuhTfx7fEnUuoM= X-Received: by 2002:a05:622a:4018:b0:517:5bc1:e1f5 with SMTP id d75a77b69052e-520b9204263mr6436651cf.0.1784223015266; Thu, 16 Jul 2026 10:30:15 -0700 (PDT) X-Received: by 2002:a05:622a:4018:b0:517:5bc1:e1f5 with SMTP id d75a77b69052e-520b9204263mr6434021cf.0.1784223012767; Thu, 16 Jul 2026 10:30:12 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51caace31a4sm164561561cf.12.2026.07.16.10.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 10:30:11 -0700 (PDT) Date: Thu, 16 Jul 2026 13:30:08 -0400 From: Brian Masney To: Karl Mehltretter Cc: Stephen Boyd , Michael Turquette , Ryan Chen , Joel Stanley , Andrew Jeffery , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: aspeed: ast2700: select AUXILIARY_BUS Message-ID: References: <20260712160301.98941-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260712160301.98941-1-kmehltretter@gmail.com> User-Agent: Mutt/2.4.0 (2026-06-19) On Sun, Jul 12, 2026 at 06:03:01PM +0200, Karl Mehltretter wrote: > The AST2700 clock driver also exposes the SoC reset controller: it hands > its register base to a reset auxiliary device via > devm_auxiliary_device_create(), which the separate ASPEED reset driver > (RESET_ASPEED) then binds to. That create call needs the auxiliary bus > core (AUXILIARY_BUS), not the reset driver itself, but COMMON_CLK_AST2700 > does not select AUXILIARY_BUS. > > It builds today only because RESET_ASPEED selects AUXILIARY_BUS and is > normally enabled alongside the clock driver. On a randconfig with > COMMON_CLK_AST2700=y and RESET_ASPEED=n, nothing pulls the auxiliary bus > in and the kernel fails to link: > > ld: drivers/clk/aspeed/clk-ast2700.o: in function `ast2700_soc_clk_probe': > clk-ast2700.c:(.text+0x147c): undefined reference to `__devm_auxiliary_device_create' > > Select AUXILIARY_BUS directly, as other clock drivers that create > auxiliary devices do, so it builds regardless of the reset driver. > > Fixes: fdc1eb624ddc ("clk: aspeed: add AST2700 clock driver") > Signed-off-by: Karl Mehltretter Reviewed-by: Brian Masney