From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C87B03CFF55 for ; Thu, 16 Jul 2026 22:09:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784239788; cv=none; b=eKmkiGHbkwHrH3e3UoX6T5EMSfXvreK+hNkRunx7OcZiMM4JK2u4YaLd9vEAUfGFm5gbeSs+MAFGgm3XLdrlFTCNkyFJ4Oaye81z4Ft5K54LjrHYmW+mlwPHQPgineXzRHq8hIJBQh4bdvUN13FeURq7AjPje3ephkzWSFpM56E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784239788; c=relaxed/simple; bh=yp7femv/V8fKD3U+yF6PxiExk1H/2svgfavtzZ8QSK8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=fKlH28pcZszCNMXpno7NoU3cxGQPTAdETMGGYyzUw1iBICwQen+/UBXSEzYoCDT7cLat8+0dmzFiQu8ZMQ4Nfp2sYUoQM/GSpH/ZKQUCo1O80IbBVhOhy9iePl7w55VpaoMWNNQf2fStN/VIEtCwLS+KUMcsMx/11wrcAyVWatU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rVAlcfve; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rVAlcfve" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493f75f7172so52823035e9.1 for ; Thu, 16 Jul 2026 15:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784239783; x=1784844583; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bDZJF2FHgZ0pc0vw2vaEItundHS+IICtSs7RbOX6+08=; b=rVAlcfveYtfLID5cyrQxdsb+1ZLUnQXs+KhDsAI6M5wNwSFMTwCS2Oo7vA+SJsMU+t oazkPzaqSDlajOuuAK+GtYm2OcpJo534ln3vOaniNM3NPaJR/E66z1vYhwa4GeBXPwFJ sVEqVlteMQWPKUyaKeXHZY96VZusz2wHjoBxWjendNNPrsx7sOug4kznR8s6xrLdSFoW KcQ6XHN0P0Ky9dXXkXp87oflBl1qd9h42iC7YdhAi5q8mmVG8oyWOZUmzskIL7pdJQCB bWildxP6SceDU0Ss0kH8FWDPmnCqPAC+HP9tEVN379LOyKiJPu7zQy9dORCCgxC8cZ0n +ozw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784239783; x=1784844583; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bDZJF2FHgZ0pc0vw2vaEItundHS+IICtSs7RbOX6+08=; b=Pd7U9ACFBfF+6OdXawa5omBOGsz3d79+/XsDkwjFRu71RrUuzCUu9TIYU/sDOTBIIb JnkeJsDGCciU97ESRIuIkHjWwOTZgjX0NugSfdv1ojwiPh/o0XaU1bGqdOpOVuQcdIWh xZvJW4+ThLzsGmrR5pZHwqXvdas5v9LhaYLkQ7FpFIm1cfI5djDaPalIQxErjzPAr+II ERFJipUHeUHQBoCsx/UU8SOLa9PpZXjNoalZB9B8vWhHhHzeSSBEvPQi/Pl370kb+7Nn ATPngXj+M30jOXuDpm6+QYuSMHWCg6WUL3earq7j0E5+VvAGJl+7eAqVMCoPoE2k9Ovx 5G3A== X-Forwarded-Encrypted: i=1; AHgh+RoI/36jsvtja62nnQ/kBGlFUwNEJ2jCyEShu8ioRQOHG++oUGb8/Wwuljr5R61Z6SsMv+llidL1FS8YLpw=@vger.kernel.org X-Gm-Message-State: AOJu0YxDxYtvNwfDpyssSxOBHrEUpRslbXWnpbSGFlMag+WXdC4OUKRM +5tURqXHZ2ypJsQRmW5rA7qLRLt4ycsNaBzZ0Q/yZBm7xKn+sZ+0wG3ua+ZzPg== X-Gm-Gg: AfdE7cl/IuvK1FYsRpnVDwWHnAUZ95AuOCTxAu0JhvjzYlWcczhCfogtyYr5txgHMGY E2YqeODbTGQ/0FP0QJPn9gi3sSxuo8cC69Tmwx/YYYwEQn/xZx4+cyzOT1U4t6soDwGjr/B9UTV h9GKtC9uk7PA/FpXWRKKf5yZQ0VusldkbKocG/d6GXO0AumiqbRDLLC4wxLC5y4pYJej3Xnv8m4 zJFAnevedMDGAYgerRbBAV5c4+oVDtjMm6LITMjqVJ/TMY7TXEj+AdkfjVL74tWT5I/rJvRmGoO uluxZvyxvhEvO4zvw889rt9+fS0ZhBWJD7PkVasyCY5S97j7LGQ3GrIbdJPBE58ZCpqp2ksjzFM f2OH5xPZnuKV9HvWB8Z7giz09TDm0E6GhJ1Ywi28OQvCLk3/L2jHbZCvTp9J/0ZvZ2UILolgprW QpWmm4kK19tSkF6OW/Gtw1yLKE1eV1SZQMldjChA== X-Received: by 2002:a05:600c:6dda:b0:495:3aac:1098 with SMTP id 5b1f17b1804b1-49540bdfaa6mr45166035e9.32.1784239783219; Thu, 16 Jul 2026 15:09:43 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f4634e5c3sm26705895f8f.1.2026.07.16.15.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 15:09:42 -0700 (PDT) Date: Fri, 17 Jul 2026 01:09:41 +0300 From: Michail Tatas To: michael@amarulasolutions.com, neil.armstrong@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dianders@chromium.org, jesszhan0024@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/panel: ilitek-ili9805: Use _multi variants Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Convert functions mipi_dsi_* to mipi_dsi_*_multi as per the gpu/todo file. The multi variant of these functions include improved error handling. Signed-off-by: Michail Tatas --- drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 51 +++++--------------- 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c index e6c483851f1f..7e9587afebbe 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c @@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx) static int ili9805_activate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi = ctx->dsi; - struct device *dev = &dsi->dev; - int i, ret; + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; + int i; for (i = 0; i < ctx->desc->init_length; i++) { const struct ili9805_instr *instr = &ctx->desc->init[i]; - ret = mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len); - if (ret < 0) - return ret; + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len); if (instr->delay > 0) - msleep(instr->delay); - } - - ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to exit sleep mode (%d)\n", ret); - return ret; + mipi_dsi_msleep(&dsi_ctx, instr->delay); } - usleep_range(5000, 6000); + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 6000); + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); - ret = mipi_dsi_dcs_set_display_on(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to set display ON (%d)\n", ret); - return ret; - } - - return 0; + return dsi_ctx.accum_err; } static int ili9805_prepare(struct drm_panel *panel) @@ -211,25 +198,13 @@ static int ili9805_prepare(struct drm_panel *panel) static int ili9805_deactivate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi = ctx->dsi; - struct device *dev = &dsi->dev; - int ret; - - ret = mipi_dsi_dcs_set_display_off(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to set display OFF (%d)\n", ret); - return ret; - } + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; - usleep_range(5000, 10000); - - ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to enter sleep mode (%d)\n", ret); - return ret; - } + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); - return 0; + return dsi_ctx.accum_err; } static int ili9805_unprepare(struct drm_panel *panel) -- 2.43.0