From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1709234403A for ; Thu, 16 Jul 2026 22:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784240658; cv=none; b=buC1B4rZN9y3e/3pTAUM3epVCapwvfgdmqhujCupjUUoZBbjQFfLyediXgHry5KiNvVmZB+Nuyg6LXvugcKIoqyN4XtiUesOYv2rFOMJhm5UDBpqhUUAa0fsCveKwHB+Hw+8E2nJZyNhrq3sAr2vGNqAK4s/hc0tT3gwx8O2tBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784240658; c=relaxed/simple; bh=hHaaDlNJljpuOJ+UeiB4YjBn2Qqf+1PpdW9pgRg0rNQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=EdtAc8SeguToszev/rYb431RPgu/jXBUvdagl2jSCjvEEyYxtJkuvFVxSbxnakYAqsDqWyNB1UkHezPXzUg3BzPEvKta4HmhXjkuiMeNsCkDGR4n+I9JeTVcb+rmjMQOqRkiq8awN635aDl3O1dbtheeyPCZ678Tza2C04UWA7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C1wWM1it; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C1wWM1it" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-493f25d47dcso22920965e9.1 for ; Thu, 16 Jul 2026 15:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784240655; x=1784845455; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MRilmWySgchHqhE2g6n9YGHJfb2AaRGc3NvI8/zl/SI=; b=C1wWM1it6h4LzrobWbU0DYNIjD6jMtikO9RO3V4dlFyyPHqZ8rDnkcirhZFk9TqzcM WbBrelHJZFUWr4LwM1MGkUxIBox8zApbYDM9tLHrgygXgDbH1eXHGCMUj+yaLF8T/z6T vrteEGWUZiGexrur8QdvW6g2YYWkShbRnOzxpDSnoPqY5No7RaXJQjMwYlnXtQXfaIB/ B1SotUI1ZIJkrNeRF4oZpO3DZUPPB0V7Lm2XiVQizOznKOHLT8PLgzWrwuMB092ZYDsa 2Vf/h2XSIX4hP8lIulpMooOg59L+4FmqzWtOzSKDA8yAz4tMJEhNYWXxGJg+Oe2GGwTf mJmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784240655; x=1784845455; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MRilmWySgchHqhE2g6n9YGHJfb2AaRGc3NvI8/zl/SI=; b=T7fRfa1KKPLLex/NHrBKH2lTpAhyWcb9E5XM2CwGXRxf+uW3TybgMOz6Z/UTPNQpby X56xUjBj6JhZUZakCgJdpZDAgxqfqmTbpLl6ZCWcL2655tmQISWumsx3riTrRlVFEcbN PRRNHDF2FowSXd3fXz/EUKdCGdGM/zKZC2h2zaLZNy2KMbCVSUyyLuMCETcJ+e9+RS6o 7c7+TqhNCtoOftZhZ1FhHPepNh/UlqT/xNXNNxw1oWzOQRAfKebP5z4dE9BVi3KIK3xm /vY8ddYCaUyIUbLXN6/F4bGnSYAwBWIZd6KtosRNTWTyOgum0pWDXm4VkGOIze7jbA33 qTmA== X-Forwarded-Encrypted: i=1; AHgh+Rqaiabao3ZVocfj2aMKJgYNGZQ2Mx/3QbhjQxKn9+9chbzG8BMfV6xGjQ/Ud9meQ2RrZFb3S85Ip/AfpMI=@vger.kernel.org X-Gm-Message-State: AOJu0YxOBoh4ZLlprbHYJJW+GdBNdgkocRPc4RKyHM1Wjl0GDKB5Gilu Sy6aHE4lrs+JoJN+lt/xA6oInGnRnaANHFZVe7kjROj70zu6PkxQ8LZPD2/Xjazx X-Gm-Gg: AfdE7ckmyuf+ahjZSRtYINmaT81Iu/PHZdouFgLpm1cddnGoYnDGU8XfTs3ni0dlnzs XqRTKq2mWLRSEo+DDsiL6oe54sAy0HBVc0ms9Ev4+H5ZZtWNztPT9hf9p/cWAama+Yx+wUw2S2t grpW81OmLH+pxkkqPMgJErJRWuAwxvvTAB+sM78TTek8jfVtk4EW07TO2+yQTyjZLi++1iVcitH UmoeBaL1AQdu/943tGd4AW1B+wDsmvOIvx7g+PflohbCTtJtBU0b64aovaoSwEFJbi6RU9B2Dhx Td361V8QewYca6jRmsswDyM6f0Bh9jNhPRu+Xp/8TVanQeno0tfXpU8F19mFOivk57nrWJLcX+X q57bCcLPObxc1uf+hxD+NmUHdtUYfjQ3xCebL6Cbu8HkI95FPXCm59q+dmvPHMDh+Yn74XaoP6n ORgnACVoLAwdgKr2YjmzOH8fRdIU7hJnMld5DiHw== X-Received: by 2002:a05:600c:4593:b0:493:eb71:5cc6 with SMTP id 5b1f17b1804b1-495483c0894mr14179665e9.27.1784240655072; Thu, 16 Jul 2026 15:24:15 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2edda2sm85045e9.13.2026.07.16.15.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 15:24:14 -0700 (PDT) Date: Fri, 17 Jul 2026 01:24:13 +0300 From: Michail Tatas To: gregkh@linuxfoundation.org, oneukum@suse.com, alexhenrie24@gmail.com, ae878000@gmail.com, mhun512@gmail.com, kees@kernel.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] USB: misc: uss720: Fix leak in get_1284_register Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline if wait_for_completion_timeout() times out in get_1284_register() then we do not destroy the reference acquired via kref_get() in submit_async_request. Add the missing kref_put in the timeout path. link: https://syzkaller.appspot.com/bug?extid=56962eb32ba0136cd330 Reported-by: syzbot+56962eb32ba0136cd330@syzkaller.appspotmail.com Signed-off-by: Michail Tatas --- drivers/usb/misc/uss720.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 1ce48f5832d7..bd0ad7c3261d 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -223,6 +223,7 @@ static int get_1284_register(struct parport *pp, unsigned char reg, unsigned cha } printk(KERN_WARNING "get_1284_register timeout\n"); kill_all_async_requests_priv(priv); + kref_put(&rq->ref_count, destroy_async); return -EIO; } -- 2.43.0