From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1358032AAAB for ; Thu, 16 Jul 2026 22:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784242324; cv=none; b=KMSMflBYnztbizdit09TcEiwP/++kZCP9x2D98kZsI5uykatyHrehP80/MzAyWkXJwADlGEYWpBqKeMRg+F+E8N8p4HIjvzIS/cnjBwXTe6QpWZ9vR0PxKdgW7oWuu4OEMlI4TLpS8AGV7NziAZoXKzuH0GOENmJaE8NTx+jeUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784242324; c=relaxed/simple; bh=G3M56D7Hw4JcKBHyy9MMshKRSmgzkT9M2iCh3vdgJp4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TNk3zZVJr8ai8bNhTNtMO3uCmpU/Fr0JjY7ktqhEYb4uxy5/xhc44ktvvYaIG2Mw5MCAaHdeeoOhggTGb0ML+8CkO4atC7N0LR0kxuhpsb0x/87UkUuZnjoqocIkBDrBsdzUBDFW7E9pG1sQ7aGrCSp+tqmFECKhyu8AT430DM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aC5IFl6N; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=MoAkMrWW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aC5IFl6N"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="MoAkMrWW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784242322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ObT2MLWggP0CPh3Zc10/u3DfAojIZjELn3oUv8rUGrk=; b=aC5IFl6NWRIGqNRu8kLKvYf8LavebWGzfzg6JL/iPFWupaVsfcS1ArwH5UXVmdGmwbdTNy 3yQqgnnH6A+jwL3P7eZottn8yhpz1g9gpRKim8aZFmylkNTLH3/l9WLCcr94O9tW8O2YJx xmhBBL/bWVf4NghVk48t9KEW0EtXKAo= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-RhOeufoRMNuxwEwKH3kpSg-1; Thu, 16 Jul 2026 18:50:35 -0400 X-MC-Unique: RhOeufoRMNuxwEwKH3kpSg-1 X-Mimecast-MFC-AGG-ID: RhOeufoRMNuxwEwKH3kpSg_1784242235 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-4a4a7d0362eso1969898b6e.0 for ; Thu, 16 Jul 2026 15:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784242234; x=1784847034; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ObT2MLWggP0CPh3Zc10/u3DfAojIZjELn3oUv8rUGrk=; b=MoAkMrWW/zrR7GEsNQsrhuw1AOQZH/xAvmEmhfJIVYg6NGHVqRe0GltzhX1fYohu4m ZydfJ6WklP394daSaVbx+8NbwIElvjeKtipY1Ph3GR8LUSzaaHQa1CrgOhFrN6SfPUIL 0oquS1YO8BDEz+54JYednjljbXOqvhLYOy7Bs7TCFoTyq6JZwwYA18gSQvRaBwu29rnr Ezt1i65sQuAvupnzE9wVpt5y870rZxJ16GJ454FXoyhBor+z1Wd+T3koUY8XhG/bZe9y BeQuFv/WnlhXyvXPa/CgfIrm8Ip3wc5eoMvBVZ66RI4Zs1HnBKtGE+z55oWiK8+Mqasa E3Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784242234; x=1784847034; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=ObT2MLWggP0CPh3Zc10/u3DfAojIZjELn3oUv8rUGrk=; b=fTL8ZyOZRv/NwtYAwJrWU1G0XBD9vuKKMz6F/Ip2LADT27y9Gvxjo7MKPDWdcK5kWC RPkoMbYnA4SdeVo8FPpeBpE5yZdHGr3EohHHK9eS81WITJerkqXYBYVeV+qP/oPrtpYW aCeOMinpQtQXi3C4Y26WoaJ5ujf5ORlpXcfk0wFuS4iB3CVDOEEQPB61cWlHWB1zAnzb ABlypU8OWZojGa4mCwkXWC/PK2ZeDwmEjyPlw+DMIhJM7mvBGjfcxJWr2IWDjUwIRHUt U/Y/sAkup/90fLDe+vMzztd0dqCV04U+wEtIkkQqxhDQUVx08HpxGlqYNEBA/7d4yijy XIMw== X-Forwarded-Encrypted: i=1; AHgh+RrUomVd/ooUnXpM7MNMvsUU07GyUVxpVkeKiec8xGVqfBzD3/KhkkpHVqselfPPhBCMmROWhAzj+B0lPKA=@vger.kernel.org X-Gm-Message-State: AOJu0YxYI0dJcF/a6UIn/ukfIXKHkEWmTUBjvP2cy2aHUP6NFqMSLiDn 6Dbw+3224Ev3nmdsM8Wknhi1m+j0ESFROCYMnlO2Z74I22kuYJhG1EvoFIy7yp76QicqS2uBjfk 7YLo9Ov/mdtYV/5AUd850sH9Ywa1HlchU0arSAToC/F6JrfmKnVcNsYrwJjsG+/dPBA== X-Gm-Gg: AfdE7cnrgqziOpT6PRMUNTM+VhnCc8O0RmzPFq5PfBbjJCSg/V8KdQ2slzH2JDdRQ5d aiYIoGbs0OR6wnq9GHTa0JiGjuI19b7c/x3Trj5dw/+YSOmlqxPQs3nw50Zh4O1Iy1v9JpxfMbi VuP3Ehm1kJqSBymBC+ndj+UfiLTtjpcKYVY/CiBCACh43kg3rdwUhgJlwwl6OnAY2tODSnhQTOT ImxsK1p3UO9uhmvZ7CBAThvtiK9PWwTLzQe53UwJilFWu3IzifMIjrhEXGbTSTgtYH49K0YI0uf BEHHsarrPOF6fcVE2nEByfHFRprjV5XHbI4Hpn1dgEn5Rmk51tFhaZxtgRaT2sX6aFwCvZkaIg= = X-Received: by 2002:a05:6808:1241:b0:497:d87b:6dc5 with SMTP id 5614622812f47-4a4c8854f45mr1054392b6e.40.1784242234620; Thu, 16 Jul 2026 15:50:34 -0700 (PDT) X-Received: by 2002:a05:6808:1241:b0:497:d87b:6dc5 with SMTP id 5614622812f47-4a4c8854f45mr1054368b6e.40.1784242234196; Thu, 16 Jul 2026 15:50:34 -0700 (PDT) Received: from redhat.com ([2600:382:8501:9a15:b085:521d:bf27:780]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4a1b01eefbbsm18780053b6e.13.2026.07.16.15.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 15:50:32 -0700 (PDT) Date: Thu, 16 Jul 2026 18:50:29 -0400 From: Brian Masney To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig_=28The_Capable_Hub=29?= Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] clk: qcom: Drop inclusions of Message-ID: References: <7b6441aa3b0dba35112ea486bfea3b3171d8527b.1784225976.git.ukleinek@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) On Thu, Jul 16, 2026 at 09:55:23PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > On Thu, Jul 16, 2026 at 03:15:55PM -0400, Brian Masney wrote: > > On Thu, Jul 16, 2026 at 08:21:05PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > > > The only used symbol in these four drivers that is provided by > > > is of_device_id and this is also provided by > > > . > > > > I don't see it defined in platform_device, unless I am missing > > something? > > > > It looks like the reason this compiles is because of this chain of > > includes: > > > > linux/clk-provider.h -> linux/of.h -> linux/device-id/of.h > > Well, the chain for is: > > > -> > -> > -> > > but the more relevant thing is: makes use of > struct of_device_id and most consumer of that header (typically platform > drivers) need struct of_device_id. So it's very sensible that > is enough to get that definition. The include > chain is just an implementation detail. > > > > So drop the unneeded include which brings us > > > one step closer to removing . > > > > > > Signed-off-by: Uwe Kleine-König (The Capable Hub) > > > > With an updated commit message: > > > > Reviewed-by: Brian Masney > > Does this discussion convince you that the commit log is ok as is? Yes, agreed. Thanks for the clarification. Brian