The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Peter Chen <peter.chen@oss.qualcomm.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy
Date: Fri, 17 Jul 2026 01:56:59 +0000	[thread overview]
Message-ID: <almJeSq1zfcC1mjj@vbox> (raw)
In-Reply-To: <almDYCfHf4WV-giY@hu-petche-lv.qualcomm.com>

On Thu, Jul 16, 2026, Peter Chen wrote:
> On 26-07-17 00:06:37, Thinh Nguyen wrote:
> > > 
> > > I have seen fewer platforms use "phy_type" at dts for arm64, dwc3
> > > core uses it only for special cases and the code was added for
> > > ten years ago. For the default situation, we may not need to
> > > change DWC3_GUSB2PHYCFG_EUSB2OPMODE value for UTMI+, Thinh, is it
> > > correct?
> > > 
> > 
> > The GUSB2PHYCFG.eUSB2OPMODE is only relevant for host mode and mainly
> > for electrical compliance. Usually by default, the CoreConsultant
> > setting should have this set correctly. So not explicitly setting it
> > should be functionally fine (IIRC).
> > 
> > That said, this is separate from the GUSB2PHYCFG.PHYIF, which the core
> > uses dwc->hsphy_mode to indicate whether the UTMI interface is 8-bit or
> > 16-bit.
> > 
> 
> Why only rockchip uses this "phy_type" property, why other SoC vendors
> no this requirement for UTMI width setting? 
> 

Not just rockchip, some tegra and hikey also use it. Some old qcom dts
files also have it for ulpi.

It is typically set when the coreConsultant default differs from what
the platform needs, so the driver can override it with the correct
setting.

My point is that changing "phy_type" definition is more involved than it
looks. I'm open to alternatives.

Thanks,
Thinh

  reply	other threads:[~2026-07-17  1:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  8:52 [PATCH v4 0/2] Modify interrupt handling for eUSB2 Phy targets Krishna Kurapati
2026-07-09  8:52 ` [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy Krishna Kurapati
2026-07-09 13:47   ` Dmitry Baryshkov
2026-07-10  1:52     ` Thinh Nguyen
2026-07-10  7:16       ` Krzysztof Kozlowski
2026-07-10  7:19         ` Krzysztof Kozlowski
2026-07-10 21:02           ` Thinh Nguyen
2026-07-13  6:26             ` Krzysztof Kozlowski
2026-07-13  7:20               ` Peter Chen
2026-07-13 23:41                 ` Thinh Nguyen
2026-07-14  3:20                   ` Peter Chen
2026-07-14 23:23                     ` Thinh Nguyen
2026-07-15  3:37                       ` Peter Chen
2026-07-16  0:09                         ` Thinh Nguyen
2026-07-16  2:35                           ` Peter Chen
2026-07-16 23:53                             ` Thinh Nguyen
2026-07-15  5:38                       ` Krishna Kurapati
2026-07-15 23:19                         ` Thinh Nguyen
2026-07-16  4:12                           ` Krishna Kurapati
2026-07-16 10:37                             ` Peter Chen
2026-07-17  0:06                               ` Thinh Nguyen
2026-07-17  1:20                                 ` Peter Chen
2026-07-17  1:56                                   ` Thinh Nguyen [this message]
2026-07-17  3:42                                     ` Peter Chen
2026-07-17  4:01                                       ` Krishna Kurapati
2026-07-14  0:41               ` Thinh Nguyen
2026-07-09  8:52 ` [PATCH v4 2/2] usb: dwc3: qcom: Modify interrupt handling for eUSB2 Phy targets Krishna Kurapati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=almJeSq1zfcC1mjj@vbox \
    --to=thinh.nguyen@synopsys.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@oss.qualcomm.com \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox