From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0F3A3A9D84 for ; Fri, 17 Jul 2026 05:51:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784267507; cv=none; b=ANGWWnJX4C8woWb9oi+4/C4sje/7h3MBJ0AhnuQfE6iVnNSgEWmZBHBnZigdITL83Q8lstXkA1rz5jqPa2mDNlchcDQ11rejQfEdPUo/yNJWyeUrWBsnyqS/GRF5HGYPaOFdGnihOLo7CphxGq4Iu0iWqHh+/GS7dIMRtW4wui4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784267507; c=relaxed/simple; bh=1EFfARZqTYougMDxqJVwrAAU6s5k6TPIb1KJJancNeA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KEe9wpJMqlghDw5Y9TKQZXGK50bTZSV2WYMag38XMy7H+5o4XAU3tCaTFbNLgG4MFqt7M9h2i+ml7MyfmOQ2ihQPEtHw66Tem+diqnbV82HqpUPDLdmFXHfdl6/yn47ODZH1xXrSJ1xP5Iq4nOcHNqgHaAVT/+bUTOEAa+fQL4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JMbT5/6M; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JMbT5/6M" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7e9f69ee6f4so3115353a34.2 for ; Thu, 16 Jul 2026 22:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784267501; x=1784872301; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7GNJ2VsT/H/OoPywtw6dAhOceHxaw517jB295gP2NHc=; b=JMbT5/6MSRxsbUAqcv/WmmJvt/PZky0MEYp7ofDy2bEU+miaLnSDA3pJoDAxHMNVNJ KcF4kcfVI2+AJhBEQW6vEOfzJnzL/WdLFi/rr0BkUokwEcmi7fOKeLF7wE4G/Xvt7yhF Lgi1CUHGnspTAAONdhTi5PCu2L9jtnpDmJiJwyETCpBJ6llFBGWibW7lIcXwLc4F/I+8 HD22HCoclZ1hpHSnANabTnDeN9IGrpyISkYqI+wRwirkq6i+auKRwHis38pApPnuI2FK giu4iT1EP0jV8ltsADVnoOYxVWMRxCx2/H2p7vUiQLueuG2Mf+bUztqm+q5/Mt2WRlvY 9EZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784267501; x=1784872301; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7GNJ2VsT/H/OoPywtw6dAhOceHxaw517jB295gP2NHc=; b=qXa9+p9+SxjOE/fKa/yuinHmo8xA7vBiKnGiUbEEEAb/7xa0mp8KAnOgVhMB6pe0F8 WEadrVGVOCKFAVpbwucyR4BXv1yFJ+CLwj7tYUw0JBX6rA3ngn6Xtj5gHq1aA1Js+0oW 7vwD4H0ghKQZR+vr0VAD90YI1M1+AiCCibzPcoM7NkJ++2cY6Ute2WrF5XUJX5BZ4soA /PUHSqZUtPFH1lTwF32+nSZDUOd7fbF0PyV9ypr4ysBoqP4lF0VSswTItZI1LYXG/ziW bN/xmmXXJwOvoz5wIOFhlFqDPjstnOLvii8U1BPMLsABulz7Mr8JRBg25bphjEdg+iH6 +Z5Q== X-Forwarded-Encrypted: i=1; AHgh+RqM3YuZWLH0E1AApKZS5AFG9soYcG986dpl4LNhQQJJu+o5NLnOg0vv9BaiTQUXSDcusUIhacpTXO5LPus=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4eDA/XMFhohJdQvXnm/5hevHRUGCIeeXW09XyeCl2vtAFcuyZ PIdCu3ZgUv6N13qOrnCeDVdKs438c6YHQxrXjZayhu+XnJILIQ3+a8PwOjON1a125mQ= X-Gm-Gg: AfdE7clnYDZnk6vvc3xv+AnbwXa35No/WZM3AmH7ESpWqFnRYX3CFKzEuXg1qubiKrP iti0sP4/CQphzaaakeHg/YukIf2inOxjURDniCOJFS8WsS3iaI/8eNzEmdr4JR1/RZjEMTGeCFk maOcBHZWbJnhTzSo2zMpI6zOKYXu8wr+V7ThFC/n4acQQ4JTWNeaid25Yi36fXjsN6mKjMi+i07 dID80wvfebYSR+BUU1IOhsD7BYOoyTY3SwT3GfUiNGPY1czCMqMGSt7dvwSvsu9/IK7lTUtvQ4q L6g+O8uqrqB4+hC5tkylwDijezcZeGNGdkGexX25tnC26YVcOnFQbIWC0f/ivhNRm4tFuZPX9/k UOL87/Oa2wD8vwMeW70tCZDrtb+nC5KsOdcbfKmGKQQhWQk+IoJ2RzdDmZmH/2FMCPteEjA== X-Received: by 2002:a05:6808:308c:b0:4a4:c12:46f6 with SMTP id 5614622812f47-4a4d01f55ebmr585102b6e.2.1784267501599; Thu, 16 Jul 2026 22:51:41 -0700 (PDT) Received: from localhost ([74.80.182.90]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4a4d3cb035csm167035b6e.11.2026.07.16.22.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 22:51:39 -0700 (PDT) Date: Fri, 17 Jul 2026 08:51:32 +0300 From: Dan Carpenter To: Alfie Varghese Cc: neil.armstrong@linaro.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, dan.carpenter@linaro.org Subject: Re: [PATCH v3] staging: media: meson: vdec: propagate devm_clk_get() errors Message-ID: References: <20260717030559.167-1-alfievarghese22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717030559.167-1-alfievarghese22@gmail.com> On Fri, Jul 17, 2026 at 08:35:58AM +0530, Alfie Varghese wrote: > vdec_probe() hardcodes -EPROBE_DEFER for all devm_clk_get() failures. > This masks the actual error code returned by the clock framework, such > as -ENOENT when a clock is not registered or -ENOMEM on allocation > failure. > > Return PTR_ERR() instead to propagate the real error to the caller. > > Reviewed-by: Dan Carpenter > Signed-off-by: Alfie Varghese > --- There is supposed to be a note here under the --- cut off line which says what changed. Did you resend just to add my Reviewed-by line? No need for that. regards, dan carpenter