From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A295F306741 for ; Fri, 17 Jul 2026 14:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784298665; cv=none; b=NPsh317KagXptjtir+JV8QAHi8GShkmq4cyDXf2ffhN6T0HFsI8S61pJIFok6wYqNE6e0kqxWsNWjYGzeGdon/0d5IxZdFXaLv3ZvYjdOO+sn/4U5qNq0KPDx/xu8/NTVvDVb4ICiy56F3CmJswkz6ZTGPqfzrrjj9OGtE+0Uyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784298665; c=relaxed/simple; bh=4lX2KTzLDxqkajLOI2x4b8RcuUBUe0pdPMW9ATeAUss=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wzu/aK4Up9rJ+0J0OlR3Og38i06r3DpiaPCduPVgj83ba3GrPj2Oa0bRfVzDCyATeD7DFWxWk4l6yLSqZi2v5vsRQ6OJugWUgwwrimqs+kg9fqkdCbcWSbABy2vZR272ztFLkFOYOzn2jdYgu/9/HpJUzwPuE2vKNHi6Glk4FUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KOkXY4OW; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jZENB3Yh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KOkXY4OW"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jZENB3Yh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784298662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uiFJW7yDa7Q593qaNVa5df8mhuriHuxHGUsJACa+pQU=; b=KOkXY4OWrh1zf/ztQhTemXhenJpzzCQEu6Ps4OvR/leHntWkoR5CVdrDLOWK67DeBTzzi0 R5cdX5pVE+WnesWMTjAs/czt8jKCbNoukh5+TK8bf6o9mEsB0SWdXLL1mrZeIsOvWSebs8 Xmvvvlz6xA8fTeg80m07Ve9fubU0WSg= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-4621A7EgOxWuQYfdy5_Kww-1; Fri, 17 Jul 2026 10:31:00 -0400 X-MC-Unique: 4621A7EgOxWuQYfdy5_Kww-1 X-Mimecast-MFC-AGG-ID: 4621A7EgOxWuQYfdy5_Kww_1784298659 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51e4ba1cfabso72423711cf.1 for ; Fri, 17 Jul 2026 07:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784298659; x=1784903459; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=uiFJW7yDa7Q593qaNVa5df8mhuriHuxHGUsJACa+pQU=; b=jZENB3YhDLnKOhRpRgnMu96d51TZ1oqxBUyNQ7mLSbywmtywEUnt9vxL9Tz6HYL9vE jTGWgmsUOGJWDJO+fcGU7EVK8eZkfVz1jCKWyVLytKlc4r9Y7vhzvdVu2xqVem34n+Mv kxxNnk9+S1PygbAvpbk5ltDORFQ9Tvctp6e3INCk9AGiG5gLtOjBbKooQdiCdLPEgbBB ZrKLoskTYGlXwjFhmHFw2bP3eIWZft9XvyehM6eVWIXcWIsvuUNwpZibXZqTwX39apVk EoJ664Tk7SlSk0yr1vjc4pmFkE8jNJqfxR8pZ4vazkH/bG60cnORJFUT8k8Ci4Wb8fqB kZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784298659; x=1784903459; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uiFJW7yDa7Q593qaNVa5df8mhuriHuxHGUsJACa+pQU=; b=DIxAnDGQpANiN1zloCui1YuXiMN6t9Ngm3iyneSGLnIv6nhGBFYhV2hVK9WVTROVvf Zaq4KrPLaFgdM+NcJ9jboE8+N8QQYPurmQL3jarqiLl15p6EJIB2mow3bjQnhiU7dW1w zhhu48r2D23WhCHaOKvsOhL/AMo7u+hOfabzPAMZg+INJBdTa55ROGSUaz++4ZMi3IXu R9KxEatBITIuPt4kNY+QpvryXztkyMk70hJy/QhIsJ4qB+nfCxdeZB5AQKgS4Hy1iV1Y ZhPvyM4ULjhuUrzA1G0nY+M7Kt7jm6qU7knkv8uoNjHJA3z+dTnoKRK1tdOIpz9gYu2Q Udjg== X-Forwarded-Encrypted: i=1; AHgh+Rr44mHDp12e+BaEeYeoqOSF6JeJBb++0YywNPA05Q3DK9gq+RVdYV6/P78KRb0bZfR5SzTBpLe0WDMzH/U=@vger.kernel.org X-Gm-Message-State: AOJu0YxlJ+xlU4V9NU84dQyxIqZ3pzzXICHwN+lu1Yxnn14Seh4R8Diu PFMG0rwPNlZQAWhCzyHJOF7lg57k/X4K6c02hkEHptdRS0KibxBXinXN9G257Nba6+Jcs7jFUXK WSTC/niBie6W5TaVmZvREmFEYATmNcSDo8ytCf2nyLfuFAegSRTlGW1poPsuXKFfDaw== X-Gm-Gg: AfdE7ck9N3snBSofD66ku+TqT4D45wN45PxuS4lrTXuwbiJjCSEjlEy7/na6Z2B8l9K ZUpOHfHxOuCopt8qtx+KHVLRqpxTa8eF42kzsn+RnKN5hiMtmnlluFUXcplB3oqNQij+5A6x2BV gH9Q259Oy45g/b+gxtClcip7iKSQfdKMTIIg0aKBOW7vvCgH7gV/+6s4yR4Dx1vOs53yeYQsyhi SJNm9RLJytMtJgS+dXbvX+1h1oT09JcsgMTfNPAuqXgppidpcaMjn9JJQjEKjqg15Mmm2keRPBJ tyf4P0QxrH50nzniR7XKl/fIKvUef7TTBeAXVsFUvaCCvZu1aya34HetzlQs8/ATsm9vOQgW4CF LK92v6Sn8Vfwsa4x9n2GtBCw/Mj5j5cquDL8= X-Received: by 2002:ac8:59d4:0:b0:51b:ff45:bc82 with SMTP id d75a77b69052e-5213daa1d49mr25658971cf.54.1784298659455; Fri, 17 Jul 2026 07:30:59 -0700 (PDT) X-Received: by 2002:ac8:59d4:0:b0:51b:ff45:bc82 with SMTP id d75a77b69052e-5213daa1d49mr25658361cf.54.1784298658914; Fri, 17 Jul 2026 07:30:58 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52149a3ce4fsm13091681cf.0.2026.07.17.07.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 07:30:57 -0700 (PDT) Date: Fri, 17 Jul 2026 10:30:55 -0400 From: Brian Masney To: Joakim Zhang Cc: "mturquette@baylibre.com" , "sboyd@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , cix-kernel-upstream , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v9 2/4] clk: cix: add sky1 audss clock controller Message-ID: References: <20260709120125.3997078-1-joakim.zhang@cixtech.com> <20260709120125.3997078-3-joakim.zhang@cixtech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) On Fri, Jul 17, 2026 at 09:47:28AM +0000, Joakim Zhang wrote: > > -----Original Message----- > > > +static void sky1_audss_clk_remove(struct platform_device *pdev) { > > > + struct device *dev = &pdev->dev; > > > + > > > + if (!pm_runtime_status_suspended(dev)) > > > + pm_runtime_force_suspend(dev); > > > + > > > + pm_runtime_disable(dev); > > > > I am fairly certain that remove() is called before the devm handlers are > > invoked. The clocks will be shutdown, but there's a window where they are still > > visible to consumers. I think you should use > > devm_add_action_or_reset() so that the cleanup is called in the expected order. > Agreed. remove() runs before devres_release_all(), so force_suspend() tears down the hardware while the OF clock provider is still visible. I'll move the runtime PM cleanup into a devm_add_action_or_reset() registered before the clocks/provider, and drop it from remove(). I don't know which email client you are using but you should fix your client so that the text in your response wraps at 80 characters. Also add a newline between what you are quoting and your response since it also makes things much nicer to read in the archive. Brian