From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E57391A682F; Fri, 17 Jul 2026 10:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784283997; cv=none; b=pkJvcMAa3jETXke3596J4X5PX20344poyx1esBPlbz3dFQZZrW8Fl9f+EF72RZFOnGkbdAS6bwBbs83yFc6Y5mKwdbuA+WFIIWzeUN+VgDrRpkX+BId+gS0CqGnsNW6neaxzc9QhRULdLdhMRqmGoBodPM+3ti3zjb5RAj4MRAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784283997; c=relaxed/simple; bh=9atBOl1AG8HvPml8uEmb3RXO+SfWug7dQXlwgTdy1y8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UW3G4sgNilUHXQl7nbDBM8Va+6k6zBO10t3tLT009guWtVOq1qPtfZ3r/7RMLwxishzVf0EMwbioKyolBaIFlvyIjv6ilBDmTd08/3xz7iAZV9ioqj6LqdGoHDEwnYFK6aexmdHXwQ4FGIXhm20zyxmpZQKfRJZVmb4ZbjE4pu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R45yG70Y; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R45yG70Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E887D1F00A3A; Fri, 17 Jul 2026 10:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784283991; bh=+YSfAKgM2w/3xu7Y8tnkTdPUEG+bk25x/oAms4+Y9dw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=R45yG70YJot27EDj5bcL/rFfET2VCF1PAthIqhk2cqGL1iyj1nVTk1o11QYJOy6RT WqjnD6fayREqmHYHv2tvbAkc5dd4c0EkZ7DoxR2n2nn56dDPEdMDx7UK/D2xfKI8My btvaKW/BCI5kS8Cbbz6YLR1yGt26I/89qVvGOXWlBgmAS8OTZgJfKvy4v4Y0gv/HJM cO61aKFZ8caugC1+fW5HFRrZ0SwS5RNFJlfmxn5r8VozaRz8tLngFl8VnhMjEc+MMV 7hCSd5zYGwfIzApIjoVsgKA6czwih2QKMwby2IVmSmmLhPiuSTB77dotlVe5loiLLf 6bR/0lKx2vNhg== Date: Fri, 17 Jul 2026 12:26:27 +0200 From: Ingo Molnar To: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= Cc: Borislav Petkov , linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org, x86@kernel.org Subject: Re: [tip: x86/msr] x86/cpu: Stop using 32-bit MSR interfaces Message-ID: References: <20260629060526.3638272-20-jgross@suse.com> <178298735495.3843924.289690164073708304.tip-bot2@tip-bot2> <20260703214821.GHakguJTquox_L1X_E@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: * Jürgen Groß wrote: > On 17.07.26 11:36, Ingo Molnar wrote: > > > > * Borislav Petkov wrote: > > > > > On Thu, Jul 02, 2026 at 10:15:54AM -0000, tip-bot2 for Juergen Gross wrote: > > > > diff --git a/arch/x86/kernel/cpu/transmeta.c b/arch/x86/kernel/cpu/transmeta.c > > > > index 1fdcd69..c670fbb 100644 > > > > --- a/arch/x86/kernel/cpu/transmeta.c > > > > +++ b/arch/x86/kernel/cpu/transmeta.c > > > > @@ -24,7 +24,8 @@ static void early_init_transmeta(struct cpuinfo_x86 *c) > > > > static void init_transmeta(struct cpuinfo_x86 *c) > > > > { > > > > - unsigned int cap_mask, uk, max, dummy; > > > > + u64 msr; > > > > + unsigned int max, dummy; > > > > unsigned int cms_rev1, cms_rev2; > > > > unsigned int cpu_rev, cpu_freq = 0, cpu_flags, new_cpu_rev; > > > > char cpu_info[65]; > > > > > > The tip-tree preferred ordering of variable declarations at the > > > beginning of a function is reverse fir tree order:: > > > > While that's true, the style violation is a pre-existing condition > > in the current code: > > > > unsigned int cap_mask, uk, max, dummy; > > unsigned int cms_rev1, cms_rev2; > > unsigned int cpu_rev, cpu_freq = 0, cpu_flags, new_cpu_rev; > > char cpu_info[65]; > > > > ... and the best policy regarding API conversion patches like this > > is to keep the original style, to not mix several changes together, > > which only makes review harder. > > > > But I agree with fixing the style problems of course, but it should > > be done either in a preparatory patch, or in a followup patch. Either > > ordering is fine to me. > > I'll send a followup patch. Thank you! Ingo