From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C25360EFF for ; Fri, 17 Jul 2026 18:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784314061; cv=none; b=M23sT5bK5opEiBFxYrALWq8iLSUhmFXCwxWeZoSRcuV22Uoz50hyIsMCfpgwxO+LTySjh+oWLAgbRGV0p6HyCz2K0DB5m75Ef9Re1KxQedeaykhQnGjvlzb6uR28Do2NId29/tijP3S8aERUOUOqydy5zaNrrCLokRZ6e401st8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784314061; c=relaxed/simple; bh=1gLf0grI1F4aEqV5nJ31Dnp/DFpJ22ayvKcGc5JNpTo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AeTvtPWq7GUnlT3rw6Ze7zIAujiqelM03ez9hyZyKcLk5TSUZNfq6hWPt/dmu+YZxyAvhzWTcGgw8hTaCFhvkLKyqZqo3c3iukb1c5zCDJftuS+YJXpknld3rpap84nVA/xUvM93fVyNDSLo6QWe7yI3JK5f55vwnDvoQhLicXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NVt6xfzI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NVt6xfzI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784314059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yUeLqfN2j1oB2MnjjL/LYb0sz/3GEuAWUl8u9/2q4Qg=; b=NVt6xfzIncz6LLdj4m4GCobQyHUWgODOZTyUuRj3YyEW46D3zv75mBN4Ts0SqcO+Nua0hk P86Awj4FuMFZ5g5+T4BVQ9K72wr/VA/u3ASRlBLFKFt49Z3G07us1ebtjXtH+MZJjMWu0E HmrFvqXhtL6lPviIbRViOOgz8UszNBA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-uC1irEO2MSSdc0hTf3nDcw-1; Fri, 17 Jul 2026 14:47:33 -0400 X-MC-Unique: uC1irEO2MSSdc0hTf3nDcw-1 X-Mimecast-MFC-AGG-ID: uC1irEO2MSSdc0hTf3nDcw_1784314051 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 41A57194510C; Fri, 17 Jul 2026 18:47:30 +0000 (UTC) Received: from fedora (unknown [10.44.49.164]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 2C9F2D72; Fri, 17 Jul 2026 18:47:22 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 17 Jul 2026 20:47:29 +0200 (CEST) Date: Fri, 17 Jul 2026 20:47:21 +0200 From: Oleg Nesterov To: Richard Chang Cc: Andrew Morton , Kairui Song , Qi Zheng , Shakeel Butt , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Johannes Weiner , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , Suren Baghdasaryan , "T . J . Mercier" , Martin Liu , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH v3] mm: vmscan: abort proactive reclaim early when freezing for suspend Message-ID: References: <20260717181252.2277818-1-richardycc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717181252.2277818-1-richardycc@google.com> X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 On 07/17, Richard Chang wrote: > > v3: Return -ERESTARTSYS instead of -EINTR in user_proactive_reclaim Yes, this change LGTM, but ... > + /* > + * Return -ERESTARTSYS to allow the freezer to interrupt the > + * task. The syscall will be transparently restarted upon > + * resume. Real signals (e.g. SIGINT) will be automatically > + * converted to -EINTR by the signal layer. > + */ ... the comment looks a bit misleading... So, if the signal is "real" and has a handler, handle_signal() does case -ERESTARTSYS: if (!(ksig->ka.sa.sa_flags & SA_RESTART)) { regs->ax = -EINTR; break; } fallthrough; case -ERESTARTNOINTR: regs->ax = regs->orig_ax; regs->ip -= 2; break; If SA_RESTART is set, the syscall will be restarted after return from signal handler. Oleg.