From: Johan Hovold <johan@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Dmitry Baryshkov <lumag@kernel.org>
Subject: Re: [PATCH] drm/bridge: display-connector: fix i2c adapter leak on probe failure
Date: Fri, 17 Jul 2026 16:51:52 +0200 [thread overview]
Message-ID: <alpBiFzfbaTXae8l@hovoldconsulting.com> (raw)
In-Reply-To: <20260717122035.GB1926197@killaraus.ideasonboard.com>
On Fri, Jul 17, 2026 at 03:20:35PM +0300, Laurent Pinchart wrote:
> On Fri, Jul 17, 2026 at 10:57:16AM +0200, Johan Hovold wrote:
> > Make sure to drop the i2c adapter device and module references on failed
> > regulator and enable gpio lookup (and regulator enable) during probe
> > (e.g. on probe deferral).
> >
> > Note that of_get_i2c_adapter_by_node() does not return error pointers,
> > but i2c_put_adapter() can handle a NULL argument so the error pointer
> > check at remove works even if it is misleading.
>
> I've already sent a fix for this, see
>
> https://lore.kernel.org/dri-devel/20260705213542.28987-3-laurent.pinchart+renesas@ideasonboard.com/
Ah, ok. If that series is blocked perhaps you can send the fix
separately.
Johan
prev parent reply other threads:[~2026-07-17 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 8:57 [PATCH] drm/bridge: display-connector: fix i2c adapter leak on probe failure Johan Hovold
2026-07-17 12:20 ` Laurent Pinchart
2026-07-17 14:51 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpBiFzfbaTXae8l@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox