From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EA0327BF79 for ; Fri, 17 Jul 2026 16:38:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784306321; cv=none; b=ES6xRJbmOQRc+GgjZohzqvqlhTkLgTFQyzuQ6bhUpy3FVtL9+7BriUr6mwPy9R+K2wAyejqrni+O/2pYRQIxQ9ipocFXzOVc0a9FA+/0H+Oix5ZaGx0MmgU1CPgi7ZfITFw3vHlcXS2jDYiT7I/LfR3RZA4ZrGxR5E4dqdyOaCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784306321; c=relaxed/simple; bh=dEXvuzGSxLmTI7Vgq/eKtDXyhieXCI3ay5YEMlXbebc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TcEvQEkLXhUug/dX7IiTWx+xUkwc2WCNlO6ShPUQBR68E2FIHzJVf02N6ox1lwjDZ9WvQqo32Cpu/t5O6QP17xaU8G0Bm6tg6ygHe6p9Kc1fhomZFe9yAEeWUEUH+dj2h5XvQOWcPYU/khu86Sc85SdvLzDquJn9hRvbZLD8L/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=EWn4IokM; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="EWn4IokM" Date: Fri, 17 Jul 2026 09:38:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784306317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l2bUPeN9u+ttge/nHvtSSgPHXdHk+Xta8t/IGxUaYIc=; b=EWn4IokMQWON7TfL2bBkP/KEvJpjG+Tc4pP6bSaD5OdwPQZoETIVDc8OFi8JjWgImqcro0 Hv/DNoXvaXve9+3uXGZlwvQktlvLzsFStqQFnIPCcKthAmk0+YY4XD7Yh/fwZZYpdLFXwh N4I5y+5tOYM+abPDTKz/kNpdZ6/k+cw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Ridong Cc: Andrew Morton , Johannes Weiner , Kairui Song , Qi Zheng , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , Zhongkun He , Muchun Song , Davidlohr Bueso , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Subject: Re: [PATCH 2/3] mm: vmscan: propagate real error code from per-node proactive reclaim Message-ID: References: <20260717113300.214717-1-ridong.chen@linux.dev> <20260717113300.214717-3-ridong.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717113300.214717-3-ridong.chen@linux.dev> X-Migadu-Flow: FLOW_OUT On Fri, Jul 17, 2026 at 07:32:59PM +0800, Ridong wrote: > From: Ridong Chen > > It has been observed that per-node proactive reclaim always returns > -EAGAIN when any error occurs. As discussed in the mailing list [1], > the interface should distinguish between cases where no reclaimable > memory is left and where another entity is concurrently using the > same interface. Propagate the real error code, consistent with how > memcg proactive reclaim handles errors. > > [1] https://lore.kernel.org/all/20250717235604.2atyx2aobwowpge3@offworld/T/#m3514718be82a31b05726a49da9b61fbfc69a589e > > Fixes: b980077899ea ("mm: introduce per-node proactive reclaim interface") > Signed-off-by: Ridong Chen Acked-by: Shakeel Butt