From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Michal Marek <mmarek@suse.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: any value in running my kernel scanning scripts before release?
Date: Thu, 15 Jul 2010 18:50:20 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1007151845490.11593@lynx> (raw)
In-Reply-To: <4C3F0D1B.9060403@suse.cz>
On Thu, 15 Jul 2010, Michal Marek wrote:
> On 07/15/2010 01:32 PM, Robert P. J. Day wrote:
> >
> > normally i wait for the merge window, then run my kernel scanning
> > scripts and post results. any interest in me doing that earlier? i
> > just did a quick test and found a number of incongruities like, for
> > example:
> >
> > $ grep -r "config QT2160" *
> > drivers/input/keyboard/Kconfig:config QT2160
> > $
> >
> > $ grep -r KEYBOARD_QT2160 *
> > drivers/input/keyboard/Makefile:obj-$(CONFIG_KEYBOARD_QT2160) += qt2160.o
> > $
>
> These are plain bugs, so it's IMO OK to send fixes for these at any
> time before the final release. In the worst case, it will be merged
> after the final release.
i wasn't suggesting that was the only example, only that it was an
obvious one. there are others. just for fun, here's the entire list
of references specifically from *Makefiles* to Kconfig variables that
don't exist (for whatever reason):
===== ATHEROS_AR71XX =====
./drivers/net/wireless/ath/ath9k/Makefile:ath9k-$(CONFIG_ATHEROS_AR71XX) += ahb.o
===== KEYBOARD_QT2160 =====
./drivers/input/keyboard/Makefile:obj-$(CONFIG_KEYBOARD_QT2160) += qt2160.o
===== PCMCIA_IOCTL =====
./drivers/pcmcia/Makefile:pcmcia-$(CONFIG_PCMCIA_IOCTL) += pcmcia_ioctl.o
===== USB_ETH_FUNCTIONFS =====
./drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_ETH_FUNCTIONFS) += g_eth_ffs.o
in other words, none of that content is ever going to get compiled.
mercifully, there are only four examples of that left in the tree.
used to be a lot more. clean up whatever catches your eye.
rday
p.s. i cc'ed greg kh since i suspect he'll want to do something about
that last one. i need sleep.
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Top-notch, inexpensive online Linux/OSS/kernel courses
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2010-07-15 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 11:32 any value in running my kernel scanning scripts before release? Robert P. J. Day
2010-07-15 13:28 ` Michal Marek
2010-07-15 22:50 ` Robert P. J. Day [this message]
2010-07-16 3:00 ` Greg KH
2010-07-16 8:27 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1007151845490.11593@lynx \
--to=rpjday@crashcourse.ca \
--cc=greg@kroah.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox