Re: [PATCH] Documentation/CodingStyle: Mention multi-line macros using expressions

["Robert P. J. Day" <rpjday@crashcourse.ca>]

On Wed, 11 Jul 2012, Joe Perches wrote:

> On Wed, 2012-07-11 at 13:32 -0400, Robert P. J. Day wrote:
> []
> > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
> []
> > +A newer technique is to use the GCC extension of being able to place
> > +statements and declarations in an expression, as with this example from
> > +the <linux/kernel.h> header file:
> > +
> > +#define roundup(x, y) (				\
> > +{						\
> > +        const typeof(y) __y = y;		\
> > +        (((x) + (__y - 1)) / __y) * __y;	\
> > +}						\
> > +)
>
> Hi Robert.
>
> How about the phrase "GCC's statement expression extension"
> or maybe give a link like:
> http://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html

  ok, i'll do that later today.

> Please put the opening ({ and closing )} on a single line.
> It's shorter and makes grep easier.
>
> #define statement_expression(args)		\
> ({						\
> 	etc					\
> })

  i was simply transcribing what was in kernel.h verbatim, but i'll
tuck it together for brevity.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================