Re: coccinelle and bitmask arithmetic

Joe Perches
2013-01-30T08:29:26Z

On Wed, 2013-01-30 at 09:21 +0100, walter harms wrote:
> Am 29.01.2013 19:03, schrieb Joe Perches:
> > On Tue, 2013-01-29 at 18:49 +0100, Julia Lawall wrote:
> >> How about the following (from today's linux-next). They appear to be
> >> trying to do the same calculation, once with + and once with |.
> >
> > (cc'ing the original developer and Russell King)
> >
> > Likely the it8152_pci_platform_notify uses should use +
> >
> >> arch/arm/common/it8152.c
> >>
> >> int dma_set_coherent_mask(struct device *dev, u64 mask)
> >> {
> >> if (mask >= PHYS_OFFSET + SZ_64M - 1)
> >> return 0;
> >>
> >> return -EIO;
> >> }
> >>
>
> Great hit Joe :)

Julia and the others in the coccinelle group are the ones
with the whizzy program.