Re: [PATCH 1/7] PCI: tegra: replace devm_request_and_ioremap by devm_ioremap_resource

Thierry Reding
2013-08-19T12:12:57Z

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

On Mon, Aug 19, 2013 at 02:07:54PM +0200, Julia Lawall wrote:
>
>
> On Mon, 19 Aug 2013, Thierry Reding wrote:
>
> > On Mon, Aug 19, 2013 at 01:20:35PM +0200, Julia Lawall wrote:
> > > From: Julia Lawall <Julia.Lawall@lip6.fr>
> > >
> > > Use devm_ioremap_resource instead of devm_request_and_ioremap.
> > >
> > > This was done using the semantic patch
> > > scripts/coccinelle/api/devm_ioremap_resource.cocci
> > >
> > > Error-handling code was manually removed from the associated calls to
> > > platform_get_resource.
> > >
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> > >
> > > ---
> > > The first block of modified code is followed by a call to
> > > devm_request_mem_region for pcie->cs with no associated ioremap. Should
> > > ioremap be used in this case as well?
> >
> > No. The pcie->cs resource is 256 MiB so it's challenging to map it at
> > once. Furthermore it requires a non-linear mapping so we do it on
> > demand.
>
> OK, thanks for the explanation. Is the comment, though, a little
> misleading, since the mapping is not done here?
>
> /* request and remap configuration space */

Yes, that's misleading. Given that it doesn't really add anything useful
information either, perhaps I should just remove it.

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]