From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755995AbaCROwd (ORCPT <rfc822;w@1wt.eu>);
	Tue, 18 Mar 2014 10:52:33 -0400
Received: from mail-bl2on0087.outbound.protection.outlook.com ([65.55.169.87]:21016
	"EHLO na01-bl2-obe.outbound.protection.outlook.com"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1752264AbaCROwa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 18 Mar 2014 10:52:30 -0400
X-Greylist: delayed 869 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 Mar 2014 10:52:30 EDT
Date: Tue, 18 Mar 2014 09:37:52 -0500
From: Brian Austin <brian.austin@cirrus.com>
X-X-Sender: heelrod@heelrod
To: Mark Brown <broonie@kernel.org>
CC: Nicolin Chen <Guangyu.Chen@freescale.com>, <brian.austin@cirrus.com>,
        <Paul.Handrigan@cirrus.com>, <robh+dt@kernel.org>,
        <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <rob@landley.net>, <lgirdwood@gmail.com>, <grant.likely@linaro.org>,
        <devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        <lars@metafoo.de>
Subject: Re: [PATCH v3] ASoC: cs42888: Add codec driver support
In-Reply-To: <20140318131033.GC11706@sirena.org.uk>
Message-ID: <alpine.DEB.2.02.1403180936200.14838@heelrod>
References: <1394538091-19513-1-git-send-email-Guangyu.Chen@freescale.com>
 <20140318131033.GC11706@sirena.org.uk>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"; format=flowed
X-EOPAttributedMessage: 0
X-Forefront-Antispam-Report: CIP:141.131.3.20;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009001)(6009001)(458001)(24454002)(51704005)(199002)(189002)(54316002)(47446002)(74502001)(33716001)(81686001)(81816001)(74876001)(83506001)(80022001)(44976005)(83322001)(76482001)(74662001)(50466002)(6806004)(74366001)(85306002)(95666003)(80976001)(65816001)(20776003)(47776003)(31966008)(63696002)(87936001)(74706001)(77096001)(76786001)(76796001)(53806001)(54356001)(92726001)(81342001)(46102001)(93136001)(87266001)(23726002)(97336001)(92566001)(81542001)(94316002)(77982001)(59766001)(94946001)(69226001)(93516002)(56776001)(79102001)(86362001)(4396001)(49866001)(56816005)(47736001)(50986001)(83072002)(47976001)(51856001)(95416001)(97186001)(90146001)(85852003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB059;H:mail1.cirrus.com;FPR:EC45EDA2.2F1C5CFD.3FF77E74.34700FF9.200F5;MLV:sfv;PTR:mail1.cirrus.com;A:1;MX:1;LANG:en;
X-OriginatorOrg: cirrus4.onmicrosoft.com
X-Forefront-PRVS: 0154C61618
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 18 Mar 2014, Mark Brown wrote:

> On Tue, Mar 11, 2014 at 07:41:31PM +0800, Nicolin Chen wrote:
>> This patch adds support for the Cirrus Logic CS42888 Audio CODEC that
>> has four 24-bit A/D and eight 24-bit D/A converters.
>
> Brian, Paul - any review comments on this?
>
Driver looks good to me. I think we should name it the cs42xx8 since this 
actually covers CS42448 and CS42888. The CS42888 is derived from the 
CS42448.