From: atull <atull@opensource.altera.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: <gregkh@linuxfoundation.org>, <jgunthorpe@obsidianresearch.com>,
<hpa@zytor.com>, <monstr@monstr.eu>, <rdunlap@infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<pantelis.antoniou@konsulko.com>, <robh+dt@kernel.org>,
<grant.likely@linaro.org>, <iws@ovro.caltech.edu>,
<linux-doc@vger.kernel.org>, <pavel@denx.de>,
<broonie@kernel.org>, <philip@balister.org>, <rubini@gnudd.com>,
<s.trumtrar@pengutronix.de>, <jason@lakedaemon.net>,
<kyle.teske@ni.com>, <nico@linaro.org>, <balbi@ti.com>,
<m.chehab@samsung.com>, <davidb@codeaurora.org>,
<rob@landley.net>, <davem@davemloft.net>, <cesarb@cesarb.net>,
<sameo@linux.intel.com>, <akpm@linux-foundation.org>,
<linus.walleij@linaro.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <devel@driverdev.osuosl.org>,
<delicious.quinoa@gmail.com>, <dinguyen@opensource.altera.com>,
<yvanderv@opensource.altera.com>
Subject: Re: [PATCH v5 4/6] staging: fpga manager: add driver for socfpga fpga manager
Date: Thu, 18 Dec 2014 14:59:32 -0600 [thread overview]
Message-ID: <alpine.DEB.2.02.1412181456530.30233@linuxheads99> (raw)
In-Reply-To: <6eecb422024845acaffe10e4c81faac9@BN1AFFO11FD047.protection.gbl>
On Thu, 18 Dec 2014, Michal Simek wrote:
Hi Michal,
> > +
> > + /* Write out remaining non 32-bit chunks. */
> > + switch (count) {
> > + case 3:
> > + socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x00ffffff);
> > + break;
> > + case 2:
> > + socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x0000ffff);
> > + break;
> > + case 1:
> > + socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x000000ff);
> > + break;
> > + default:
> > + /* This will never happen. */
>
> why not just return any error code here even if this can't happen.
>
OK. Will be in v6.
>
> add it to one line.
>
> The rest is looks good to me. I think this is good to go in.
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
>
Thanks for the feedback. So patches 1-4 look good now?
For v6 I will leave out patches 5/6 and 6/6.
Alan
next prev parent reply other threads:[~2014-12-18 20:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 16:54 [PATCH v5 0/6] FPGA Manager Framework atull
2014-12-17 16:54 ` [PATCH v5 1/6] doc: add bindings document for altera fpga manager atull
2014-12-17 16:54 ` [PATCH v5 2/6] fpga manager: add sysfs interface document atull
2014-12-17 16:54 ` [PATCH v5 3/6] staging: fpga manager: framework core atull
2014-12-18 18:16 ` Michal Simek
2014-12-18 20:46 ` atull
2014-12-19 7:22 ` Michal Simek
2014-12-17 16:54 ` [PATCH v5 4/6] staging: fpga manager: add driver for socfpga fpga manager atull
2014-12-18 15:31 ` Michal Simek
2014-12-18 20:59 ` atull [this message]
2014-12-19 7:30 ` Michal Simek
2014-12-17 16:54 ` [PATCH v5 5/6] arm: dts: socfpga: add altera " atull
2014-12-17 16:54 ` [PATCH v5 6/6] ARM: socfpga: defconfig: enable " atull
2014-12-17 17:32 ` Greg KH
2014-12-17 18:33 ` Michal Simek
2014-12-17 19:41 ` atull
2014-12-17 18:46 ` Jason Cooper
2014-12-17 22:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1412181456530.30233@linuxheads99 \
--to=atull@opensource.altera.com \
--cc=akpm@linux-foundation.org \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=cesarb@cesarb.net \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=delicious.quinoa@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=iws@ovro.caltech.edu \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kyle.teske@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=nico@linaro.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=pavel@denx.de \
--cc=pawel.moll@arm.com \
--cc=philip@balister.org \
--cc=rdunlap@infradead.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=rubini@gnudd.com \
--cc=s.trumtrar@pengutronix.de \
--cc=sameo@linux.intel.com \
--cc=yvanderv@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox