Re: [PATCH v7 1/4] doc: add bindings document for altera fpga manager

[atull <atull@opensource.altera.com>]

On Mon, 22 Dec 2014, Rob Herring wrote:

> On Fri, Dec 19, 2014 at 10:45 AM,  <atull@opensource.altera.com> wrote:
> > From: Alan Tull <atull@opensource.altera.com>
> >
> > New bindings document for Altera fpga manager.
> >
> > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > ---
> > v5 : Move bindings to drivers/staging/fpga/Documentation/bindings
> >
> > v6 : No change in this patch for v6 of the patch set
> >
> > v7 : No change in this patch for v7 of the patch set
> > ---
> >  .../Documentation/bindings/altera-fpga-mgr.txt     |   17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >  create mode 100644 drivers/staging/fpga/Documentation/bindings/altera-fpga-mgr.txt
> >
> > diff --git a/drivers/staging/fpga/Documentation/bindings/altera-fpga-mgr.txt b/drivers/staging/fpga/Documentation/bindings/altera-fpga-mgr.txt
> > new file mode 100644
> > index 0000000..373af7b
> > --- /dev/null
> > +++ b/drivers/staging/fpga/Documentation/bindings/altera-fpga-mgr.txt
> > @@ -0,0 +1,17 @@
> > +Altera FPGA Manager
> > +
> > +Required properties:
> > +- compatible : should contain "altr,fpga-mgr"
> > +- reg        : base address and size for memory mapped io.
> > +               - The first index is for FPGA manager register access.
> > +               - The second index is for writing FPGA configuration data.
> > +- interrupts : interrupt for the FPGA Manager device.
> > +
> > +Example:
> > +
> > +       hps_0_fpgamgr: fpgamgr@0xff706000 {
> > +               compatible = "altr,fpga-mgr";
> 
> Is "FPGA Manager" what the block is called or the name for the Linux
> subsystem?" The name should reflect the h/w block name. Also, is the
> block the same in every chip?

I see what you are saying.  The subsystem is 'fpga manager'.

I should change this to "altr,socfpga-fpga-mgr" so that it is the
fpga manager block that is specific to SOCFPGA chips.  Also I should
change the filename of the binding document accordingly.

> 
> This binding doesn't look complex or likely to change, so it can be
> out of staging unless you expect it to change.
> 
> Rob
>