Re: [PATCH v8 0/4] FPGA Manager Framework

Pavel Machek
2015-01-11T21:31:50Z

On Sun 2015-01-11 21:58:00, Konrad Zapalowicz wrote:
> On 01/11, Pavel Machek wrote:
> > On Sun 2015-01-11 17:24:26, Konrad Zapalowicz wrote:
> > > On 01/11, atull wrote:
> > > > On Sat, 10 Jan 2015, Konrad Zapalowicz wrote:
> > > >
> > > > > On 01/06, atull@opensource.altera.com wrote:
> > > > > > From: Alan Tull <atull@opensource.altera.com>
> > > > >
> > > > > Alan, there is something wrong with your email client configuration
> > > > > and you need to fix.
> > > > >
> > > > > thanks,
> > > > > konrad
> > > >
> > > > Hi Konrad,
> > > >
> > > > Can you be more specific? What problem are you seeing? Is it a problem
> > > > with the original patch post or when I reply? When I a post, I'm using
> > > > 'git send-email' with sendmail and when I am replying, I am using alpine.
> > >
> > > I think that because you email client configuration sets the 'From'
> > > header to "atull@..." and at the same time you sign-off messages with
> > > "Alan Tull atull@..." the "From" is added at the beginning of the
> > > message to indicate the original author.
> > >
> > > This should be fixed as the "from" is not welcomed in the body of the
> > > commit message.
> >
> > Actually, why not? Tools should know to look at From: in the
> > commit. AFAICT, Alan has it set up correctly.
>
> I think he has not. I suspect that the sendmail configuration in the git
> config might be wrong. The 'from' must contain the same data as the git
> is configured for the user.name and user.email options. Otherwise the
> send-email is adding the "From: ..." to the message body.

And what is the problem with From: in the message body? Tools should
handle that ok.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html