Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

Pavel Machek
2015-01-07T08:48:25Z

On Tue 2015-01-06 14:13:37, atull@opensource.altera.com wrote:
> From: Alan Tull <atull@opensource.altera.com>
>
> Add documentation under drivers/staging for new fpga manager's
> sysfs interface.
>
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> ---
> v5 : (actually second version, but keeping version numbers
> aligned with rest of patch series)
> Move document to drivers/staging/fpga/Documentation/ABI
>
> v6 : No change in this patch for v6 of the patch set
>
> v7 : No change in this patch for v7 of the patch set
>
> v8 : No change in this patch for v8 of the patch set
> ---
> .../Documentation/ABI/sysfs-class-fpga-manager | 38 ++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 drivers/staging/fpga/Documentation/ABI/sysfs-class-fpga-manager
>
> diff --git a/drivers/staging/fpga/Documentation/ABI/sysfs-class-fpga-manager b/drivers/staging/fpga/Documentation/ABI/sysfs-class-fpga-manager
> new file mode 100644
> index 0000000..eb600f2
> --- /dev/null
> +++ b/drivers/staging/fpga/Documentation/ABI/sysfs-class-fpga-manager
> @@ -0,0 +1,38 @@
> +What: /sys/class/fpga_manager/<fpga>/name
> +Date: October 2014
> +KernelVersion: 3.18
> +Contact: Alan Tull <atull@opensource.altera.com>
> +Description: Name of low level driver.
> +
> +What: /sys/class/fpga_manager/<fpga>/firmware
> +Date: October 2014
> +KernelVersion: 3.18
> +Contact: Alan Tull <atull@opensource.altera.com>
> +Description: Name of the FPGA image file to load using firmware
> class.

This one is ugly: it unneccessarily passes firmware name through the
kernel. Just make interface and code simpler by always passing
"socfpga-fpga-image" or something like that.

Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html