From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754688AbbCQVlq (ORCPT ); Tue, 17 Mar 2015 17:41:46 -0400 Received: from mail-by2on0098.outbound.protection.outlook.com ([207.46.100.98]:38160 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753866AbbCQVln (ORCPT ); Tue, 17 Mar 2015 17:41:43 -0400 X-Greylist: delayed 3762 seconds by postgrey-1.27 at vger.kernel.org; Tue, 17 Mar 2015 17:41:43 EDT Date: Tue, 17 Mar 2015 16:39:30 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Greg Kroah-Hartman CC: Jiri Slaby , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , , , , , Subject: Re: [PATCH 2/2] add newhaven lcd tty driver on i2c In-Reply-To: <20150317211605.GB8441@kroah.com> Message-ID: References: <1426624607-2832-1-git-send-email-atull@opensource.altera.com> <1426624607-2832-3-git-send-email-atull@opensource.altera.com> <20150317211605.GB8441@kroah.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1605024904-1426628386=:21358" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR06CA027.namprd06.prod.outlook.com (10.141.250.145) To CY1PR0301MB1243.namprd03.prod.outlook.com (25.161.212.153) Authentication-Results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1243;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB400; X-Forefront-Antispam-Report-Untrusted: BMV:1;SFV:NSPM;SFS:(10009020)(6009001)(51704005)(41574002)(24454002)(92566002)(66066001)(76176999)(54356999)(42186005)(2950100001)(110136001)(46102003)(122386002)(50986999)(83506001)(87976001)(84326002)(62966003)(77156002)(4610100001)(512874002)(86152002)(53416004)(19580405001)(33716001)(40100003)(15975445007)(86362001)(19580395003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0301MB1243;H:linuxheads99.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:CY1PR0301MB1243;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1243;BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:DM2PR03MB400;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB400; X-Forefront-PRVS: 0518EEFB48 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1243 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD037.protection.gbl Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=atull@opensource.altera.com; X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(199003)(41574002)(189002)(24454002)(51704005)(62966003)(92566002)(68736005)(77156002)(15975445007)(97736003)(54356999)(76176999)(53416004)(19580405001)(19580395003)(6806004)(83506001)(33716001)(16796002)(86152002)(122386002)(40100003)(110136001)(50986999)(60046008)(2950100001)(87936001)(66066001)(41446005)(105606002)(106466001)(46102003)(512874002)(85426001)(84326002)(86362001)(4610100001)(7099025);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR03MB400;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:ovrnspm;A:0;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Forefront-PRVS: 0518EEFB48 X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2015 21:41:38.9766 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB400 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8323329-1605024904-1426628386=:21358 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT On Tue, 17 Mar 2015, Greg Kroah-Hartman wrote: > On Tue, Mar 17, 2015 at 03:36:47PM -0500, Alan Tull wrote: > > Supports the Newhaven NHD‐0216K3Z‐NSW‐BBW 2x16 LCD module as i2c slave. > > Devices will show up as /dev/ttyLCD0, etc. > > > > * Backspace is supported to the beginning of the current line. > > * i.e. printf '\b' > /dev/ttyLCD0 > > > > * ESC [ 2 J > > * erase whole display and reset cursor to home. > > * i.e. printf '\e[2J' > /dev/ttyLCD0 > > > > * ESC [ 2 K > > * erase current line and set cursor to beginning of line. > > * i.e. printf '\e[2K' > /dev/ttyLCD0 > > > > * CR and LF are supported. > > > > * Vertical scroll when cursor is on bottom line and receive end of line. > > > > Default brightness can be set from the device tree/plat data. > > > > Brightness can be set from a sysfs file, for example: > > * echo 6 > /sys/devices/soc.0/ffc04000.i2c/i2c-0/0-0028/brightness > > > > Signed-off-by: Alan Tull > > This should use the new fb_tft api instead of trying to look like a tty > device. That framework is merged in the staging-next branch of the > staging.git kernel tree and will show up in 4.1-rc1. Please port this > driver to that api and submit a patch for me to take for the staging > tree so that we don't have one-off devices like this. Cool! Will do. Thanks! Alan > > thanks, > > greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > --8323329-1605024904-1426628386=:21358--