From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933143AbbJPPi4 (ORCPT ); Fri, 16 Oct 2015 11:38:56 -0400 Received: from mail-bl2on0084.outbound.protection.outlook.com ([65.55.169.84]:61120 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754336AbbJPPit (ORCPT ); Fri, 16 Oct 2015 11:38:49 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; cavium.com; dkim=none (message not signed) header.d=none;cavium.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Date: Fri, 16 Oct 2015 10:31:47 -0500 From: Dinh Nguyen X-X-Sender: dinguyen@linux-builds1 To: Andrew Lunn CC: Florian Fainelli , David Daney , "David S. Miller" , , , "linux-kernel@vger.kernel.org" Subject: Re: SoCFPGA ethernet broken In-Reply-To: <20151016150345.GI10146@lunn.ch> Message-ID: References: <561FF9E2.30102@opensource.altera.com> <56200687.9040903@gmail.com> <562005AD.8020903@opensource.altera.com> <56200BD7.8020505@gmail.com> <56200E15.9080603@caviumnetworks.com> <56201158.8040806@opensource.altera.com> <56201AE7.2020103@gmail.com> <20151016033143.GA28207@lunn.ch> <20151016150345.GI10146@lunn.ch> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: CY1PR21CA0010.namprd21.prod.outlook.com (25.161.247.20) To BY1PR03MB1370.namprd03.prod.outlook.com (25.162.109.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;2:GCL6JvyaNHPtLDNJ39UdVyd6egi2DtN/yZQLyzb0/2uYGSgvpXQMIY5h0zOoQApnEIvNN4sBcwHtDVA7A6FJUUw3awzzUOXxVRlYZltbkPa0Dy7WgP039WfoYZ+p1Vup+kANsbGcX/LlHfz8/9EK0+5JyOzAOTV/TTokFywMuPI=;3:PoE0HD/sZrfEuhzVNZbomdt8rEwN3cgv9YuI8Ecz0RPWxBBnSVTZTFMy8TVKCwpdnqk+qUQ41m8lvv5zJERAJvjXNusZuy46MaqmC9rThPpejH1P+WO3QP3yA5aLK2up/5O/ARi1SQXPOZIENmWomw==;25:7QQIo6my1VJoEtgCxnFVkiCqf/7LSG2IXuFhdeh1meGSMATRe9exDRSCtDtWhrcVFTllddxu/Q4mRJsTltbENY3VQI4PAVC67mJDBzuYQDAxOWDEmoVQvWG9CPgHU7YJUVhCZBs1BQROZmtPW/U/gRzPPDAW9VQD+2KLHuyRaJ233yYPA5XMdgbCbkRmos+mgUyl6qSm7+WYKEcvVnGOiEI1ehFpEnUMLU70PVqXSgXZPcZSF9AvOkjHmZZ9liysWMAir1x1WT+m1mdCcx9k8Q==;20:IbFbqmalWcedYS50AantJvM0fGc7AJ6k0Q7aBAWg2n06jBpTJKJe1/z0nWGdzhtgeAkNYfZYTxE8trAvR18r/cWco66Q2gJlP7sDLKqsblLfZ8pjmgZJI1ZrqPaHxw6nYriQGG4C6Bwr1ZIm0m1Xb1lYOV2n5YtnAU7KM9H/snc= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1370; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:BY1PR03MB1370;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1370;BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001);SRVR:CY1PR03MB1504;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1504; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;4:H3Vndyg7c0DvvDxKNbtgX/LTUSfQDVseqzfONzuKjV9bG3+wxcAyl9Rze7vbiFuO9Q6mWFxRbIok/kCeQlK7NF6GHZxG7Yr6cKccZc/nGKYwblD3MQ3uNFZhRE11JreGKj7QkTLKzI0p8wxIVep3/Ew18PtmHvO4jbI3Ts85I1waZZmePDgCdbMuz5ngOzcn1z/86Y7cBna7E4Q/S0T8B2MFkFuPTmPaqSBx3LjcPQsJkfIZ8nj2sBskuSjdvaFX55TdUQIcELsdZZAs41PQr59bWq+QL6/EgXpyHvJnWVbIsR+iYAJguyPkYf4BoewWci305zfqa7qRkXEKkLjKHD0Xtsjpqn3IGcXA7AiXyqs= X-Forefront-PRVS: 0731AA2DE6 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(199003)(189002)(52604005)(50466002)(23726002)(189998001)(5004730100002)(47776003)(46406003)(46102003)(53416004)(83506001)(97736004)(5001960100002)(2950100001)(101416001)(76176999)(110136002)(64706001)(5890100001)(40100003)(19580395003)(54356999)(122386002)(4001350100001)(86362001)(42186005)(69596002)(5001920100001)(33716001)(87976001)(77096005)(92566002)(66066001)(50986999)(5007970100001)(5008740100001)(106356001)(81156007)(105586002)(93886004);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1370;H:linux-builds1.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BY1PR03MB1370;23:O29eePjfgMQNndg06Js0hGtHpQoJxBG4jFkv6DYPd?= =?us-ascii?Q?1lMxOQvICpCD3eJeX3rmTh6jNyEmGtDlQjPiGPNmZgw4orRKHcH+TlZFzY4Z?= =?us-ascii?Q?1TEeLIuGVYe5dyFpZWXqEfinyqcGzuL+Zj1SCWkVn4Vu343LW7EF+faqaSXZ?= =?us-ascii?Q?rEX+kE7hmERD0r8G0q40IGcRo/D5AGQ0WaA7XpJt51T/Nm+JH3JehOLp3T1D?= =?us-ascii?Q?nL/pc7vtiQCcUS85A35BQfcwPChxJV8LhfOMaTRrUhegWLQPnEJFmaqIlt2E?= =?us-ascii?Q?1tUN0f8zEdceXeBOsQF6rjum+n2eN+M/HidiXfg/9XmHU8uET9TfV5O0T7W2?= =?us-ascii?Q?1EeJANurw6/QcfyBCfFGCYcEx/viEaI4ZjBXWExaTk+QyKvW53xauCSRXwbI?= =?us-ascii?Q?5QHkBoxkpfJQLZ21m82Uk1moaqPuf15Rb9nMBZJEephZm5tAH589YW1+zAsp?= =?us-ascii?Q?BE6GOmy1giR/ErA2CyRRNitjgoA7VcADsMIFoafzAAV8PfY8puGcU1jnyPSw?= =?us-ascii?Q?/hldSBzc5TRbLyMxUlhSjuIq4/tAkhTa724jRehK+uTCDy25YKB7O/Id3/oi?= =?us-ascii?Q?0abIO0CqeMDeZJCiRRmsYCpHJTzeBSpUFhdpHXGmp/gG2ALcQjcZ7+6GclEb?= =?us-ascii?Q?y3XIZv1X5OiKDAlqPh6lQ3068kXxUeLO1w6Vi9sDAtnWry3lceSQEm30zn7T?= =?us-ascii?Q?MqrKPT6PgYn6yxKeFCiWqj37r4HelJri1EJmfK2jRmNLCfjTN3yNFfbHnrVD?= =?us-ascii?Q?MkjeYlqnPLTK/6y1rV4qg76lOXio4qYxC06EFSzMxiVgUKhd1pQZSMiA4k5Q?= =?us-ascii?Q?/hbW2PoVM9/daECu/E9s1HCSHoQ9QgpMvDWrrfJj/4xE9FiwdPGF8IqB0zdx?= =?us-ascii?Q?GdFMCE42pwKPe5IDprZb3f+Q8Szftv8fbLmI7RF49DIaHwCME+Mx4NbDUKy4?= =?us-ascii?Q?QMcxf263rgrApdR5Wahdp9h/AwnegVHdGvzYqbvLBGDUJoj1byW5nFeoEOVN?= =?us-ascii?Q?ByLRpEprJtASR67sI3C+sm4uoX5gPwhtct0uCA8K8aD5Dh/x9m3J3pApP7mA?= =?us-ascii?Q?/Bi/lX7WCrk3oB1b2GMoNrJpmiB5rZsVz8qzfmG218lkVmJJBKjbC8iNYiFB?= =?us-ascii?Q?SDwyPeTnm1W2KYcu25FQ3fGDDGT3j0k7HJ+ISGLxAj6mdqvEPUHyw=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;5:n7Ub4C3mrj6WyG+w35HeDWdFvOgYSJ+AouYZIMobghq0I7D5usmQkymJ1b+kxlDnkwljFbZWVsVgIpBk/m8UUoI3DlOjqwNHWh64HgzTcNtsER9XxhxlbXq9xbWVKUyE6ontHn2s4DtoME0LnmMbfA==;24:fZJqJgvkCm6l2wWmP9pwWW/hOl6UY8w3IgFHaALiO+alQWE79NXL5C2Im+mQ375x8xe/AAvun0YqTyPCXhKXuMDarjJ3FOHnlfNtDtOHnwY=;20:W0EOXnFB1379heOHKrCblAD4j8M1QEVF/EFlEIYPZamV7BSamC8+1FkP4UAkCFF7vDsq286xLEXLAtlwYTB6PTJebPAAcNtunTnRcSOgjKUsyTwdve50MZXHgEOtKICSz1rO2bwVWxlsXLMbZdLGyeY8zt/ogUYFQzqufe43ZbQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1370 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD030.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD030;1:682Gb8ajkg8jKCXMvhDE0mFI3n29eOgUhsoRgjPUWQsjz312VgwGtC9KVCslpMBuWdigiKXAwdknfhuxBvVDq/vTKe2+tDpnSF6t2Npktfg/4wrWKMVDRokvp57FIl8XbSxozR64XcLYoU+TD+P8uqS9O6ng90YCIBX9kxjZSO0IU2c7cp2RzXLjw6uZrpzjBD5vqErn+kmw0edVylXjM5U7PztvbWTKsfUGm3QUhtcamLTaXFmtqovMYZiWqf170DKE/drg4lMNrAWvLI2kWSOsHm0/1ylGXdr5EIMthA8YjzHhB5J4Ny5NgyKIph92m0kfMlWj2Bhhlqh84R8SoLkOT9tspe4nBYOAdymic61D1XZuJXNP2z5vwcZ1bohQFh2S4nSY0Yp2+A3T/tq+lg== X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(24454002)(52604005)(189002)(21840400001)(46102003)(5008740100001)(53416004)(106466001)(93886004)(77096005)(122386002)(23726002)(105606002)(50466002)(40100003)(33716001)(46406003)(2950100001)(86362001)(16796002)(92566002)(66066001)(64706001)(85426001)(83506001)(11100500001)(5004730100002)(81156007)(189998001)(5007970100001)(110136002)(5001960100002)(47776003)(97736004)(4001350100001)(76176999)(87936001)(54356999)(50986999)(19580395003)(5890100001)(5001920100001)(6070500001)(6806005)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1504;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1504;2:3HxLI2bR5PzjRxT8jHQ43l7NO8msbKeTNCADjaOQARMFp9oyQbqkgewnvL15AZ4UE4eHehak7tkmgK5kA3v+xjzz5J9HDn7L5uvlRZPRoIf+Hz0nPMSrpulks10Ex9+YPwVe4VvAnK9TK+bme4sTznEb6xGKsEV92j8HI/+1A44=;3:4LPbiH2zlCZZCeMuqLej9nmXLRpJ5///FFp0gNhG+uJ5uiPp+UpZmti1C0uo5ox+mMy8famXijFOGZfKlyZDV7ri2lUQfC5e3xCno0bTkIBDcJZFev+y0giyxWQsbZAjeYNqDoM7PczPNLqfHCgF2IhplczXeXBkzUfY4ofi+iAo/07v1f74JEJzqMOqi+QZQWlHAwfMte9VtMDDRv+ZD6MGppQ6AR3MEQoOL91Ob3w=;25:oZQ8h9EUNSzslpWCZC8h9IfGtGq5PJ03uREVzrA2zuCCtWWk/3IVb/GaOAX3MVRqNknUzRWFGSIFB6aKvlOgAMKrhTOwP7T9fF8gOQ7pmpdjHZLSep3kXis6VzvyJ9SrfA1gfTt1pYSyEbTZRrGXXwH6nKG+ANatu/R89XXAcpiKwQcbcPVUCX+dhWNZmkeUWacA7bWj9DEDWwjFMUsA0Np0yRs1tNcbNP+hmbx3J2rpeQsUeAD6JuijGlsHqm307wKxPku84r7yXQ/RISUdvw==;20:qhXXr+Ckt0pQiOUFiWz9txGGOjwisNDGPW8Uo+4N4THv/5uciDSHTgAe4kC9SyOlyR0YXWSI8NYARuDT++dW6GRfnfQ+dn/p7cTwfoi8S+4XtwLiwhRtrZ2sYC8MTLlcybW7etDvGXGxSuiuwZFULk/Wh9jKfL6cctoetlGA55I= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1504; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1504;4:tEuYkCpdjpoKu6jo7dNZBqtoCL1FwHTg8btD8ixI7084P6ZAsRjux/OpX+SKnFyvm/3uwXu4rfClvJRw38eoBo0gz+0F9ite58c23bBVMPSMi6J7apZfiMHXwoQKCl6PadeHWmtMIDMjyZb+yJ9ZIGqgu+j0RMXtxFQdFdfMbYTQWsBEpd5ZQAc2RftKNe74yZS+yDHOZ2PS5zPG0+NvU+K0x7CYGB7+uOIm+HsciqxVAw10+eQHyNN8/VjOcV9lWqeBkmb8cWKcB0JLbaeHkCmJCH8cQF0lhSbFswCIqzRKN3lUkhN5l+Mf7ABo59omonw9Md7HaphOJT21P5waZ5T2y76KJ7xACFgO4KObT6s= X-Forefront-PRVS: 0731AA2DE6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR03MB1504;23:WRgE9zqHoxxkQodjQKxsWSIoysBhbRydJup3k24je?= =?us-ascii?Q?oYzq01qIPiBm2ZWT17ZdoEnO3JClem4FsT63Nddrqx92pYu+sIrLWIRDh68U?= =?us-ascii?Q?GHPlfhOowUNEJ1uryoExQZpjeUxFRsHemiDlX0j7TtI9arH9VjmyGEhW3P7T?= =?us-ascii?Q?oWCTOBMK2sRyb8JGDQcl1e+8HF04xBxPaDCzZJ+8imaI1uAVQjQ2i0mt9c0C?= =?us-ascii?Q?y33tR/MnJ8TuPB4SwDlKfUKWXRZFfTLfiedAW/O3BHPg4bmAapSdsIbwdzEy?= =?us-ascii?Q?IFNJv8rwzndpXF4NxXH6I4bKAVLZATyhdhM4tUTGF67wYrwJWwVAElK2rw+m?= =?us-ascii?Q?RRe2gBfjmisK214+gtWNZCNWjZnv+VP4by4wr4ERdkI3exYwj95K0DhVSAGv?= =?us-ascii?Q?3TCUrKj9ludY/TCIgod3a3vN8hzqRlaWVQrWzYWzJsBFt0m8jxBnMFuMkXWD?= =?us-ascii?Q?fIc/6AInDAa9VGE0FH1E9rcFC+OJM2oUJUs1QyYnsHOvbeFfpAapsL0ck35M?= =?us-ascii?Q?A+wmDLO6aW7sEeVC6LPhVGGg0w+QiC3fdbcyKZ690+pL+kKsU3sYjR+/LuJL?= =?us-ascii?Q?SkWVCnj2iQJ2Q2gfRbMCub4maZjYg+jod1hKO9mP1IPGrFqt26TDGcWz4kwJ?= =?us-ascii?Q?ZGCP36GflgPPJ0+Z1P2pNty87uAz/EQnAk2cCVIObPSI7DuZBNbtTBgZCXSc?= =?us-ascii?Q?BzBgr3GvDrqBzBSqdkEsnc72XHqmAYk0eOxEu1RKL23vaTy83uRa4YVZKuAJ?= =?us-ascii?Q?KgaV99wy/cgmvryB2vdvcQLdP0IpODjf9EppNG/YNKND1ZgQz6c/Yc0vq0yU?= =?us-ascii?Q?QREPCrSP8osUilKZoMHNJrCld2RZhezsDhelOx1nEwdEe3yqJiuV4bMfee0j?= =?us-ascii?Q?CGBUqzZ+ZzyRFZu4RyU5TrBjo62zJtddEiUIQShazsj7ZJisljWL3HwmM42a?= =?us-ascii?Q?aQxBF627nT4LIx2y7rAQm8+Ss64ZOjnPKyYW54VOOcY8LU4AvHnR7VcAjp5H?= =?us-ascii?Q?x1JPexFwpiHmXKNpqjTgvVijB544/0v5Ww9uehjyRJ2lfR42HN8DGEhDvoGB?= =?us-ascii?Q?qL4SNd87a39V7HfM/Cfv/gq6vRfywPpEiwkJ+lzsdOtca2RoFIAP3ju9mVKq?= =?us-ascii?Q?uPedVVSuEwWuW1O3O8WsbDcRHrNFjtMwXmoVWup0LbqRilRv400wj7baB2zO?= =?us-ascii?Q?Ui/lSvf6fdUbkjSUErwjG/IebYaofHJ9FvMSfhSfP1zZDBFBnnK4+o2UwNBX?= =?us-ascii?Q?S4UHYn+O3kIfgR2fcm2jZDpyY5z6YTOjdtfny36NkhoPGGa2bOdrHSwZ0kEN?= =?us-ascii?Q?lMCSWpcDbq8GtXXjN8D6IeSGNtyUPwB1qTQNcGApLRbqL4pDa6o7+4SMnOev?= =?us-ascii?Q?n/UlA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1504;5:WctTyW1Hj6mX33l4DxGskd3zzivBPFTK360ofHzWaDc/JWORxgWmWiuPEmbZ1NNM/U2oqvd1zHufuZf4vX+6qlSW8nTGENWrl/Qs9t6B9+tQ6scD9B9u9XpxWybAAiztPmqX2Q8dOKBqBuVxXTLLTQ==;24:rYgsEQlDLh7f5YQV/O2YKQ4rtGuWVmtXgHGE5JhgVVvJcw/BIet1R96MZHXXnkRHKPWmyybdXdhjG9IXnpBtK9Wiwad1ZO7IRkaiHLKMDZE=;20:h/a4SEReG+p4ptbO964QqH+7AweYLqhngrMrQc3rbEJWRmwM7T4Qz/1OxlR8MpIdaQQ2yY66jwd3agYA6tjUA4ZZffoh1eNeRUL9QO0kd7DIdgxTVrg7owxKhiOb9UKx+zR56nOJAAy0I1dz3Vg8qihcKbDEicZR2Q2qByWuoYM= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2015 15:38:45.9504 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1504 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Oct 2015, Andrew Lunn wrote: > On Fri, Oct 16, 2015 at 09:38:37AM -0500, Dinh Nguyen wrote: > > On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > > > > Another debugging point, the SoCFPGA board has a Micrel ksz9021 PHY attached > > > > to the ethernet port. What I'm seeing is that with 8b63ec1837fa patch, when > > > > the call to ksz9021_config_init() is made both of_node and dev->parent->of_node > > > > are NULL, without the patch the dev->parent->of_node is a valid pointer. Thus > > > > the skew values get programmed to the phy. > > > > > > Ah! > > > > > > You have the phy device tree parameters in the wrong place. These are > > > phy paramters, so should really be in the phy node. But > > > socfpga_cyclone5_socdk.dts has them in the MAC node. > > > > > > > Alright, let me see if I can rework the DTS. > > Well, we are not supposed to break device tree bindings. So we should > try to make this work again. > Great..thanks for recognizing that point. > > > There is nothing in Documentation/devicetree/bindings/net/micrel.txt > > > which says you are allowed to place them in the MAC node. Obviously > > > the code did allow this, which is what has now broken. > > > > I was following Documentation/devicetree/bindings/net/micrel-ksz90x1.txt and > > in this document I was following the autodetected PHY example. Did I mis-interpret > > the example? > > I was looking at the wrong binding documentation. So yes, it is > documented you can do this. > > But i still think it is wrong. These are phy properties, implemented > by the phy, so should be in the phy node. So moving them would be > good. But as i said, we should fix backwards compatibility if > possible. > I moved the phy settings to a separate phy node, but it did not seem to make a difference at all. So I think I'll move to inspect what Florian had suggested, and that was to look at: drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c::stmmac_mdio_register BR, Dinh