Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

atull
2016-01-21T17:25:18Z

On Thu, 21 Jan 2016, Moritz Fischer wrote:

> Hi Alan,
>
> minor nits inline:
>
> On Wed, Jan 20, 2016 at 8:24 PM, <atull@opensource.altera.com> wrote:
>
> > v15: Add altr,fpga-bus implementation
> > Change compatible string "fpga-area" -> "altr,fpga-area"
>
> Doesn't look that way down there. Or am I reading the code wrong?

Hi Moritz,

Yes, I left that out accidentally. But hopefully we won't have
pushback around this issue and I can leave it out permanently
and also change altr,fpga-bus to fpga-bus.

Alan

>
> > +static const struct of_device_id fpga_area_of_match[] = {
> > + { .compatible = "fpga-area", },
>
> I'm fine with keeping it as fpga-area, this isn't altera specific imho
>
> Cheers,
>
> Moritz
>