From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946461AbcBRPMk (ORCPT ); Thu, 18 Feb 2016 10:12:40 -0500 Received: from mail-bn1bon0098.outbound.protection.outlook.com ([157.56.111.98]:58563 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1426482AbcBRPMf (ORCPT ); Thu, 18 Feb 2016 10:12:35 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;vger.kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: ettus.com; dkim=none (message not signed) header.d=none;ettus.com; dmarc=none action=none header.from=opensource.altera.com; Date: Thu, 18 Feb 2016 09:10:20 -0600 From: atull X-X-Sender: atull@linuxheads99 To: Moritz Fischer CC: Pantelis Antoniou , Rob Herring , Frank Rowand , Grant Likely , Devicetree List , Linux Kernel Mailing List , Pantelis Antoniou , Alan Tull , "Dinh Nguyen" Subject: Re: [PATCH 1/1] of/overlay: of overlay callbacks In-Reply-To: Message-ID: References: <1455730885-1514-1-git-send-email-atull@opensource.altera.com> <1455730885-1514-2-git-send-email-atull@opensource.altera.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR15CA0019.namprd15.prod.outlook.com (25.163.200.29) To BN3PR03MB1512.namprd03.prod.outlook.com (25.163.35.150) X-MS-Office365-Filtering-Correlation-Id: 07201f69-b0ca-4753-0350-08d33875ed55 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1512;2:bLTBg9zbYCFit9DA0XyU237GeeaStUYUnaVDrJh++aM3rpape9NevuhOii25SmnzWs5ETLilnuahAvZGDkBxdR/yjgWe3Urb80c8kpxZiQXcavCJGFKxwC9yK9cKMTe8Cj8+crkRRArDoWUSTFPCS8ltUWFGTc2+x3QRcfuE7IZE+qwxftHAXMntTkZ6CfNU;3:lnXulldQoITGOU53VIkjMNou59w3ZTDNj4SR6sfAsYdWoQFHAS+P1iSlc5S3E8KJ78PKa6ZLFGSuGRPs8DvcyZ36Hjhu7w/H0ejq0S29uqZ0UELCMAWotTuNB34vnsWH;25:pUmBUZSH8XpBAw56h8MOz8QIqrTZ9345fWy6ofqRwDN3nvSjtkMPs+jnWuYXu8Tu+/o2WrRjFfnxutZYxatHPEo8XJ+LFAxfjffz0fincRLdwwUDa54JlPqe3E8kEPUTNEK54qTfkQ/kqr6XP3P3C7PGEs6K3qpvGL3eBHQB41NtTVXsg79IRzxeiIO6JfOX4uFGF8PxbDzpffIQ4a7SY5B2Myh66qYZCaNdG41EhTrdabtFhqJ0Hb21vkHtdw7gkHFvPrn5fSi0w3Bt3SvP7rt9wneUsHhLBqZ5M2kiQLmHGpIZ+SW9HLJjJoR03K+v;20:P4+CVvmmEEbx7+GRm+ahwUU1fQm75jLS4+R0JxstEXxDgOAXVD9At3WTZl61WE0waYqWyTEeGg/CHiZVPmuIDwuEHURF45Gul+0cMJLN5SS9syovc2xly0P+y7FVV4eEURxgvJH3zv7qSFdAGYXO7cFXiMexkZxvjEEOv9vszkI= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1512; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757);UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BN3PR03MB1512;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1512;BCL:0;PCL:0;RULEID:(601004)(2401047)(13017025)(8121501046)(13015025)(13024025)(5005006)(13023025)(13018025)(3002001)(10201501046);SRVR:BN1PR03MB038;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB038; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1512;4:i8kcBDyufTHTrdg2EPnfeDvG05FE+8J8Zxeu03RCp29l2z7nkbTggYJ5feHAO/nW3NL8If4VVEw6cRU2Vt2WIV4X8NLhxqVUmYfSqL/+PJfuR4mOieyyxxY/TQFWo5rIaM3zqHTwRG6DYEHFewxrWAqNi8UMg5xYk7eVK1w1W4AchhZIY55USvgjwCye5ZITXmALPuv1LOqzAoDTHAONdT+kB7XFwAg7e/CD0r89xiUhiIpMgWBJlZdsb0SAi36/p/NaiLMTJtyvvUaHIAAWv3iLTlGxcZ75yKHBUQKd56W3PbRYTn36PFiHZgSOs6I9xAf7kdS9TfxUI+2cEYNBP2Gc7eYad4VxWkcD+W0g9HpxAlyTZf0+knUNkatRRLL9U7lLgTOJKqypPj2Oj3irwVKmsViRaD/+rLV9puqRXfU= X-Forefront-PRVS: 085634EFF4 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(51914003)(377454003)(24454002)(86152002)(83506001)(19580405001)(586003)(189998001)(5890100001)(86362001)(5008740100001)(54356999)(110136002)(42186005)(66066001)(46406003)(19580395003)(122386002)(5001960100002)(6116002)(23726003)(87976001)(2950100001)(76176999)(92566002)(2906002)(5004730100002)(107886002)(3846002)(1096002)(4001430100002)(77096005)(4326007)(50986999)(53416004)(40100003)(50466002)(33716001)(47776003)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1512;H:linuxheads99.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BN3PR03MB1512;23:6pSN8vZHNRir+YZLrTkSXwFbs6IXIRa4DBKaqB7BK?= =?us-ascii?Q?fRYD3SnP5ThMnqPTq80RJ35aminvyV2wJv/mNVJJOMvnse9TWHO44LxI7TM1?= =?us-ascii?Q?5AwznStPsImuC8+ZIZrtyncC7c5cucBMUxzPlt25XiYTpNnOogFvPh8liviq?= =?us-ascii?Q?sHZiR3xFDcVck4DaMhcRgxNrSB4it0Ni7R/KiuL6LCch24J4KD+aZstyWmEr?= =?us-ascii?Q?BqP1zVUD+eN7j2x6sEq8uDC2DKA0giq5fHI+FKUSttywdm+aZl2PxI15mXJI?= =?us-ascii?Q?gKDatR6vKfuLa1Bq29hPvKGQ/I138i2MR1d+KNToWLzfe9Up4XVfeHacSeeD?= =?us-ascii?Q?siCBH6AbZTAnYwTGqGL2UOaNX7/Ls19gtuRjM628hVrmrR0GpCIUBDFx+/Um?= =?us-ascii?Q?TMuNqKOCaAtMyUzGcUJcHMNu3Ve2yAQxpjFUA10jGxYw9qnzQxDSadBMJcoe?= =?us-ascii?Q?t7rj2ye7vnfcnsubGWopRloFUTWPrT3w5yP1emQ3ZhgPTuUEnmZkJ7VpiF5l?= =?us-ascii?Q?WkBgBa099r4VAm/NTMiSGQbU7EYYEPZX2H9d8okCLkePjR/WcIrYVKIa7G9q?= =?us-ascii?Q?OJHEUfDvWs9SUv9oMcH0fkJzuAPsMQ5PwAH1m+BrVRpjOnx2j6Qafkzc0uxQ?= =?us-ascii?Q?PqLeOpDysH0bPyIFi1vclVTg6R4RHOjorMkOHrxnrx+9LagyyZCMgsR6Gwlo?= =?us-ascii?Q?32rpMxtgmVNOn/d4J1UnMmbt488xpX541V7ORgOXYV78IOD8/P6GYLHMGinN?= =?us-ascii?Q?mj77ay96chmi4dGYUd5Pv0LjhyC9OnY5GERXmTkaFr7gPSvlBeX6S/zl857T?= =?us-ascii?Q?uL0VMZVOzJhxwE/H1zgl2j8BgPtWN80H+1E+Bi/1sWU0noP8UFuWF23gLe3u?= =?us-ascii?Q?4PHPaetHySV2mn2XOV8KKO0JIXP+Rt21BmRyni62ru1d085Dg0GWyETVzEWU?= =?us-ascii?Q?6kVHg32xwQEUc61dQ+xsXl1cQqWEE7Bp2GvyF0KygYzFn3wPQGozM5xpgAtP?= =?us-ascii?Q?rDixP4gEqx3ap9+cy1QPZ45Ccw8QxblR44i3seJv+O/Cwwl+xw2rflbfifb8?= =?us-ascii?Q?gQdt87xecorT5DP3rgbFQakcstRNQM/QGCoJomPHB0bMG4UzrY1TpEMHiEOd?= =?us-ascii?Q?3zDh1WDK37rx4bhFRv39qtjeuWM7QdA?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1512;5:vDi1R9e2/+OgYWxcojVpwC4RWlmdMhpCXhsx9YAYaXqkHdeQ1cV5/dIDsk3M6l+xNoTRf+rhUbyRMVrKaWzRfRx+uPjg9GSXRDFkYxju4h+u2sq5GdsxQK2wCkf4jIOro2atQg3dKtmkiTeDzFXHxQ==;24:iHk8aTr+yqr2JaY3661wnC10T58QpNh4LQP3YdiVgsS29oGPQIKsMv9BsWkzsDlmwy713qD9JLepXCg4bRv+FlTemW5tXQ4IM9puz4vG6LM=;20:s9veGccGvXu66fGwCR1KnbZa4/s1gs4xbePLhAEUTojcQLfDRTp35iHThMh5bsb4MKDEsHBGAsUjx/8Vl31nqm2ZIJnmNwTUMNwhV+TH1eyDKm6YmZRT+VL99RWIwdKdBJ2t9BOiRwItA9k98YQys5URO6qkmgDWlJzTkqzCaXM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1512 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD047.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD047;1:JYJWTur/NUUg/VrfS8anKzinSf9CO2APQicWyUwSO1F7YzVt3NasZUlCYMuy4NkRnN/J+BJ7EbbeEi5zoAPWCNBieq+3M4YvyFw/R5IcqvXQaxTowjKqCPjUdw7x2526ALOz2rb/qwHgATUiLn2el1CafZcgmgdPMRN8UDXEAjU+aD2riM+rX/pzMuq3sHSC+QY8eFeHutM00CO92qntYMT8WWp0BcB9VqhXUDpXigHwp/gWffdD8D9oEGAa+qc3FeDbPIUTjY2kusIkCgIql0poq21xpa9kJjhP0LqVFpVxRsLIOqfHOtBMwgokqzcqPErKPucSc0luS6zy/i5ulLvcNka/nipX+AmLAsHcakMjqWWo9lNU3yk9yTlxqynO1oox3jiUH+v/VMn2W7YJsRpiA0Zzj0bIZwWXKlV4c70= X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(24454002)(377454003)(199003)(51914003)(23726003)(3846002)(92566002)(50466002)(1096002)(586003)(2906002)(1220700001)(40100003)(122386002)(3720700001)(53416004)(86152002)(6806005)(66066001)(4001430100002)(956001)(54356999)(6116002)(11100500001)(86362001)(50986999)(76176999)(33716001)(19580395003)(19580405001)(47776003)(77096005)(5008740100001)(2950100001)(85426001)(5004730100002)(87936001)(5890100001)(189998001)(105606002)(4326007)(106466001)(16796002)(5001960100002)(107886002)(110136002)(4001350100001)(46406003)(83506001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR03MB038;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB038;2:p48K/teyhT5sC0HJ7bAqe2VASk4Z32c9T6qiVHjMzQNG+R6Kbb2qh9BVS4Kt0OxtDIht2/eTt0DGZdyWLKdsHcsKqKiWtvh+wxBQAsRk09jAAfv3f9D/pC8UvRrOsQVkk7sjA3rcH34BUoTfuF/a/dyfIZouoIyU60rV+iQHJJ5PGbF06ArDtMWB8YGVVrdC;3:jPkDQcpt3GnOWPIJ2ZamkGX/Upro4GDIWdeI2VXZqNNAayzeE/aVlw46eToG58SB+jXqibRVIgZz7Q01DbLNjklXdXy1tIl7xB+6R9b6rvv2mLgYEx70j5x+l7/FoUsv/OCF0BeaqZHaxhXKtqEh80smC1vggIVbasIxwD1CKs3yRnptmQWUma4LDKVmskI2TsGHdcmy1Lel5gaS+CJ4pMKUWaKMKuWy/fTbkSWhVAdIoMc7D37gcowFDHPHXAMS;25:C2UJS6zuzTdmYxViqCEWJo02UX3l5SyG3uHvOM+trKXpo9xoxo44bocReDVjqS6J0JKnQOOGPRCtXhRQrICjSAqBnViQ8Y+OaQpgPn4Ca77e+4WukNRbjT3KLP52GOhlw4x8dM5IM9c3Z1DFQsIhX1MYghmR59bPxNZhuzY1tBCiNHvZXlvT1a7FI0sVvCmSVEQPb1ihlxTymwmoTGaz1ICPQt8bvzGmohhnGxdHNrHqWuIKteFGNcX+NYi4Myv7YZZ6/emcBxebxrz1uHMR9o6mlsJb+Hru8QK08s0uDW9i44+v8IUZElJT6jyB22NO;20:0AJsCLE6EJGYaHjfwRplw4akcTweCWZieeEx9kC3+p+4t4kiIzKA0z8o7WxY3gMP4P8CZ6ZmkUxDc0ueLtlts7L7SsgpFPOJQYnYGH0O7iejFHpPYV05AsWDrggEZUrkylnUGgg0YgGTCmxtRyqCOCXPn8+KYm7mZ9VL8qUfSTE= X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BN1PR03MB038; X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB038;4:GslqJRjMYRPrnxIgjwyuuOA7k06udjVPV8p7EjMxMUIPHugp18CPqdaTh9Ub9A64oY7ROIS8/2Vbm+KtVAIlzTSCtdjSwRiI9Lwyzic3y0toihw04b4AlruXvRI+vUJu4pbdaTabrTzBKIuf4GMvfBNbj8c//ErKOYYYZm197cUeN7ocDSXL2/5IX1jarOsbHS/zHa1RD/V9yUlQFyp+IRUkg/iyhHB+ZJmLN7jwhlWe2NeZ5NvqyZWiidwHvq0cMV0asoptO5O/85lZNTwR7K3moOkkgmHH4N39hFEN9DCgGoOj6YhgtzlL+dR0jkySkYtQ+UR36qw3Tu/mtKm1A5Rv89yfYlEFk4pZkX30mLCCr4mLGmVUnOoS/iz7kCRWlRdeCCmCcTPU2+BwFL/lK3Frg+ipWBejli30Dgdd0Bga/LiyKRSoyc3soMwEQTOAbCUC0WUlDdXM7wNE9D8OCgOm98zRlZAyDrshADxfmXg9JCsPbSmZ3KyBf3CnibnZ X-Forefront-PRVS: 085634EFF4 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1PR03MB038;23:9yGgCx25vWOpw0xjJwdg53ZhsRd2heB6Uupl0Us7Z2?= =?us-ascii?Q?KhVF+4ncadBGle4ssiA3Ji+Kt+L/Ddv2lZXeIlOtqbxxK51/qjpSA/UJmsXI?= =?us-ascii?Q?4TO6EFJcvAgpFUCU/7tIxJxHmSL9pGTVyukTOc8hQNGxIwCBDP7IGBtok9tw?= =?us-ascii?Q?SOlv0KO2MXZhrmBmoTaGzAUwZfVrt715OdTKoPWQCMjh+gfhPEq3YF0hpmuZ?= =?us-ascii?Q?Fg/sKEJQqYGhofh86aVhhkHn52bwRFAEnDuTE2a99Scbhw7YexbMPeqhyDkI?= =?us-ascii?Q?18gzCEHB5oFTu2Can3KnRqs/VvEWOsOxbiwG6tQT/SpKTBH5hP9lb+LALTmn?= =?us-ascii?Q?lYHS1HVmyZoiGTYNxHV0xuRLVMZSig953/jfqZ+cgy/jFGXpjU1Cj2ETeAbA?= =?us-ascii?Q?tllotCX1vjeYv4iqrfcQ2oijUn896qg2MwkQbcoycH3BJ0oX3cAA36aKdIfL?= =?us-ascii?Q?MCgOuM98BEqYqtfaGUTkAw02dWe96jtGcTJ0L4g+MdiD/uwW0Ora8LBLEvBd?= =?us-ascii?Q?WzKLiCRH7KbY0HLfSeUqqSds9RWs28ewufXH1Pq/RtZlwJJlW+NgmOCZ+Rr4?= =?us-ascii?Q?dRJGv8VeSpFwPUre88nOEKpYqLCLALrFmTW/R2i/RKRTk9PrrM4uyPL0tqVJ?= =?us-ascii?Q?eDxp91wiPfZ3dcOHNQE1JXpA/JZevfUubq39QUQ6MOJIF8pE76yDZ3U+Z9l0?= =?us-ascii?Q?tkn7iVdTJPRAEFUrepvs1r8mVwjs73JNv5YgnjngxRc0HM81Ujv8hmvz9zbm?= =?us-ascii?Q?wkis/7TZZdqGU9VJLSjToxDq3lG7nHIpAhgG1+TOudvi9TmKdryF27EorcI4?= =?us-ascii?Q?Y7nZqlBYud4aYS+NkD4DZjSKiRghRHa5Ln+tA5I8+Pe4agwOAr9ILKHypZt6?= =?us-ascii?Q?vcaPlvusBsRCmU6qcwK54ZlymqaGNpK7p1cGTvUHtb8COi5cNp0jdhLJnjUS?= =?us-ascii?Q?w5C/HEusjdENT4NHdlQqOIUqhyXWAaypisBLcZKgNil4FijXF7uVR/s7rJ89?= =?us-ascii?Q?TPGc2aF9LFtUKZy9V+U4CBbYjhJh2jTPUhC1taO4jjxKSRj0zqHvYXAUApL4?= =?us-ascii?Q?gnteeOeY0dlwQEGf3HDr3pCc0GwOmiQOSf/HQ/msKJ7y1DaiB0Kxu9CJVH4S?= =?us-ascii?Q?5wLrO2XYVHU9hoYSVnPLd8F9jNr2FGYKBDbjmK/9Tia4u6CDwbLslwYk2VEd?= =?us-ascii?Q?ewOkX5X7Lq9OQ273nkPu3u8xa9vMHXXEiOLoyFgaASuldXzARIWji4DJjIB0?= =?us-ascii?Q?xDGhByDWhbx5b4oEFNTYf8blcJ3Gkawy7YeYH9khjlfq8mH1UpwTgyPHd688?= =?us-ascii?Q?VQH5pgGJj2GYAPhJymuddg0gf7oGYqll/jdJBAHdlIS0kxAGEAgPr8R0Hyej?= =?us-ascii?Q?M1WS/v3vaBvqG2y5UDem9P7mNeAl4T15x7MDbQy+OnsbmSG3aIyYTXrECuqi?= =?us-ascii?Q?EPrmy1dg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB038;5:6GxisfAzap24K0x19tD4Ov82EViZeIONkaI23mssfmHuHFjOJwl/OlSo3RnnNhdOyjyd57Ia9CuhQ+TuVK2WaREdo3gitgAzfcLUv5gQG+Xxli5dRDYF0FfOwo4TEVj6rm96kNvoz2RX29DQCzxecQ==;24:6nTVExFI0ilxnakOPLhkFeUPcruZLfCYCzsMCF2EZ22VqG/IA+LD0RVBUhwOZRuPkx5zbljtIKGQRz4R0gdhB/m5no1k4sW3STs2R588KtY=;20:kztCtdBZiyiSAm/s/z23HMydcmfZ0M5WatcWF/XVMdW89e0Umag21v40Su5UZsOUgF9T0mfkg5YOjOgvNGnHXzwj7hcX6CFgvicrGe/hO17q7yY4MEjgaAejYUGIUMnXuJEKH13BHzUvmK2SS7+VkCsPwy4MVZyPQdb5kLe1FIo= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2016 15:12:32.9884 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB038 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Feb 2016, Moritz Fischer wrote: > Hi Alan, > > a couple of nits below. > > On Wed, Feb 17, 2016 at 9:41 AM, Alan Tull wrote: > > > > > +/* > > + * Send overlay callbacks to handlers that match. This call is blocking. In > Can we make this 'Invoke' instead of send? > > > @@ -370,6 +448,13 @@ int of_overlay_create(struct device_node *tree) > > goto err_free_idr; > > } > > > > + err = send_overlay_callbacks(ov, OF_OVERLAY_PRE_APPLY); > > Again ... maybe invoke ;-) Hi Moritz, Yes, that's better. I'll make the sends to be invokes. > > > diff --git a/include/linux/of.h b/include/linux/of.h > > index dc6e396..def9481 100644 > > --- a/include/linux/of.h > > +++ b/include/linux/of.h > > @@ -101,9 +101,33 @@ static inline int of_node_is_attached(struct device_node *node) > > return node && node->kobj.state_in_sysfs; > > } > > > > +/* Callback types */ > > +#define OF_OVERLAY_PRE_APPLY (0) > > +#define OF_OVERLAY_POST_APPLY (1) > > +#define OF_OVERLAY_PRE_REMOVE (2) > > +#define OF_OVERLAY_POST_REMOVE (3) > > Can we make this an enum? Yes. And I can move it from of.h to overlay.c. Thanks for the nits! Alan > > Cheers, > > Moritz >